Author Topic: Do we need so many tab pages in the message panel?  (Read 9604 times)

Offline nanyu

  • Almost regular
  • **
  • Posts: 188
  • nanyu
Do we need so many tab pages in the message panel?
« on: May 31, 2010, 06:39:36 am »
now we have :

1 Code::Blocks (log)
2 Search results
3 Cccc
4 Build log
5 Build messages
6 CppCheck
7 CppCheck messages
8 Debugger
9 Debugger(Debug)
10 Thread search

We should be able to merge some items :

1 Code::Blocks (log)
2 Search results
3 Cccc
4 Build log / Build messages
5 CppCheck
6 Debugger
7 Thread search




[attachment deleted by admin]

Online oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12597
    • Travis build status
Re: Do we need so many tab pages in the message panel?
« Reply #1 on: May 31, 2010, 09:25:30 am »
Interesting idea.

Please don't attach images to the forum, because the space on the server is limited and the moderators delete attachments at random, when there is no free space.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline ptDev

  • Almost regular
  • **
  • Posts: 222
Re: Do we need so many tab pages in the message panel?
« Reply #2 on: May 31, 2010, 10:42:07 am »
I agree, the message pane UI has become very crowded over the last few years, and many new users may feel overwhelmed.

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7253
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: Do we need so many tab pages in the message panel?
« Reply #3 on: May 31, 2010, 11:26:23 am »
I agree, the message pane UI has become very crowded over the last few years, and many new users may feel overwhelmed.
I think a change is not so simple, even if it should be possible and looks interesting at the first look.

I'm currently working on a patch to save the order of the tabs and whether they are visible or not.
That would make the message pane more clear.

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7253
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: Do we need so many tab pages in the message panel?
« Reply #4 on: June 03, 2010, 04:49:30 pm »
I'm currently working on a patch to save the order of the tabs and whether they are visible or not.
That would make the message pane more clear.

Here it is:
The state of tabs in message-pane is saved together with the perspective changes.
The last selected tab can also be saved, but this is configurable ("Settings -> Environment... -> View -> Save selected tab in message pane on perspective change"). It's the default behaviour, but can make the annoying-dialog that asks whether the user wants to save a perspective-change pop up much more often.

The context menu where the user can toggle the visibility shows the tabs in correct order even if they have been dragged to another place (in almost any cases).
I show loggers and non-loggers without to seperate them, because that is not really needed in my opinion.

The patch is against actual trunk (r6328).

Any feedback welcome.

[attachment deleted by admin]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5234
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Do we need so many tab pages in the message panel?
« Reply #5 on: June 04, 2010, 04:38:02 am »
Failed apply the patch on the main.cpp. (Both TortoiseSVN or command line patch.exe were failed, cc_branch, rev 6328). The main.cpp is just merged from trunk.(copy trunk to cc_branch).

Not sure why... :(

Edit: See the screen shot:


[attachment deleted by admin]
« Last Edit: June 04, 2010, 04:44:22 am by ollydbg »
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9594
Re: Do we need so many tab pages in the message panel?
« Reply #6 on: June 04, 2010, 06:25:46 am »
Not sure why... :(
Applying the patch on trunk (NOT any branch) works flawlessly using patch. The more I hear about these issues with TortoiseSVN I think you really should consider to use a different SVN client.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5234
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Do we need so many tab pages in the message panel?
« Reply #7 on: June 04, 2010, 06:57:00 am »
Applying the patch on trunk (NOT any branch) works flawlessly using patch.
Thanks for the reply.
I just do the applying against the trunk. it works flawlessly using TortoiseSVN.  :D So, the main reason is: it should against the trunk instead any other branches. These days, I nearly abandon the trunk, because I always used cc_branch. :D

Quote
The more I hear about these issues with TortoiseSVN I think you really should consider to use a different SVN client.
Thanks. I will reconsider the svn client. but seems after trying several alternatives some days ago, the TortoiseSVN I think is still the most powerful svn free ( include open source ) client under windows. :D
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7253
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: Do we need so many tab pages in the message panel?
« Reply #8 on: June 04, 2010, 07:30:13 am »
The patch is against actual trunk (r6328).

I thought it was clear that it is against trunk.
Subversion takes the actual revision number of the whole repo not the one of the used branch.
« Last Edit: June 04, 2010, 07:33:07 am by jens »

Online oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12597
    • Travis build status
Re: Do we need so many tab pages in the message panel?
« Reply #9 on: June 05, 2010, 01:49:40 pm »
Started testing the patch, but first I need to make it apply against the debugger branch...

One question though:
Do we need the InfoPane::num_pages constant? Isn't it better to remove it and always use page.GetCount()?
« Last Edit: June 05, 2010, 02:06:25 pm by oBFusCATed »
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7253
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: Do we need so many tab pages in the message panel?
« Reply #10 on: June 05, 2010, 02:22:19 pm »
We use it to make sure the range from baseID to baseID + numPages can not be used as ID by others.

So we have a range of ID's we can associate with our tabs and recalc the tab-id from the eventID.

It might be possible to do it another way.
I will look into it.

Online oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12597
    • Travis build status
Re: Do we need so many tab pages in the message panel?
« Reply #11 on: June 05, 2010, 02:27:52 pm »
Yes, And this mechanism will fail if the count of pages > num_pages, which is possible at the moment.

Here is the modified patch for the debugger_branch: http://smrt.is-a-geek.org/codeblocks/patches/message_pane_order2.patch

After simple testing it seems to work...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7253
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: Do we need so many tab pages in the message panel?
« Reply #12 on: June 06, 2010, 10:24:25 pm »
Yes, And this mechanism will fail if the count of pages > num_pages, which is possible at the moment.

Here is the modified patch for the debugger_branch: http://smrt.is-a-geek.org/codeblocks/patches/message_pane_order2.patch

After simple testing it seems to work...
I updated the patch to get rid of the num_pages constant.
Only infopane.* have changed since the first patch, so it should be easier to merge it with the debugger-branch patch.

[attachment deleted by admin]

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7253
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: Do we need so many tab pages in the message panel?
« Reply #13 on: July 11, 2010, 08:45:36 pm »
Are there any experiences (expect for this one) ?

Are there any objections against committing the patch ?

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9594
Re: Do we need so many tab pages in the message panel?
« Reply #14 on: July 12, 2010, 04:14:15 pm »
Are there any experiences
I've used it, too since day one, no issues here.

Are there any objections against committing the patch ?
Not from my side.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ