Patches to compile and link C::B against wxWidgets 2.8.0

[stahta01]

Note: 2.8.0 has been released see http://sourceforge.net/project/showfiles.php?group_id=9863
Note: 2.8.1 was put on hold/canceled for wxMSW.

killerbot's Summary of this thread "CB and wx28 state"
  http://forums.codeblocks.org/index.php?topic=4816.msg37734#msg37734
 
Note: These patches are useful ONLY to developers who can compile C::B from SVN
Note: These patches have yet to be approved by the Code::Blocks team.
Note: AS-IS No warranty, use with caution.
Note: This research stated in thread http://forums.codeblocks.org/index.php?topic=4344.0


Editing: I am starting work on patches to reduce warning on compiling against wxWidgets 2.8

Patches to get Code::Blocks to compile and link against wxWidgets 2.8.x

 Patches to Code::Blocks projects files (Needed by windows Users ONLY):
  [ Patch #1733 ] wxmsw28 patch for wxWidgets 2.8
    https://developer.berlios.de/patch/?func=detailpatch&patch_id=1733&group_id=5358
  Please see this post for a new solution
    http://forums.codeblocks.org/index.php?topic=5199.msg40619#msg40619

 Patches to Code::Blocks scripted wizard
  [ Patch #1880 ] Truncated new project scripted wizard fix for wxW28 Author: Not Known
    https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1880&group_id=5358

  [ Patch #1893 ] wxCheckListBox patch for wxWidgets 2.8 Submitted By: stahta01 found by wxLearner
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1893&group_id=5358
 
Known Issues:

Recently Solved Issues:

 The patch for the current wxSmith is here.
  [ Patch #1903 ] wxSmith patch for wxW28 and wxPropertyGrid 1.2.x Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1903&group_id=5358

Patches applied to C::B SVN
  [ Patch #1731 ] scripting patch for wxWidgets 2.8
    https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1731&group_id=5358
 [ Patch #1661 ] wxCheckListBox patch for wxWidgets 2.7 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1661&group_id=5358
 [ Patch #1628 ] compilergcc patch for wxWidgets 2.7 Submitted By: afb
   https://developer.berlios.de/patch/?func=detailpatch&patch_id=1628&group_id=5358
 [ Patch #1738 ] wxHIDE_READONLY patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1738&group_id=5358
 [ Patch #1734 ] ScintillaWX patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1734&group_id=5358
 [ Patch #1739 ] wxPropertyGrid patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1739&group_id=5358
 [ Patch #1736 ] compilergcc patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/?func=detailpatch&patch_id=1736&group_id=5358
 [ Patch #1735 ] pipedprocess patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1735&group_id=5358
 [ Patch #1762 ] CentreOnScreen patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/?func=detailpatch&patch_id=1762&group_id=5358
 [ Patch #1730 ] wxaui patch for wxWidgets 2.8 Submitted By: stahta01 based on afb work.
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1730&group_id=5358
 [ Patch #1767 ] Old wxSmith patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1767&group_id=5358
 [ Patch #1732 ] keybinder plugin patches for wxWidgets 2.8 Submitted By: stahta01 based on afb work.
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1732&group_id=5358

Patches obsoleted because other fix was found
  [ Patch #1737 ] selecttargetdlg patch for wxWidgets 2.8 Submitted By: stahta01
    https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1737&group_id=5358

 [ Patch #1766 ] NEW (experimental) wxSmith patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/?func=detailpatch&patch_id=1766&group_id=5358

The patch for the OLD wxSmith for wxWidgets 2.8.0 bug; this is supposed to be fixed in 2.8.1
  [ Patch #1771 ] Old wxSmith patch for wxListbook::HitTest protected wxW2.8
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1771&group_id=5358
   wxWidgets Bug report
      https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1626543&group_id=9863

Tim S

[killerbot]

thanks for the nice overview :-)

I hope this will be addressed by the wx guys, otherwise they can keep their wx2.8 ;-)

Patches to wxWidgets 2.8.0rc1:
 Fix to Bitmaps are not loading in toolbars.
  Upgrade /src/common/fs_arc.cpp to CVS version 1.5 [Needed by Window Users]
  Apply patch xrs_images.patch from
     http://sourceforge.net/tracker/index.php?func=detail&aid=1598839&group_id=9863&atid=109863
 

[stahta01]

thanks for the nice overview :-)

I hope this will be addressed by the wx guys, otherwise they can keep their wx2.8 ;-)

Patches to wxWidgets 2.8.0rc1:
 Fix to Bitmaps are not loading in toolbars.
  Upgrade /src/common/fs_arc.cpp to CVS version 1.5 [Needed by Window Users]
  Apply patch xrs_images.patch from
     http://sourceforge.net/tracker/index.php?func=detail&aid=1598839&group_id=9863&atid=109863
 

They are working on it; CVS Head even has been fixed for this issue (I have not confirmed the fix really fixes the problem), but CVS Head has several errors for C::B relating to wxAui changes.

Edit: The changes were renaming constants, I fixed them and C::B worked with icons OK.

Tim S

[stahta01]

Deleted

[afb]

Works OK on Mac OS X 10.4 with Code::Blocks 1.0 SVN + above patches with wxWidgets 2.8 CVS:



The only things that you additionally need is to patch the known Mac issues and the splash screen...

[sethjackson]

Nice. 

[afb]

Hmm, might have spoken a bit too soon... 

Start application, open project, compile = OK.
Open up the preferences dialog = Crash. Die.

Anyway, it's on the "right path" so we can probably
support both wxWidgets 2.6 and 2.8 with C::B 1.0 ?

[stahta01]

Hmm, might have spoken a bit too soon... 

Start application, open project, compile = OK.
Open up the preferences dialog = Crash. Die.

Anyway, it's on the "right path" so we can probably
support both wxWidgets 2.6 and 2.8 with C::B 1.0 ?

It crashed the last time I tried CVS-Head.

I was thinking that C::B 1.5 could support both wxWidgets 2.6 and 2.8 with WXWIN_COMPATIBILITY_2_4 turned off for both.

I would NOT try to get wxWidgets 2.8 support into C::B 1.0, I wxWidgets 2.8 does not look good right now, till the final 2.8.0 is done we can't really say if C::B will work with it.

Tim S

[afb]

You are probably right. While we could integrate some of the minor improvement patches, we should probably wait with the pure "ABI compatibility" ones until after 1.0 has been released (like for 1.5 or something). Otherwise we'd just end up with people assuming that it is supported.

Better get it working solidly with wxWidgets 2.6 (patched!) first, and then do a wxWidgets 2.8 version.

wxWidgets 2.8 does not look good right now, till the final 2.8.0 is done we can't really say if C::B will work with it.

Then again, that's just one week to wait...  :lol:

[afb]

I was thinking that C::B 1.5 could support both wxWidgets 2.6 and 2.8 with WXWIN_COMPATIBILITY_2_4 turned off for both.

This might be a problem for 2.6, which has it "on" by default. (can't we work around it ?)

[killerbot]

first of all, let's see what wx 2.8 brings . Will it fix some of the bugs we are suffering from the 2.6, if yes, then it light be interesting to use 2.8. If not, then might be best to wait.

[David Perfors]

I think it is possible to get wx2.8 support in 1.0 we are even still waiting for RC3....

[kai]

on linux wxwidgets2.8 has a few bug fixes and i already use it successfully with code::blocks (except for a bug concerning debugging).

the most important fix: the drag and drop xserver freeze bug has been fixed.
selections in tree or list views don't look ugly on ubuntu anymore (before they had a saturated ugly orange colour)
wxaui also looks better - the mouse cursor changes now when it's above the sash.

[stahta01]

I was thinking that C::B 1.5 could support both wxWidgets 2.6 and 2.8 with WXWIN_COMPATIBILITY_2_4 turned off for both.

This might be a problem for 2.6, which has it "on" by default. (can't we work around it ?)

We can just turn it on for just 2.6; 2.8 has it off by default. I think it will require more work if we don't turn it off for 2.6 but the amount of work won't be that much. Just some #ifdef blocks in codeblocks.

From a user point of view having it on for 2.6 and off for 2.8 will be the simplest way. I will work on a patch to fix code::blocks so it works both with WXWIN_COMPATIBILITY_2_4 on or off.

From a coder point of view having WXWIN_COMPATIBILITY_2_4 set the same, either 1 or 0, would be the simplest way.

Note: I tried just defining WXWIN_COMPATIBILITY_2_4 as 0 and wxHIDE_READONLY as 0,but C::B crashed too much.

Tim S

[sethjackson]

Why do we need WXWIN_COMPATIBILITY_2_4? C::B won't even compile with that version of wx........