Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Plugins development => Topic started by: wxLearner on June 20, 2007, 10:33:00 am

Title: [Scripted wizard] Not all pages are added into PageAreaSizer
Post by: wxLearner on June 20, 2007, 10:33:00 am

Hello,
as stated here (http://forums.codeblocks.org/index.php/topic,5071.msg40827.html#msg40827), I think, all pages should get into the PageAreaSizer. Also, adding all pages should work for wx2.6 and wx2.8. At the moment, the minimal size of the scripted wizard isn't computed correctly (it's not wide enough) on my WinXP, if the wizard's "welcome page" isn't skipped. If I modify the code (wiz.cpp), and add all pages, the size seems to be good.
Is there a reason, not to add all pages into the wizard's PageAreaSizer?

Title: Re: [Scripted wizard] Not all pages are added into PageAreaSizer
Post by: Biplab on June 20, 2007, 10:59:09 am

Quote from: wxLearner on June 20, 2007, 10:33:00 am

Is there a reason, not to add all pages into the wizard's PageAreaSizer?

If you add all the pages, then the wizard page gets truncated and only the image portion remains visible. It happens with wx-2.8.x.

Title: Re: [Scripted wizard] Not all pages are added into PageAreaSizer
Post by: wxLearner on June 20, 2007, 11:38:11 am

Quote from: Biplab on June 20, 2007, 10:59:09 am

If you add all the pages, then the wizard page gets truncated and only the image portion remains visible. It happens with wx-2.8.x.

For me this issue doesn't appear, if really all pages are added (also the first one):

Code

for (size_t i = 0; i < m_Pages.GetCount(); ++i) //start with 0, i.e. the first page
        m_pWizard->GetPageAreaSizer()->Add(m_Pages[i]);

I think, the issue, you have mentioned, appears only, if the first page isn't added, like it's done at the moment if wxCHECK_VERSION(2, 8, 0) is false:

Code

for (size_t i = 1; i < m_Pages.GetCount(); ++i) //start with 1 and ignore the first page
        m_pWizard->GetPageAreaSizer()->Add(m_Pages[i]);

Title: Re: [Scripted wizard] Not all pages are added into PageAreaSizer
Post by: Biplab on June 20, 2007, 11:48:27 am

Quote from: wxLearner on June 20, 2007, 11:38:11 am

Quote from: Biplab on June 20, 2007, 10:59:09 am

If you add all the pages, then the wizard page gets truncated and only the image portion remains visible. It happens with wx-2.8.x.

For me this issue doesn't appear, if really all pages are added (also the first one):

Let me check it. But it would be nice if it works that way.  :)

Update: It works well. :)

Title: Re: [Scripted wizard] Not all pages are added into PageAreaSizer
Post by: Biplab on June 20, 2007, 02:29:09 pm

Patch applied in rev 4119. Thanks for the fix. :)