Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Plugins development => Topic started by: MortenMacFly on May 30, 2007, 08:26:43 am

Title: [wxSmith]: 2 minor issues
Post by: MortenMacFly on May 30, 2007, 08:26:43 am

Dear Byo,
2 minor issues I've  just discovered:
1.) wxscoder.cpp: Line 171 should read:

Code

for ( size_t i=0; i<Content.Length(); i++ )

to avoid compiler warnings.
2.) wxscustombutton.cpp: Line 99:

Code

Style.RemoveLast();

is not compatible with wx 2.6.x as there is no such method "RemoveLast()". Maybe you will guard this?
With regards, Morten.

Title: Re: [wxSmith]: 2 minor issues
Post by: byo on May 30, 2007, 10:40:26 am

Quote from: MortenMacFly on May 30, 2007, 08:26:43 am

Dear Byo,
2 minor issues I've  just discovered:
1.) wxscoder.cpp: Line 171 should read:

Code

for ( size_t i=0; i<Content.Length(); i++ )

to avoid compiler warnings.

Right, that's correct.

Quote

2.) wxscustombutton.cpp: Line 99:

Code

Style.RemoveLast();

is not compatible with wx 2.6.x as there is no such method "RemoveLast()". Maybe you will guard this?
With regards, Morten.

And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

Regards
  BYO

Title: Re: [wxSmith]: 2 minor issues
Post by: MortenMacFly on May 30, 2007, 11:13:53 am

Quote from: byo on May 30, 2007, 10:40:26 am

And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

Sorry Byo, my mistake. I meant: EndsWith() in line 97. The error is:

Code

C:\Devel\CodeBlocks\src\plugins\contrib\wxSmithContribItems\wxthings\wxscustombutton.cpp:97: error: 'class wxString' has no member named 'EndsWith'

Sorry... ;-)
With regard, Morten.

Title: Re: [wxSmith]: 2 minor issues
Post by: byo on May 30, 2007, 07:47:50 pm

Quote from: MortenMacFly on May 30, 2007, 11:13:53 am

Quote from: byo on May 30, 2007, 10:40:26 am

And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

Sorry Byo, my mistake. I meant: EndsWith() in line 97. The error is:

Code

C:\Devel\CodeBlocks\src\plugins\contrib\wxSmithContribItems\wxthings\wxscustombutton.cpp:97: error: 'class wxString' has no member named 'EndsWith'

Sorry... ;-)
With regard, Morten.

Hmm, now you're right. But finally I had to remove EndsWith because this code was buggy (fixed version doesn't require EndsWith call).

Thanks for reporting :)

BYO