Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: stahta01 on February 18, 2007, 11:39:56 pm

Title: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on February 18, 2007, 11:39:56 pm
FYI:

I had some patches I submitted on Berlios that needed closed. Thanks for closing them.

    [ Patch #1884 ] Updated ANSI build patch file ANSI_BUILD_cb-projectfiles.pat
        https://developer.berlios.de/patch/?func=detailpatch&patch_id=1884&group_id=5358
             Reason: posted better solution in thread listed in patch.

    [ Patch #1783 ] GetConfigFolder patch to make it work in a Portable win32
        https://developer.berlios.de/patch/?func=detailpatch&patch_id=1783&group_id=5358
             Reason: Patch does NOT meet Code::Blocks Team requirement to NOT change API on class method.

    [ Patch #1696 ] patch to the old wxSmith to use wxPropertyGrid version 1.2.x
        https://developer.berlios.de/patch/?func=detailpatch&patch_id=1696&group_id=5358
             Reason: wxSmith was updated to new code base so patch does not apply.

    [ Patch #1733 ] wxmsw28 patch for wxWidgets 2.8
        https://developer.berlios.de/patch/?func=detailpatch&patch_id=1733&group_id=5358
             Reason: posted better solution in thread listed in patch.


Tim S
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Ceniza on February 19, 2007, 04:55:45 am
Done.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on February 25, 2007, 09:57:15 pm
Note, I have three patches that need closed because I have submitted an updated single patch file.

Thanks, for closing them.

Tim S


[ Patch #1771 ] Old wxSmith patch for wxListbook::HitTest protected wxW2.8
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1771&group_id=5358

[ Patch #1766 ] NEW (experimental) wxSmith patch for wxWidgets 2.8
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1766&group_id=5358

[ Patch #1702 ] patch to the old wxSmith to use wxPropertyGrid version 1.2.x
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1702&group_id=5358


Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Der Meister on February 25, 2007, 10:18:37 pm
Here is another one:

[ Patch #1562 ] Enable gpm for wxGTK
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1562&group_id=5358

It had a bad side effect that noticed some time after I submitted this patch.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: killerbot on February 25, 2007, 10:59:57 pm
closing those 4 patches
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on May 20, 2007, 07:07:51 pm
Please close my [ Patch #1788 ] SDK patch to reduce warning for wxWidgets 2.8
http://developer.berlios.de/patch/?func=detailpatch&patch_id=1788&group_id=5358

reason: is because another patch solves the same problem. Uses a different solution that should match C::B needs better. I have not looked at the patch, but sounds better than mine.
Tim S

The better patch is 1982  "Eliminate signed/unsigned compiler warnings"
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Biplab on May 20, 2007, 07:19:07 pm
Please close my [ Patch #1788 ] SDK patch to reduce warning for wxWidgets 2.8

Closed. :)

reason: is because another patch solves the same problem. Uses a different solution that should match C::B needs better. I have not looked at the patch, but sounds better than mine.

I hope you're referring to the following code submitted by pauliusz. Original patch will surely generate warning in wx 2.6.
Quote
Good example:
- for (selection = m_Selection+1; selection<clbTargets->GetCount(); ++selection)
+ for (selection = m_Selection + 1; selection < static_cast<int>(clbTargets->GetCount()); ++selection)

Regards,

Biplab
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: pauliusz on May 21, 2007, 12:42:47 am
Please close [ Feature Request #3301 ] The Tools Menu -- Separators
http://developer.berlios.de/feature/?func=detailfeature&feature_id=3301&group_id=5358 (http://developer.berlios.de/feature/?func=detailfeature&feature_id=3301&group_id=5358)

Patch for this feature was applied some time ago...
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Ceniza on May 21, 2007, 01:08:32 am
Feature Request #3301 closed.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: pauliusz on June 01, 2007, 12:16:25 am
Please close [ Patch #2016 ] Add support for WinAVR compiler (Feature Request #3413)
http://developer.berlios.de/patch/?func=detailpatch&patch_id=2016&group_id=5358 (http://developer.berlios.de/patch/?func=detailpatch&patch_id=2016&group_id=5358)
and [ Feature Request #3413 ] Complete AVR-GCC integration
http://developer.berlios.de/feature/?func=detailfeature&feature_id=3413&group_id=5358 (http://developer.berlios.de/feature/?func=detailfeature&feature_id=3413&group_id=5358)

Everything is already in SVN
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Ceniza on June 01, 2007, 03:18:33 am
Patch #2016 and Feature Request #3413 closed.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: dmoore on June 01, 2007, 05:20:33 pm
it looks like patch 2026 is redundant - someone has already implemented the double click feature.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Ceniza on June 01, 2007, 05:38:35 pm
Patch #2026 closed.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on June 09, 2007, 06:53:32 am
Please close patch #1908 "Patch SDK files for wxW28 with disable_compat26"
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1908&group_id=5358


It has mainly been fixed by other patches to eliminate warning in Code::Blocks.

Thanks
Tim S
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Biplab on June 09, 2007, 07:01:43 am
Patch closed. Thanks Tim. :)
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on June 09, 2007, 06:58:20 pm
Please close patch #1911 "Patch Share Config file for wxW28 with disable_compat26"
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1911&group_id=5358

Thanks.

Tim S

Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Biplab on June 09, 2007, 07:08:10 pm
Closed. :)
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: dmoore on June 25, 2007, 02:55:43 pm
please close

https://developer.berlios.de/patch/?func=detailpatch&patch_id=2048&group_id=5358

(didn't appear to help)
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: rickg22 on June 25, 2007, 04:08:10 pm
Closed.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: rickg22 on June 27, 2007, 01:52:38 am
Has patch #1992 been addressed? It's a PCH fix for win32.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on June 27, 2007, 02:02:00 am
Has patch #1992 been addressed? It's a PCH fix for win32.

No, It has never been applied and it is still needed to compile windows without pre-compiled headers.

Applied in last month.
Tim S
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: pauliusz on July 24, 2007, 11:53:55 pm
Please close:

[ Patch #1947 ] wxPropertyGrid 1.2.6->1.2.7
http://developer.berlios.de/patch/?func=detailpatch&patch_id=1947&group_id=5358 (http://developer.berlios.de/patch/?func=detailpatch&patch_id=1947&group_id=5358)
because I added new patch [ Patch #2104 ] wxPropertyGrid 1.2.6->1.2.8

[ Patch #2047 ] Patch for Bug #11060
http://developer.berlios.de/patch/?func=detailpatch&patch_id=2047&group_id=5358 (http://developer.berlios.de/patch/?func=detailpatch&patch_id=2047&group_id=5358)
because it has bad side effects and modifies CB base code... and currently I am not working on this bug.
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: killerbot on July 25, 2007, 12:12:18 am
Please close:

[ Patch #1947 ] wxPropertyGrid 1.2.6->1.2.7
http://developer.berlios.de/patch/?func=detailpatch&patch_id=1947&group_id=5358 (http://developer.berlios.de/patch/?func=detailpatch&patch_id=1947&group_id=5358)
because I added new patch [ Patch #2104 ] wxPropertyGrid 1.2.6->1.2.8

[ Patch #2047 ] Patch for Bug #11060
http://developer.berlios.de/patch/?func=detailpatch&patch_id=2047&group_id=5358 (http://developer.berlios.de/patch/?func=detailpatch&patch_id=2047&group_id=5358)
because it has bad side effects and modifies CB base code... and currently I am not working on this bug.
done
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: stahta01 on July 29, 2007, 03:04:45 pm
Please close patches because support for wxWidgets 2.6 has been dropped from Code::Blocks.

[ Patch #1985 ] wx261 does not build CB under windows
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1985&group_id=5358


Still open, will request again after I write the replacement patch.
[ Patch #2043 ] Patch CB Core files for wxW28 with disable_compat26
https://developer.berlios.de/patch/?func=detailpatch&patch_id=2043&group_id=5358

Thanks

Tim S
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Biplab on July 29, 2007, 05:19:17 pm
Closed Patch#1985. I've kept Patch#2043 open as it may still be required. :)
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: dmoore on July 30, 2007, 12:25:37 am
please close patch 2110, i have subsumed it into a larger patch
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Biplab on July 31, 2007, 05:34:12 am
please close patch 2110, i have subsumed it into a larger patch

Closed. :)
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: pauliusz on November 03, 2007, 03:31:27 pm
Please close:
Title: Re: Open Patches on Berlios that needs closed without them being applied.
Post by: Biplab on November 03, 2007, 05:10:05 pm
Please close:
  • [ Patch #2104 ] wxPropertyGrid 1.2.6->1.2.8 (http://developer.berlios.de/patch/?func=detailpatch&patch_id=2104&group_id=5358)
    wxPropertyGrid is already updated to 12.10 and I am the author of this patch :)

Closed now. :)