Code::Blocks Forums
Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: arst on February 08, 2007, 05:28:20 pm
-
These are a couple of fixes I've made on my CVS sources.
I've made a patch on BerliOS for it.
1 - Find dialog
When repeating a search (F3), after having searched in selected
text and then deselecting all text, CodeBlocks report not finding it.
It keeps looking in the selection range which has zero length.
The patch fixes it.
2 - Saving files - Symbolic links
I use symbolic links on XP (much like ln under Unix) to make the same
file appear in multiple directories. When saving text files with CB, the
symbolic link breaks. I tracked it down to FileManager::Save which
saves to a temp filename and then copies over the original file. The
symbolic link then disappears and I again have two different files
(which I really want to avoid).
Just saving directly to the filename keeps the symbolic link intact
(with other programs, symbolic links work fine and are not deleted).
I have not made a patch for this since what I did was to disable the
extra copying all together.
Question: With things that are obvious and limited bug fixes (like 1),
does this have to go through the whole patch/assignment/verification
chain?
Regards,
Arst
-
Question: With things that are obvious and limited bug fixes (like 1),
does this have to go through the whole patch/assignment/verification
chain?
Of course since it may contain negative side effects that you didn't notice or you changed the behaviour in a way the developers don't want to.
-
Don't want to argue, I see your point. But...
In the first case in my post I pointed to something that
is quite straight forward (Nobody wants to search for
text in an empty selection range. However, if you have
invoked "Find again", you want to search for something).
There are no side effects to this.
In the 2nd case (win32 sym links deleted on save) I was well
aware there can be side effects, and I wanted some feedback
on it.
OK
// Arst
-
Well, my personal experience shows that small patches that fix obvious problems in a straight forward way get commited to svn quite fast. But still, the process is neccessary.
The best way should be to post the patch at berlios and possibly add a message to the thread "List of community Patches (http://forums.codeblocks.org/index.php?topic=1764.0)".