It still works for me, Alt+F, O always executes the open file dialog and Alt+F, C always executes Close (no jumping). :?
It still works for me, Alt+F, O always executes the open file dialog and Alt+F, C always executes Close (no jumping). :?
It also works on my laptop, Ubuntu Edgy, wx 2.6.3p2 (no jumping).
I also tested this on Vista and I get same results.You've got Vista already??? :shock: And C::B works there in principle? Anything special to consider? Please tell me - that'd be great news! ;-)
I also tested this on Vista and I get same results.You've got Vista already??? :shock: And C::B works there in principle? Anything special to consider? Please tell me - that'd be great news! ;-)
With regards, Morten.
I also tested this on Vista and I get same results.You've got Vista already??? :shock: And C::B works there in principle? Anything special to consider? Please tell me - that'd be great news! ;-)
With regards, Morten.
You don't want to work with Vista, really it is awful. Have tried it, the horror.
You don't want to work with Vista, really it is awful. Have tried it, the horror.That's true, but at work it seems I have to (soon) and it would be horrible if C::B wouldn't work then... that's why I'm so interested in this.
How about all you out there with XP? Does your Alt-F-Open menu item work?Sorry for hijacking this thread... :oops:
You don't want to work with Vista, really it is awful. Have tried it, the horror.That's true, but at work it seems I have to (soon) and it would be horrible if C::B wouldn't work then... that's why I'm so interested in this.
BTW: An upgrade here in Germany for my WinXP-Pro (keeping the functionality I have with it -> so at least Business) would cost me 249 Euro!!! That's *way* more I paid for WinXP Pro (full). I don't what's the sense of this. Does MS want to squeeze the last cent's out of it's (private) customers?
With regards, Morten.
Ps.: Anyway, let's not start a MS flaming.
How about all you out there with XP? Does your Alt-F-Open menu item work?Sorry for hijacking this thread... :oops:
And: No, it doesn't (never tried that before - always use STRG+O).
I've solved the bug, use the patched version of wxWidgets DLL:
http://prdownload.berlios.de/codeblocks/wxmsw26u_gcc_cb_wx2.6.3p2AndCbPatch.7z (http://prdownload.berlios.de/codeblocks/wxmsw26u_gcc_cb_wx2.6.3p2AndCbPatch.7z)
Is this why you're saying you're Windows and Ubuntu works? Because of the patched wxWidgets 2.6.3 version?
Wouldn't that mean that ALL users of XP should be having the problem?
Thanks, would you also try Alt-F-Close with a file open and tell me what happens.Right, so as for Alt-F-O the menu just closes and nothing happens.
Does anyone (artoj?) get Linux underlines for Alt-F-O and Alt-F-C ?
I get mnemonic underlines in Gentoo, and I have not compiled any contrib plugin, if that helps.
no, only one has been applied by me on my pc to build that special dll because the wx guys sort of said to Tim, it's not good, but then it seems they applied it themselves ,.... , hard to figure out ...
no, only one has been applied by me on my pc to build that special dll because the wx guys sort of said to Tim, it's not good, but then it seems they applied it themselves ,.... , hard to figure out ...
it was a 1 liner, it all starts here :
http://forums.codeblocks.org/index.php?topic=4809.msg37667#msg37667
wx guys did it this [http://forums.codeblocks.org/index.php?topic=4809.msg38778#msg38778] way, should try that one. Will see if I can build it tomorrow on windows the patched wx.
it was a 1 liner, it all starts here :
http://forums.codeblocks.org/index.php?topic=4809.msg37667#msg37667
wx guys did it this [http://forums.codeblocks.org/index.php?topic=4809.msg38778#msg38778] way, should try that one. Will see if I can build it tomorrow on windows the patched wx.
you are talking about the line in "wxMenu::DoInsertOrAppend", correct ?
this was how it was in wx262Code// is the item owner-drawn just because of the bitmap?
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() )
{
// try to use InsertMenuItem() as it's guaranteed to look correctly
// while our owner-drawning code is not
and in wx 263 they changed it into :Code// is the item owner-drawn just because of the bitmap?
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() &&
!pItem->GetBitmap(true).Ok() )
{
// try to use InsertMenuItem() as it's guaranteed to look correctly
// while our owner-drawning code is not
did you bring this to the attention of the wx guys.
I am gonna rebuild our wx_cb_dll, this is a nice fix (hopefully with no side effects).
Correct that were I fixed it, and it worked with CVS 2.6_BRANCH with that change. I just commented out to test it like below.
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() /* &&
!pItem->GetBitmap(true).Ok() */ )
// check if we have something more than a simple text item
#if wxUSE_OWNER_DRAWN
if ( pItem->IsOwnerDrawn() )
{
// is the item owner-drawn just because of the bitmap?
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() /* &&
!pItem->GetBitmap(true).Ok() */ )
{
// try to use InsertMenuItem() as it's guaranteed to look correctly
// while our owner-drawning code is not
// Set this to 1 to enable support for the owner-drawn menu and listboxes. This
// is required by wxUSE_CHECKLISTBOX.
//
// Default is 1.
//
// Recommended setting: 1, set to 0 for a small library size reduction
#define wxUSE_OWNER_DRAWN 1
see here : http://forums.codeblocks.org/index.php?topic=4809.msg38937#msg38937 on application of patches to wx [as it seems now, the dll I obtained from it might replace our hacked version of the wx dll, aka HackUpdated ;-)]
[EDIT] I didn't test mnemonics !!
Can you give me a testcase ?
weird, I used the 2 patches.
I have put the 2 source files in a zip file you can find it here : http://users.pandora.be/lieven.de.cock/CodeBlocks/Pecan.7z
If you use the dll I build, does it solve anything for you ??
1) Alt-F-O : opens the file selector
2) Alt-F-C : closes the current file
:-)
weird, I used the 2 patches.
I have put the 2 source files in a zip file you can find it here : http://users.pandora.be/lieven.de.cock/CodeBlocks/Pecan.7z
If you use the dll I build, does it solve anything for you ??
1) Alt-F-O : opens the file selector
2) Alt-F-C : closes the current file
:-)
they come from here : http://forums.codeblocks.org/index.php?topic=4809.msg38778#msg38778
I have uploaded my back port of how this problem was fixed in CVS head. The fix is patch 1637808 which updates the file menu.cpp. I would apply the patch 1637804 before doing this patch because menu uses code in the file ownerdrw.cpp.
Tim S
[ 1637808 ] MSW: menu.cpp backport to 2.6_BRANCH from cvs head
http://sourceforge.net/tracker/index.php?func=detail&aid=1637808&group_id=9863&atid=309863
[ 1637804 ] MSW: ownerdrw.cpp backport to 2.6_BRANCH from cvs head
http://sourceforge.net/tracker/index.php?func=detail&aid=1637804&group_id=9863&atid=309863
no , they are wx sources, not CB sources. Windows people can download are special dll. Linux people need to do it themselves, but they didn't have those problems in the first place (the menu alignment and disabling of icons), so they don't need to do anything.
We don't want people using Cb to build wx themselves.
You don't even have to rebuild CB if you want to use the new dll, since no headers have changed.
Lets say a smart new user wants to debug CB using wxWidgets debug mode. Where would s/he get the patches to make the wxWidgets source mirror the nightly wxLib?
There are already other patches (Scintilla for example) that we apply to external source. How are they maintained. How does a new svn user handle all this?The difference here is that those sources are in our svn repo and are built as part of CB when you build CB.
Lets say a smart new user wants to debug CB using wxWidgets debug mode. Where would s/he get the patches to make the wxWidgets source mirror the nightly wxLib?
I am working on a Wiki page for this
http://wiki.codeblocks.org/index.php?title=Compiling_wxWidgets_2.6.3_to_develop_Code::Blocks_%28MSW%29
I still got a long way to go, but I plan to show how to apply patches to wxWidgets source.
Tim S
I have applied all 3 of them by hand. I think the best way is, to provide a zip file containing the 3 files, so people can just copy it over the original ones. The zip file I made yesterday already contains 2 files, I will be updating it now to contain all 3 files.
And hopefully when wx 2.8.1 (@ Tim : do you have any info on that one ??) the wx 28 people will also be happy. That moment might be interesting to start using it on windows, cause otherwise we also have to make a special wx28 dll .
2.8.1 is not even out