Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: skoehler on November 11, 2006, 02:18:50 am

Title: autorevision.cpp shouldn't use en_US profile
Post by: skoehler on November 11, 2006, 02:18:50 am
Hi,

The file "src/build_tools/autorevision/autorevision.cpp" contains the line:
  set_env("LANG", "en_US");

Please replace it by:
  set_env("LANG", "C");

Does autorevision.cpp also take care of the case, that some LC_* variables may be set?

Why you shouldn't use the en_US profile? For example on my GentooLinux, the en_* profiles are not available. I only bild the de_* profiles when compiling glibc. But "C" profile is always available!
Title: Re: autorevision.cpp shouldn't use en_US profile
Post by: stahta01 on November 11, 2006, 03:29:54 am
Look at this thread http://forums.codeblocks.org/index.php?topic=4302.0

It may help you understand the issue, I can't follow the problem myself.

Tim S
Title: Re: autorevision.cpp shouldn't use en_US profile
Post by: thomas on November 11, 2006, 12:51:10 pm
This entire topic is obsolete now, as autorevision will demand svn to use XML output in the future (the downside is that you will no longer be able to use Subversion 1.2 or 1.1).

However, even before that, it should not matter what languages you or anybody else have installed ony our system. Nobody wants to know. Nobody wants to use them, it has to work anyway.
The issues that existed with autorevision are the very fact that people have certain localisations on their system, for example German or French. That means that Subversion will output something like "Letztes Änderungsdatum" or "Date de la dernière modifciation" or some other bullshit which is impossible to parse. There was no way to get an output that you could parse in a reliable way.

I even intended to use something like "jfwlyidlkjfg" as the locale setting, but Lieven changed it to "en_US" due to demand by a few people who saw errors/warnings (not all systems handle the fallback alike  :?).
Any setting is OK as long as it defaults to the language that is built into the Subversion executable, not some arbitrary localisation (an invalid localisation normally defaults to the string built into the executable, but some systems emit a warning). en_US is what seems to be Subversion's builtin language, so that is what was chosen.
Title: Re: autorevision.cpp shouldn't use en_US profile
Post by: afb on November 11, 2006, 02:44:41 pm
A simple hack meanwhile is:

Code
#ifdef __WIN32__
    set_env("LANG", "en_US");
#else
    set_env("LANG", "C");
#endif
Title: Re: autorevision.cpp shouldn't use en_US profile
Post by: skoehler on November 12, 2006, 08:54:28 pm
Hmm, has this hack been applied already?

I can't find some SVN-webacces so i could check.
Title: Re: autorevision.cpp shouldn't use en_US profile
Post by: artoj on November 12, 2006, 09:08:50 pm
Quote from: skoehler on November 12, 2006, 08:54:28 pm
Hmm, has this hack been applied already?

I can't find some SVN-webacces so i could check.

http://svn.berlios.de/svnroot/repos/codeblocks/trunk/src/build_tools/autorevision/autorevision.cpp (http://svn.berlios.de/svnroot/repos/codeblocks/trunk/src/build_tools/autorevision/autorevision.cpp)