Code::Blocks Forums

User forums => Nightly builds => Topic started by: killerbot on October 12, 2006, 06:39:19 pm

Title: The 12 october 2006 build is out.
Post by: killerbot on October 12, 2006, 06:39:19 pm
Get quick announcements through the RSS feed http://www.codeblocks.org/nightly/CodeBlock_RSS.xml

A link to the unicode windows wxWidget dll for Code::Blocks : http://prdownload.berlios.de/codeblocks/wxmsw26u_gcc_cb_wx2.6.3p2.7z

For those who might need this one (when no MingW installed on your system) : the mingw10m.dll : http://prdownload.berlios.de/codeblocks/mingwm10.7z

For support of ansi builds, a link to the ansi windows wxWidget dll for Code::Blocks : http://prdownload.berlios.de/codeblocks/wxmsw26_gcc_cb_wx2.6.3p2.7z

The 12 October 2006 build is out.
  - Windows : http://prdownload.berlios.de/codeblocks/CB_20061012_rev3079_win32.7z
  - Linux :
         http://prdownload.berlios.de/codeblocks/CB_20061012_rev3079_Ubuntu6.06.deb (not yet)
         http://prdownload.berlios.de/codeblocks/CB_20061012_rev3079_suse100+101.rpm (not yet)


Resolved Fixed:


Regressions/Confirmed/Annoying/Common bugs:


Title: Re: The 12 october 2006 build is out.
Post by: Ceniza on October 12, 2006, 07:06:06 pm
I just found a minor glitch in the new wxFlatNotebook :)

Microsoft (tm) VisualStudio style and tabs at bottom. The background of the active tab is right, but the line border is wrong. It's even more evident with the messages dock.

Anyone familiar with wxFlatNotebook's code? :wink:
Title: Re: The 12 october 2006 build is out.
Post by: takeshimiya on October 12, 2006, 07:45:05 pm
I just found a minor glitch in the new wxFlatNotebook :)

Microsoft (tm) VisualStudio style and tabs at bottom. The background of the active tab is right, but the line border is wrong. It's even more evident with the messages dock.

Anyone familiar with wxFlatNotebook's code? :wink:
Eran :P
Title: Re: The 12 october 2006 build is out.
Post by: Kreso on October 12, 2006, 08:52:36 pm
I got a problem with the debugger: when I have sources placed in actual folders, I can't set breakpoints, whilst when sources are in the same dir as the cbp file, everyhting works great.

in the first case, gdb says that the line XYZ in file src/src.cpp doesn't exist :?

I'm running Gentoo linux, using gdb6.4 from portage.

Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 12, 2006, 09:57:34 pm
Quote from: Ceniza
Microsoft (tm) VisualStudio style and tabs at bottom. The background of the active tab is right, but the line border is wrong. It's even more evident with the messages dock.

I didnt find anything wrong with bottom tabs and VS2005 style ( I guess you mean this style ) - can you post a picture? or email it to me?

I did however found 2 drawing bugs because of the move to renderers with wxFlatNotebook2:

- Try VS2003 (VS7.1) + bottom tabs
- Try Fancy Style + bottom tabs

both are fixed in CVS.

BTW, look here and see who intitated the insertion of wxFlatNotebook into C::B .... :wink:
http://wxforum.shadonet.com/viewtopic.php?t=5761&start=0 (http://wxforum.shadonet.com/viewtopic.php?t=5761&start=0) fourth post from top ...

Eran
Title: Re: The 12 october 2006 build is out.
Post by: Ceniza on October 12, 2006, 10:54:47 pm
This is how it looks when you open Code::Blocks with those settings

(http://gda.utp.edu.co/~ceniza/CodeBlocks/.images/tab0.png)

And this is is how it looks after switching tabs

(http://gda.utp.edu.co/~ceniza/CodeBlocks/.images/tab.png)

After closer inspection (200% :P) the space for the tabs is also reduced and the icons and text drawn lower, which seems to be the real cause for it to happen.

Quote from: Eran
BTW, look here and see who intitated the insertion of wxFlatNotebook into C::B .... :wink:

What a coincidence, isn't it? :wink:
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 12, 2006, 11:14:23 pm
Yes, this is the bug that I mentioned and is already fixed in CVS.

Try to use other styles (try the VC8 style) until the next minor release, which I will make shortly due to number of little, but annoying bugs that I already fixed.

Eran





Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 12:01:29 am
@Eran,

it seems you already have some fixes, and some other code juggling done in the meantime ;-)

do you have plans on a 2.1 in the near future ?

If that's near I'll wait, otherwise I'll manually update by retrieving from cvs.

kind regards,
Lieven
Title: Re: The 12 october 2006 build is out.
Post by: Belgabor on October 13, 2006, 01:43:12 am
Try to use other styles (try the VC8 style) until the next minor release, which I will make shortly due to number of little, but annoying bugs that I already fixed.
I'd love to try VC8, but C::B doesn't allow me to choose that  :(
Title: Re: The 12 october 2006 build is out.
Post by: thomas on October 13, 2006, 09:54:51 am
@Eran,
it seems you already have some fixes, and some other code juggling done in the meantime ;-)
do you have plans on a 2.1 in the near future ?
If that's near I'll wait, otherwise I'll manually update by retrieving from cvs.
Better yet, can we maybe convince you to switch to Subversion? ;)
You know... Subversion is (mostly) a lot better than CVS.

In particular, if you used Subversion, we could simply put an externals definition onto the wxFlatNotebook directory which points to your "stable" branch, and we would never have to worry about updating anything any more. You can develop the same way as before, and whenever you deem your source tree "stable", you make a svn copy to "stable".
The updates will magically appear in every project using wxFNB.
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 09:55:57 am
good idea Thomas, but we have made a few changes to the code ...
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 13, 2006, 10:56:48 am
I am up for it, I tried SVN (Takeshi convinced me for other project to use it) and I love it.
Any suggestion for a good repository place ?

Eran
Title: Re: The 12 october 2006 build is out.
Post by: thomas on October 13, 2006, 11:23:22 am
Any suggestion for a good repository place ?
Uh... the same place where it is now? ;)
I figure that Sourceforge offers Subversion access now. I have never tried it, but they said they do. So you would expect they have a "convert your repository" button somewhere in the admin section.
If they don't, you'll have to run one of those cvs2svn conversion tools yourself (there is half a dozen of them available on the internet). It is quite harmless, worked nicely for the Code::Blocks repository.
But of course, you can also use BerliOS :)

Yiannis: Which tool was it we used back then?

good idea Thomas, but we have made a few changes to the code ...
If everything works as it should, that should even be not a problem. In theory, Subversion should simply merge our changes. However, I only experienced lately that merging isn't always working nicely :lol:
What do we need to change anyway, shouldn't it work out-of-the box, too?
From what I see while quickly scanning over the patch, it mostly changes include paths, registers one additional key event (for whatever it's good?), and replaces an awful lot of seemingly identical lines (--> changed indentation from tab to spaces?).
Is there no way we could get this to work otherwise?
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 13, 2006, 12:13:17 pm
Quote
Yiannis: Which tool was it we used back then?

Yes, some perl script to convert it. I did it at home and then uploaded the (new) svn repository to berlios. I believe sourceforge has a more streamlined conversion process though.

Quote
What do we need to change anyway, shouldn't it work out-of-the box, too?
From what I see while quickly scanning over the patch, it mostly changes include paths, registers one additional key event (for whatever it's good?), and replaces an awful lot of seemingly identical lines (--> changed indentation from tab to spaces?).

Our changes are not that simple ;).

For example, the latest patching I did in wxFNB was to move the EVT_PAGE_SELECTION_CHANGED and EVT_PAGE_SELECTION_CHANGING events to the SetSelection() function, instead of in the OnLeftDown(). The way it was, we were only informed about page selection changing only when the user used the mouse to change pages. But if you used Ctrl-Tab/Shift-Ctrl-Tab we never knew you changed the page, causing all kinds of side-effects for us...
Title: Re: The 12 october 2006 build is out.
Post by: thomas on October 13, 2006, 12:27:37 pm
Our changes are not that simple ;).

For example, the latest patching I did in wxFNB was to move the EVT_PAGE_SELECTION_CHANGED and EVT_PAGE_SELECTION_CHANGING events to the SetSelection() function, instead of in the OnLeftDown(). The way it was, we were only informed about page selection changing only when the user used the mouse to change pages. But if you used Ctrl-Tab/Shift-Ctrl-Tab we never knew you changed the page, causing all kinds of side-effects for us...
But why is the rum gone!

I mean, this is a change that would better be placed in the *real* codebase, as those problems will affect any application, not just ours. I think Arto won't object to adopt changes that are obviously advantageous to everybody ;)

Are there any other major changes that we need besides that?
Title: Re: The 12 october 2006 build is out.
Post by: artoj on October 13, 2006, 12:51:06 pm
I mean, this is a change that would better be placed in the *real* codebase, as those problems will affect any application, not just ours. I think Arto won't object to adopt changes that are obviously advantageous to everybody ;)

Well, this is (should be) a Bazaar (http://en.wikipedia.org/wiki/The_Cathedral_and_the_Bazaar) after all.
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 01:12:40 pm
this weekend I will 'document [== readable text]' the changes we made (the number is rather small, but don't look at the patch, it's awfull because of white space stripping), so then it will be more clear.
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 13, 2006, 01:31:16 pm
Our changes are not that simple ;).

For example, the latest patching I did in wxFNB was to move the EVT_PAGE_SELECTION_CHANGED and EVT_PAGE_SELECTION_CHANGING events to the SetSelection() function, instead of in the OnLeftDown(). The way it was, we were only informed about page selection changing only when the user used the mouse to change pages. But if you used Ctrl-Tab/Shift-Ctrl-Tab we never knew you changed the page, causing all kinds of side-effects for us...
But why is the rum gone!

I mean, this is a change that would better be placed in the *real* codebase, as those problems will affect any application, not just ours. I think Arto won't object to adopt changes that are obviously advantageous to everybody ;)

Are there any other major changes that we need besides that?

Yes, of course itwould be better if eran (not Arto ;)) would incorporate them in the codebase but until he does we have no other option.
The other changes, I did them quite some time back now and I can't remember them without looking at the code...
Anyway, killerbot will document them and we 'll see.
Title: Re: The 12 october 2006 build is out.
Post by: tiwag on October 13, 2006, 01:33:56 pm
this weekend I will 'document [== readable text]' the changes we made (the number is rather small, but don't look at the patch, it's awfull because of white space stripping), so then it will be more clear.

if you use WinMerge you can suppress all white-space changes and find out the "real" patch
Title: Re: The 12 october 2006 build is out.
Post by: rjmyst3 on October 13, 2006, 01:40:19 pm
Quote
In particular, if you used Subversion, we could simply put an externals definition onto the wxFlatNotebook directory which points to your "stable" branch, and we would never have to worry about updating anything any more. You can develop the same way as before, and whenever you deem your source tree "stable", you make a svn copy to "stable".
The updates will magically appear in every project using wxFNB.

I agree with thomas. As a developer of another project using wxFNB, we too would appreciate wxFNB in svn. But even more, we would be overjoyed to see mandrav's patches in eran's codebase - we too have a problem with only getting page changed events when the pages are clicked ...

Another patch that we got to "harvest" from the codeblocks team is prevention of drag'n'drop to foreign flatnotebooks - I've already submitted this patch to eran (with credit to you guys) and he has implemented it.

To summarize, if we both external'd the source from eran's svn repository, I think everyone would be better off.
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 13, 2006, 01:42:46 pm
But even more, we would be overjoyed to see mandrav's patches in eran's codebase - we too have a problem with only getting page changed events when the pages are clicked ...

Then it seems like eran will "have to" accept a patch due to popular demand, lol :P
Title: Re: The 12 october 2006 build is out.
Post by: thomas on October 13, 2006, 01:52:14 pm
Yes, of course itwould be better if eran (not Arto ;)) would incorporate them

Oi, Arto tricked me with his Bazaar comment! Sorry :)
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 03:11:00 pm
this is what we did to the wxFNB 2.0 sources :
Quote
common change :
   1) header include
      - the original wxFNB code includes it's own headers like this (according do it's directory structure) :
         #include <wx/wxFlatNotebook/header.h>
      - CB has put all sources together in the same directory, and therefor changed to includes to this format :
         #include "header.h"

modified files :

1) popup_dlg.cpp
   - header include (see above for more info)

2) renderer.h
   - header include (see above for more info)

3) renderer.cpp
   - header include (see above for more info)

4) wxFlatNotebook.h
   - header include (see above for more info)
   - remove the definitions of the XPM's from the header (here) to the cpp file (and just extern declare them here)
   - add #define wxFNB_ALLOW_FOREIGN_DND 0x00000080 : purpose : prevent dragging tabs from one notebook to another notebook (is only allowed when this style is active)
   - wxFlatNotebook::DeletePage(), wxFlatNotebook::RemovePage(), wxPageContainer::DeletePage() get a second argument with default value true : bool notify = true  (see below for more info)

5) wxFlatNotebook.cpp
   - header include (see above for more info)
   - remove the definitions of the XPM's from the header to the cpp file (here)
   - wxFlatNotebook::SetSelection (see below for more info : wxPageContainer::OnLeftDown())
   - wxFlatNotebook::DeletePage(), wxFlatNotebook::RemovePage(), wxPageContainer::DeletePage() get a second argument with default value true : bool notify = true  : only when the new argument is true, an event will be posted, otherwise the actions are just silently carried out
   example: in EditorManager::Close(EditorBase*,bool) we call wxFNB->DeletePage(index,false). We don't want our page closing event to be called then: we know we 're closing the page, no need for wxFNB to tell us again. We could avoid this patch but we 'd need to add some considerable amount of logic in our sources. Since this kind of scenario is pretty common, we chose to make this little change in wxFNB
   - wxPageContainer::AddPage() and wxPageContainer::InsertPage() : a SetPosition(wxPoint(1,1)) is carried out on the wxPageInfo
      because later, when repainting, there was a comparison taking place and without this (for newly added pages) we would get artifacts
   - wxPageContainer::OnMiddleDown() : because the original implementation (that was wxFNB 1.3 (or lower)) wouldn't send the wxEVT_COMMAND_FLATNOTEBOOK_PAGE_CLOSING event. Now I see that DeletePage() sends it, so I think it would be safe to ignore this patch.
   - wxPageContainer::OnRightDown() the if(m_pRightClickMenu) is removed : because it was on the top of the function and the right-click menu event wouldn't be called then. I didn't remove it, I just moved it before popping up the menu.
   - wxPageContainer::OnLeftDown() : event generation (re)moved, is being put in "wxFlatNotebook::SetSelection" because otherwise there were no events generated when the user swicthed tabs by means of ctrl-tab (without this modification it only worked when the change was made with the mouse)
   - wxPageContainer::IsTabVisible : correct spelling of the Don's name : Yiannis   ;-)
   - wxPageContainer::OnDropTarget: prevent dragging tabs from one notebook to another notebook (is only allowed when the style wxFNB_ALLOW_FOREIGN_DND is active)


Note : I already compared with the new sources from eranif in cvs, and the set of differences already reduced ;-)

So @eranif : could you take a look on what we did, and see if it makes sense for you to incorporate them in the offcial product.
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 13, 2006, 03:28:01 pm
Most of the changes are making sense, and I will try to incorporate them inside CVS. I think most of them are OK, except for the "header" one, since I want to keep the current directory structure (it is the common contrib directory structure)

I will look at the changes tomorrow (I already insertd the
- wxFNB_ALLOW_FOREIGN_DND
- SetSelection now fires the 'Page Change' instead of OnLeftDown
- All XPM files were moved to fnb_resources.cpp file, fnb_resources.h now externs them all
- Fixed the drawing issue mentioned by Ceniza

OnDropTagret already contains the mentioned fix, ( see above new style: wxFNB_ALLOW_FOREIGN_DND )

With regards,
Eran
Title: Re: The 12 october 2006 build is out.
Post by: RJP Computing on October 13, 2006, 03:41:36 pm
eranif,

I second/third/fourth the move to svn.

Thanks for your effort and the control is great.
Title: Re: The 12 october 2006 build is out.
Post by: thomas on October 13, 2006, 04:06:59 pm
Most of the changes are making sense, and I will try to incorporate them inside CVS. I think most of them are OK, except for the "header" one, since I want to keep the current directory structure (it is the common contrib directory structure)
I didn't understand that one anyway, having the headers in the "standard contrib" fashion works nicely, if we add one more path to the project, doesn't it?
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 04:07:08 pm
Most of the changes are making sense, and I will try to incorporate them inside CVS. I think most of them are OK, except for the "header" one, since I want to keep the current directory structure (it is the common contrib directory structure)

I will look at the changes tomorrow (I already insertd the
- wxFNB_ALLOW_FOREIGN_DND
- SetSelection now fires the 'Page Change' instead of OnLeftDown
- All XPM files were moved to fnb_resources.cpp file, fnb_resources.h now externs them all
- Fixed the drawing issue mentioned by Ceniza

OnDropTagret already contains the mentioned fix, ( see above new style: wxFNB_ALLOW_FOREIGN_DND )

With regards,
Eran


Then the day after tomorrow, I will sync our sources with your's in cvs (have already done that today, but won't commit yet) ;-) , or whenever you get to it
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 04:08:11 pm
Most of the changes are making sense, and I will try to incorporate them inside CVS. I think most of them are OK, except for the "header" one, since I want to keep the current directory structure (it is the common contrib directory structure)
I didn't understand that one anyway, having the headers in the "standard contrib" fashion works nicely, if we add one more path to the project, doesn't it?

will change that accordingly on the "day after tomorrow" :-)
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 13, 2006, 04:11:24 pm
Most of the changes are making sense, and I will try to incorporate them inside CVS. I think most of them are OK, except for the "header" one, since I want to keep the current directory structure (it is the common contrib directory structure)
I didn't understand that one anyway, having the headers in the "standard contrib" fashion works nicely, if we add one more path to the project, doesn't it?

As I commented to killerbot (but seems like he missed it), this is not a problem: we can always re-arrange them like in the original sources.
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 13, 2006, 04:19:33 pm
no I didn't miss it, I just gave a state on what is changed NOW, the future will be different (include difference will be removed, eranif already incorporated some of our changes and maybe the others [no not the others from LOST ;-) ]
Title: Re: The 12 october 2006 build is out.
Post by: Belgabor on October 13, 2006, 04:29:16 pm
Could somebody please while moving around & commenting stuff expose the VC8 style to us poor users?  :D
Title: Re: The 12 october 2006 build is out.
Post by: thomas on October 13, 2006, 04:36:45 pm
Could somebody please while moving around & commenting stuff expose the VC8 style to us poor users?  :D
Does that refer to how to enable it?
Settings --> Environment --> Notebook appearance
Title: Re: The 12 october 2006 build is out.
Post by: Belgabor on October 13, 2006, 04:47:38 pm
Yes. The style is missing from the list.
Title: Re: The 12 october 2006 build is out.
Post by: sethjackson on October 13, 2006, 11:10:30 pm
Try to use other styles (try the VC8 style) until the next minor release, which I will make shortly due to number of little, but annoying bugs that I already fixed.
I'd love to try VC8, but C::B doesn't allow me to choose that  :(

Here is the patch. :)

http://forums.codeblocks.org/index.php?topic=1764.msg33221#msg33221

Props to Eran for making this great control. :D

EDIT:

Screeny.  8)

(http://img113.imageshack.us/img113/7025/cbra6.png)
Title: Re: The 12 october 2006 build is out.
Post by: takeshimiya on October 14, 2006, 12:11:29 am
Here is the patch. :)

Do you got also no-close buttons?

(http://img177.imageshack.us/img177/9518/wxfnbnoclosefc7.png) (http://imageshack.us)
Title: Re: The 12 october 2006 build is out.
Post by: sethjackson on October 14, 2006, 12:22:40 am
Here is the patch. :)

Do you got also no-close buttons?

Yes I don't have close buttons. Are there supposed to be close buttons with this style? I think not because VS8 doesn't AFAIK. However I don't really know. Eran?
Title: Re: The 12 october 2006 build is out.
Post by: takeshimiya on October 14, 2006, 12:28:00 am
I think not because VS8 doesn't AFAIK.
But if that's the case, why isn't there the close button that was before at the right?
BTW, an option to choose between to show the close button inside tabs or at the right of all tabs becomes necessary (I for one can't decide if it's better the 'old-way-firefox-1.x' or not, as now it's very easy to unintentionally close files).
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 14, 2006, 12:38:55 am
the old close button was removed for save space. Hehe, the majority seems to prefer to firefox 2.0 way ;-)
(less mouse-miles)
the VC style does not support the close button on the tab yet, that's stated in the release notes of wxFNB 1.5.
That's why I didn't add the VC8 style yet.
Well gonna add it, but don't come complaining about the close button ;-)
Title: Re: The 12 october 2006 build is out.
Post by: Sagrer on October 14, 2006, 12:47:48 am
1) "this->" code completion don't want to work again. In version from 09.11.2006 it worked.
2) In versions from august, from 09.11.2006 and from 12.11.2006 - founded this thing: if compiler has option
Code
`wx-config --cflags`
or linker has option
Code
`wx-config --libs`
- if i try to launch debugging - CodeBlocks became buzz. I tested this only on WindowsXP. If i delete this options - all work fine.
Title: Re: The 12 october 2006 build is out.
Post by: sethjackson on October 14, 2006, 02:35:47 am
the old close button was removed for save space. Hehe, the majority seems to prefer to firefox 2.0 way ;-)
(less mouse-miles)
the VC style does not support the close button on the tab yet, that's stated in the release notes of wxFNB 1.5.
That's why I didn't add the VC8 style yet.
Well gonna add it, but don't come complaining about the close button ;-)

Thanks. BTW I like the close buttons on the tabs myself. :)
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 14, 2006, 10:10:05 am
When releasing v2.0 there was a bug and VC8 style didnt get the close buttons (if you look closely, you will see that the control does make space for them :wink:)

A fix for this is already in CVS, I think tomorrow (Sunday) I will relelase v2.1 which include the 'x' button on the tab when using vc8 and the discuessed bugs

Eran
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 14, 2006, 10:45:47 am
When releasing v2.0 there was a bug and VC8 style didnt get the close buttons (if you look closely, you will see that the control does make space for them :wink:)

A fix for this is already in CVS, I think tomorrow (Sunday) I will relelase v2.1 which include the 'x' button on the tab when using vc8 and the discuessed bugs

Eran


:-) :-) --> available Sunday evening or Monday in you local CB-shop ....
Title: Re: The 12 october 2006 build is out.
Post by: Belgabor on October 14, 2006, 03:06:01 pm
Thanks guys :D
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 14, 2006, 08:44:39 pm
Hi All,
A quick update:

wxFlatNotebook V2.1 is released and can be downloaded from SF.

here is summary:
Accepted changes:
- Added style wxFNB_ALLOW_FOREIGN_DND
- DeletePage, RemovePage now accepts second argument 'notify' to allows user to enable/disable
  firing of the PAGE_CLOSE/CLOSING events
- All XPM files are now located under fnb_reousrces.cpp, include fnb_resources.h
  if you need them :)
- OnRightDown - the if( m_pRightClickMenu ) was removed, when looking at the code
  I did support for custom user menus, but forgot to remove this 'if' ...
- SetSelection now fires the events: wxEVT_COMMAND_FLATNOTEBOOK_PAGE_CHANGED/ ING instead of OnLeftDown
- OnDropTarget - changed to fit the new style wxFNB_ALLOW_FOREIGN_DND
- Fixed drawing issues with VC7.1 & Fancy style AND bottoms tabs
- Added the missing 'x' button on active tab for VS8 style

Not accepted:
- Changes to the header include (1, 2, 3)
- AddPage, InsertPage - Not accepted, I am not sure if it is needed anymore. However, I DO know
  that a invisible tab must have -1, -1 position set. So far I did not get any drawing
  artifacts, can you guys check and tell me if it still exists?
- OnMiddleDown - like you mentioned, this patch can safely be ignored

Hope now it will be easier for you to handle new versions of wxFlatNotebook :)

Eran
Title: Re: The 12 october 2006 build is out.
Post by: severach on October 15, 2006, 01:46:45 am
Project | Remove Files...

It does absolutely nothing. It doesn't crash. It doesn't bring up a dialog. Now I just edit the .CBP file to remove files from my projects.
Title: Re: The 12 october 2006 build is out.
Post by: Belgabor on October 15, 2006, 04:01:49 am
Project | Remove Files...

It does absolutely nothing. It doesn't crash. It doesn't bring up a dialog. Now I just edit the .CBP file to remove files from my projects.


You can also remove files via right-click on the list tree.
Title: Re: The 12 october 2006 build is out.
Post by: tiwag on October 15, 2006, 05:22:56 am
Project | Remove Files...

It does absolutely nothing. It doesn't crash. It doesn't bring up a dialog. Now I just edit the .CBP file to remove files from my projects.


it does nothing until you select any project in the project manager pane.
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 15, 2006, 11:23:16 pm
Hi All,
A quick update:

wxFlatNotebook V2.1 is released and can be downloaded from SF.

here is summary:
Accepted changes:
- Added style wxFNB_ALLOW_FOREIGN_DND
- DeletePage, RemovePage now accepts second argument 'notify' to allows user to enable/disable
  firing of the PAGE_CLOSE/CLOSING events
- All XPM files are now located under fnb_reousrces.cpp, include fnb_resources.h
  if you need them :)
- OnRightDown - the if( m_pRightClickMenu ) was removed, when looking at the code
  I did support for custom user menus, but forgot to remove this 'if' ...
- SetSelection now fires the events: wxEVT_COMMAND_FLATNOTEBOOK_PAGE_CHANGED/ ING instead of OnLeftDown
- OnDropTarget - changed to fit the new style wxFNB_ALLOW_FOREIGN_DND
- Fixed drawing issues with VC7.1 & Fancy style AND bottoms tabs
- Added the missing 'x' button on active tab for VS8 style

Not accepted:
- Changes to the header include (1, 2, 3)
- AddPage, InsertPage - Not accepted, I am not sure if it is needed anymore. However, I DO know
  that a invisible tab must have -1, -1 position set. So far I did not get any drawing
  artifacts, can you guys check and tell me if it still exists?
- OnMiddleDown - like you mentioned, this patch can safely be ignored

Hope now it will be easier for you to handle new versions of wxFlatNotebook :)

Eran


CB sources updated :
 - did not re-apply the OnMiddleDown (for above reasons)
 - headers remain unchanged -> restructured our source tree
 -AddPage/InsertPage not re-applied, let's see what gives ...

1 *important* change in wxFlatNotebook.cpp : the comment where the boss's name is mentioned "Yiannis".
In your sources it's misspelled ... we don't want to get the Don angry ;-)
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 15, 2006, 11:25:15 pm
Quote
1 *important* change in wxFlatNotebook.cpp : the comment where the boss's name is mentioned "Yiannis".
In your sources it's misspelled ... we don't want to get the Don angry Wink

I could not find it in my sources ... maybe I deleted it by accident?  :oops:

just give me the line number and source (and the comment) and I will add it again ...

Eran
Title: Re: The 12 october 2006 build is out.
Post by: severach on October 16, 2006, 05:59:00 am
it does nothing until you select any project in the project manager pane.
"Add Files.." works anytime and "Remove Files..." only works when a project is selected. That discontinuity is why I didn't look any further. Add, Add Recursively, and Remove must behave exactly the same. You have some options:

1 All grayed out when a project is not selected
2 All available when a workspace contains exactly one project even if it isn't selected
3 An irritating dialog is displayed telling me to click on something or other before trying again.
4 Both always apply to the project that is currently active. There is no need to select it. The options were never greyed out or non working before because there must always be an active project and what does active mean anyways if not that?

I prefer #4 because that's the way Add already works. If I want to add to a project other than the active one I can right click.
Title: Re: The 12 october 2006 build is out.
Post by: killerbot on October 16, 2006, 07:26:26 am
Quote
1 *important* change in wxFlatNotebook.cpp : the comment where the boss's name is mentioned "Yiannis".
In your sources it's misspelled ... we don't want to get the Don angry Wink

I could not find it in my sources ... maybe I deleted it by accident?  :oops:

just give me the line number and source (and the comment) and I will add it again ...

Eran


line 1189 :
Code
	// Thanks to Yiannis AKA Mandrav
Title: Re: The 12 october 2006 build is out.
Post by: tiwag on October 16, 2006, 07:41:59 am
it does nothing until you select any project in the project manager pane.
"Add Files.." works anytime and "Remove Files..." only works when a project is selected. That discontinuity is why I didn't look any further. Add, Add Recursively, and Remove must behave exactly the same. You have some options:

1 All grayed out when a project is not selected
2 All available when a workspace contains exactly one project even if it isn't selected
3 An irritating dialog is displayed telling me to click on something or other before trying again.
4 Both always apply to the project that is currently active. There is no need to select it. The options were never greyed out or non working before because there must always be an active project and what does active mean anyways if not that?

I prefer #4 because that's the way Add already works. If I want to add to a project other than the active one I can right click.

write a bugreport to berlios if you can't live with that behaviour ...
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 16, 2006, 11:40:29 am
wxFlatNotebook V2.1 is released and can be downloaded from SF.

<snip>

Not accepted:
- AddPage, InsertPage - Not accepted, I am not sure if it is needed anymore. However, I DO know
  that a invisible tab must have -1, -1 position set. So far I did not get any drawing
  artifacts, can you guys check and tell me if it still exists?

Now that killerbot has updated our copy of wxFNB to v2.1, I saw (and remembered) what this SetPosition() was supposed to fix.
You can look yourself in C::B messages wxFNB. Suppose that when you close C::B, the "Build log" is the active page. When C::B starts up again, it tries to re-activate the last-active page (the "Build log" in this case). It succeeds doing that but notice what happens without the SetPosition(): The "Build log" is activated but it is set as the first visible tab. One needs to scroll back to see the other tabs.
With the SetPosition() patch, the active tab does not become the first visible too.

At least that's what I remember :).
Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 16, 2006, 12:40:24 pm
I agree with this behavior, and I can confirm it.

BUT, using your solution causes another problem:

When I open the demo, and typing Ctrl+N a new page is added
and set as selected.

Now, when the room for drawing tabs is full, and scrolling is needed, the active tab is not visible until the next Ctrl+N !

in other words, your solution affects the visibility of the selected tab in other cases.

I still think that the behavior you descrivbed is a bug, and I will find another way to solve it.

With regards,
Eran




Title: Re: The 12 october 2006 build is out.
Post by: eranif on October 16, 2006, 12:47:15 pm
Ok, I compared the behavior you described with other application I wrote, and the desired solution is to place the selected tab as last (incase it cant fit into the screen)

I will let you guys know when a fix is ready,

Eran
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 16, 2006, 12:52:46 pm
I agree with this behavior, and I can confirm it.

BUT, using your solution causes another problem:

When I open the demo, and typing Ctrl+N a new page is added
and set as selected.

Now, when the room for drawing tabs is full, and scrolling is needed, the active tab is not visible until the next Ctrl+N !

in other words, your solution affects the visibility of the selected tab in other cases.

I still think that the behavior you descrivbed is a bug, and I will find another way to solve it.

With regards,
Eran

Thanks Eran.
My point was not to "force" you use that particular patch, I just remembered what this was supposed to fix (as a quick hack).
I 'm glad you saw the problem and we 're now eagerly awaiting for the fix :).
Title: Re: The 12 october 2006 build is out.
Post by: severach on October 21, 2006, 07:17:18 am
I'm sure this applies to any version but I'm running Oct 12 so I should post it here.

Add Files Recursively will occasionally add a file already in the project again. I suspect this is because of the Win32 case preserving case insensitive file system. For Win32 a case insensitive compare needs to be inserted somewhere in the dup detection.
Title: Re: The 12 october 2006 build is out.
Post by: severach on October 23, 2006, 12:07:39 am
MinGW lib generation has a bug. Each time I load the Interactive Data Objects project, "lib" gets added to the beginning of the lib name. This results in a succession of library names.

IDO.a
libIDO.a  :shock:
liblibIDO.a
libliblibIDO.a

It's pretty cute but darned annoying to keep going back and removing lib.
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 23, 2006, 12:59:31 am
MinGW lib generation has a bug. Each time I load the Interactive Data Objects project, "lib" gets added to the beginning of the lib name. This results in a succession of library names.

IDO.a
libIDO.a  :shock:
liblibIDO.a
libliblibIDO.a

It's pretty cute but darned annoying to keep going back and removing lib.


And the reason why you have not updated to a more recent nightly where this has been fixed?
Title: Re: The 12 october 2006 build is out.
Post by: severach on October 23, 2006, 06:41:18 pm
Because I didn't believe that it would have been fixed within the last 8 days.
Title: Re: The 12 october 2006 build is out.
Post by: mandrav on October 23, 2006, 07:11:21 pm
Because I didn't believe that it would have been fixed within the last 8 days.

That's why you should check before reporting a bug ;)...