Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: sethjackson on March 05, 2006, 10:30:58 pm

Title: sdk\editormanager.cpp
Post by: sethjackson on March 05, 2006, 10:30:58 pm

Why does there need to be a wxNotebookSizer? The wx manual says it is depreciated. Besides we use wxFNB not wxNotebook.  :? Patch below gets rid of it....

Code: diff

Index: src/sdk/editormanager.cpp
===================================================================
--- src/sdk/editormanager.cpp	(revision 2141)
+++ src/sdk/editormanager.cpp	(working copy)
@@ -208,11 +208,6 @@
 
     CreateSearchLog();
     LoadAutoComplete();
-
-#if !wxCHECK_VERSION(2, 5, 0)
-    /*wxNotebookSizer* nbs =*/
-    new wxNotebookSizer(m_pNotebook);
-#endif
 }
 
 // class destructor

EDIT:

BTW I posted it to the tracker here.

https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=897&group_id=5358

Title: Re: sdk\editormanager.cpp
Post by: thomas on March 05, 2006, 10:52:02 pm

wxWidgets 2.4.2

Title: Re: sdk\editormanager.cpp
Post by: sethjackson on March 05, 2006, 11:58:01 pm

Quote from: thomas on March 05, 2006, 10:52:02 pm

wxWidgets 2.4.2

And who uses that? You cant compile startherepage.cpp with 2.4.2 because of wxLaunchDefaultBrowser() so...... Do we really need to be backwards compatible with 2.4.2?