Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: sethjackson on March 05, 2006, 04:01:13 pm

Title: Show/hide tabs in message pane
Post by: sethjackson on March 05, 2006, 04:01:13 pm

I have noticed a problem with this. When you hide a page in the message pane and the show it again the icon is not correct. It is just the generic one. Ex: the Debugger icon is a gear. Hide the Debugger tab, show it, and the icon is the default icon (pad of paper with a pencil).

Title: Re: Show/hide tabs in message pane
Post by: mandrav on March 05, 2006, 04:15:55 pm

This is a known issue. Hiding/showing message tabs is not yet 100% complete.

Title: Re: Show/hide tabs in message pane
Post by: Der Meister on March 05, 2006, 04:33:31 pm

Well, this patch should fix this issue:

Code

Index: src/sdk/messagemanager.cpp
===================================================================
--- src/sdk/messagemanager.cpp  (revision 2137)
+++ src/sdk/messagemanager.cpp  (working copy)
@@ -479,6 +479,7 @@
     {
         m_pNotebook->GetImageList()->push_back(bitmap);
         m_pNotebook->SetPageImageIndex(index, m_pNotebook->GetImageList()->size() - 1);
+        m_Logs[id]->bitmap = bitmap;
     }
 }

I'm not sure if the copy of the bitmap gets destroyed as it should, but (during my little tests) at least the tabs got the correct icon after showing them again.

Title: Re: Show/hide tabs in message pane
Post by: sethjackson on March 05, 2006, 06:28:54 pm

 8) Hope it gets committed soon. :)