Code::Blocks Forums

User forums => Using Code::Blocks => Topic started by: Charles on March 03, 2006, 02:05:25 am

Title: Fix missing includes
Post by: Charles on March 03, 2006, 02:05:25 am
Fix build (svn snap 2006-03-02 19:15:19 +0100)
Patch:
Code
--- codeblocks/src/sdk/editorcolorset.h.orig	2006-03-02 19:15:19.000000000 +0100
+++ codeblocks/src/sdk/editorcolorset.h 2006-03-02 23:23:36.000000000 +0100
@@ -4,6 +4,7 @@
 #include <wx/dynarray.h>
 #include <wx/hashmap.h>
 #include <wx/intl.h>
+#include <wx/wxscintilla.h>
 #include "settings.h"
 
 // forward decls
--- codeblocks/src/plugins/debuggergdb/debugger_defs.cpp.orig 2006-03-02 19:15:47.000000000 +0100
+++ codeblocks/src/plugins/debuggergdb/debugger_defs.cpp 2006-03-02 23:02:56.000000000 +0100
@@ -2,6 +2,7 @@
 #include "debugger_defs.h"
 #include "debuggerdriver.h"
 #include "debuggertree.h"
+#include <manager.h>
 
 #include <wx/dialog.h>
 #include <wx/font.h>
--- codeblocks/src/plugins/debuggergdb/disassemblydlg.cpp.orig 2006-03-02 19:15:47.000000000 +0100
+++ codeblocks/src/plugins/debuggergdb/disassemblydlg.cpp 2006-03-02 23:14:04.000000000 +0100
@@ -12,6 +12,9 @@
 #include <editorcolorset.h>
 #include <manager.h>
 #include <editormanager.h>
+#include <configmanager.h>
+#include <wx/fontutil.h>
+
 
 #define DEBUG_MARKER 4
 #define DEBUG_STYLE wxSCI_MARK_ARROW
Title: Re: Fix missing includes
Post by: killerbot on March 03, 2006, 09:20:16 am
fixed in rev 2120. But the one in editorcolorset.h seems not to be needed. Inside the header filae nothing from that include seems to be used.
Where during your compile do you get an error ?
Title: Re: Fix missing includes
Post by: mandrav on March 03, 2006, 09:30:17 am
editorcolorset.h does not need this. Please don't edit core header files for no good reason...

This is the second time a patch about this file is posted. Please, do not apply patches without researching their usefulness first...
Title: Re: Fix missing includes
Post by: killerbot on March 03, 2006, 09:31:25 am
it did not change editorcolorset ;-)
why : because it does not need it.    8)
Title: Re: Fix missing includes
Post by: mandrav on March 03, 2006, 09:58:59 am
I know you didn't apply it. It's just a general remark to all devs :)