Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: Huki on September 22, 2018, 05:42:16 pm

Title: [IncrementalSearch] [Patch] fix search history crowding (#740)
Post by: Huki on September 22, 2018, 05:42:16 pm

Hi,

I'm submitting a patch for a fix / improvement in the IncrementalSearch plugin. The plugin records every keystroke in history, which means typing "TERM" leaves the following entries in search history:

Code

TERM
TER
TE
T

We now try to be a bit smarter by only adding the term to history upon:
- leaving focus from the text control
- using prev / next / clear buttons or shortcut keys

Patch is available here (https://github.com/gk7huki/codeblocks_sf/commit/f8b29944bbccbbe287877618f72d5dd9bf702991).

Huki

Title: Re: [IncrementalSearch] [Patch] fix search history crowding
Post by: oBFusCATed on September 22, 2018, 06:53:13 pm

Any user of incremental search willing to test this and post if it is improvement?

@Huki: If you want your patch to not be forgotten it is better to post it on sf.net as a ticket.

Title: Re: [IncrementalSearch] [Patch] fix search history crowding
Post by: Huki on September 23, 2018, 01:36:41 pm

Quote from: oBFusCATed on September 22, 2018, 06:53:13 pm

@Huki: If you want your patch to not be forgotten it is better to post it on sf.net as a ticket.

Ok, I've opened a ticket: https://sourceforge.net/p/codeblocks/tickets/740/