Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: LETARTARE on February 10, 2018, 11:26:16 am

Title: compilergcc.cpp:1454:48: warning: comparison between signed and unsigned integer
Post by: LETARTARE on February 10, 2018, 11:26:16 am

Hello,
for a long time: each compilation 'Code :: Blocks', I get this warning

Quote

compilergcc.cpp:1454:48: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

So I decided to give you a fix on svn11286 :

Quote

Index: plugins/compilergcc/compilergcc.cpp
===================================================================
--- plugins/compilergcc/compilergcc.cpp   (révision 11263)
+++ plugins/compilergcc/compilergcc.cpp   (copie de travail)
@@ -1441,7 +1441,7 @@
         // fill the menu and combo
         for (size_t x = 0; x < m_Targets.GetCount(); ++x)
         {
-            if (m_TargetMenu && x < maxTargetInMenus)
+            if (m_TargetMenu && x < static_cast<size_t>(maxTargetInMenus))
             {
                 wxString help;
                 help.Printf(_("Build target '%s' in current project"), GetTargetString(x).wx_str());
@@ -1451,7 +1451,7 @@
                 m_pToolTarget->Append(GetTargetString(x));
         }
 
-        if (m_TargetMenu && m_Targets.size() > maxTargetInMenus)
+        if (m_TargetMenu && m_Targets.size() > static_cast<size_t>(maxTargetInMenus) )
         {
             m_TargetMenu->Append(idMenuSelectTargetHasMore, _("More targets available..."),
                                  _("Use the select target menu item to see them!"));

Vista Business, wxWidgets-2.8.12, TdmGcc.4.7.1

See you soon.

Title: Re: compilergcc.cpp:1454:48: warning: comparison between signed and unsigned integer
Post by: oBFusCATed on February 10, 2018, 04:52:11 pm

Patches posted on the forum most of the times get lost. If you really want the patch to get in it is better to post it in the tickets section on sf.net.