Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: sethjackson on January 19, 2006, 10:46:53 pm

Title: Windows XP manifests
Post by: sethjackson on January 19, 2006, 10:46:53 pm

Hi I was looking at the manifest creation code, and since this is MSW only I added a *gasps* macro :lol: that lets it compile only on MSW (I hope I did it right). Is this OK? I'm going to submit a patch to SF.net if so.....

Title: Re: Windows XP manifests
Post by: thomas on January 20, 2006, 09:09:06 am

Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)

Title: Re: Windows XP manifests
Post by: sethjackson on January 20, 2006, 05:34:44 pm

Quote from: thomas on January 20, 2006, 09:09:06 am

Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)

Ok I'm not to good with preprocessor macros (I looked at wx sources).....