Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: BlueHazzard on February 06, 2014, 01:57:00 am

Title: ReplaceMacros second parameter in scripts
Post by: BlueHazzard on February 06, 2014, 01:57:00 am

maybe it is to late for me, but can someone lighten me what the second parameter in ReplaceMacros in the wizardscripts is?

ex. wxWidgets project script the boolean false:

Code

buffer.Replace(_T("[NOW]"), ReplaceMacros(_T("$(TODAY)"), false));

in the wiki is only one parameter
http://wiki.codeblocks.org/index.php?title=Scripting_commands

Code

wxString 	ReplaceMacros 	wxString 	Does variable expansion on the input wxString 

and also the binding is made only with one parameter

Code

wxString gReplaceMacros(const wxString& buffer){ return Manager::Get()->GetMacrosManager()->ReplaceMacros(buffer); }
SqPlus::RegisterGlobal(gReplaceMacros, "ReplaceMacros");

i have no idea where this second parameter is going...

greetings

Title: Re: ReplaceMacros second parameter in scripts
Post by: stahta01 on February 06, 2014, 02:17:49 am

I am guessing its a mistake.

I found the below in macrosmanager.h

Code

    void ReplaceMacros(wxString& buffer, ProjectBuildTarget* target = nullptr, bool subrequest = false);
    wxString ReplaceMacros(const wxString& buffer, ProjectBuildTarget* target = nullptr);

I am guessing its using the second of those above.

Just a guess.

After looking closer; I think it is the first one of the two above.

Tim S.

Title: Re: ReplaceMacros second parameter in scripts
Post by: oBFusCATed on February 06, 2014, 08:53:40 am

Does the script works or it fails with errors?
Probably is bug in the script.

Title: Re: ReplaceMacros second parameter in scripts
Post by: LETARTARE on February 06, 2014, 11:36:12 am

I never used the second parameter.
But if you put it, it does not generate an error !
If the second parameter was necessary script would generate a runtime error, because all parameters must be specified.

I think it is a mistake that spread by copying ...

Title: Re: ReplaceMacros second parameter in scripts
Post by: BlueHazzard on February 06, 2014, 11:44:06 am

hmm
The scripts work on the actual implementation of squirrel in c::b. But with my new with sqrat binding they crash, because of the wrong parameter count.
I don't understand why this scripts aren't crashing in the actual version, because there is no binding to squirrel for a function with 2 parameters.

Title: Re: ReplaceMacros second parameter in scripts
Post by: BlueHazzard on February 06, 2014, 12:21:27 pm

After some more investigation i think this is a script error and sqplus don't give a error if the parameter count is to high. So what should i do? Correct the scripts, or provide a overloaded function with the given feature? (I think i will do the second, it is less work, but can have some side effects :P )

greetings

[Edit:]

After a second overlook i think the bool parameter is only for internal use:

Code

void MacrosManager::ReplaceMacros(wxString& buffer, ProjectBuildTarget* target, bool subrequest)
{
[...]
    while ((index = buffer.Index(toNativePath)) != wxNOT_FOUND)
    {
        int end = MatchBrace(buffer, index + toNativePath.Length() - 1);
        wxString content = buffer.Mid(index + toNativePath.Length(), end - index - toNativePath.Length());
!!!     ReplaceMacros(content, target, true);
        buffer.Replace(buffer.Mid(index, end - index + 1), UnixFilename(content), false);
    }
[...]
    if (!subrequest)
    {
        buffer.Replace(_T("%%"), _T("%"));
        buffer.Replace(_T("$$"), _T("$"));
    }
}

so this functionality should not be ported to the scripts or should it?

Title: Re: ReplaceMacros second parameter in scripts
Post by: oBFusCATed on February 07, 2014, 01:13:01 am

Post a patch to trunk please, so we can fix the script there.