Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: Alpha on November 08, 2013, 02:49:14 pm

Title: Rev. 9438 question
Post by: Alpha on November 08, 2013, 02:49:14 pm
By this new method, if we have __UnnamedStruct111 and file #1 this is the 11th unnamed struct, but file #11 has unnamed struct 1.  Are they merged?  Should we instead use unnamedTmp.Printf(_T("%s%s%lu_%lu"), ...) so we have __UnnamedStruct1_11 and __UnnamedStruct11_1 ?
Title: Re: Rev. 9438 question
Post by: oBFusCATed on November 08, 2013, 03:16:20 pm
I think we must find a way to remove these __UnnamedStruct entries at all...
Title: Re: Rev. 9438 question
Post by: ToApolytoXaos on November 08, 2013, 04:04:40 pm
By this new method, if we have __UnnamedStruct111 and file #1 this is the 11th unnamed struct, but file #11 has unnamed struct 1.  Are they merged?  Should we instead use unnamedTmp.Printf(_T("%s%s%lu_%lu"), ...) so we have __UnnamedStruct1_11 and __UnnamedStruct11_1 ?
Alpha, may I ask where did you find this? I'm interested in such peculiar things and I would like to take a look at it.
Title: Re: Rev. 9438 question
Post by: Alpha on November 08, 2013, 06:54:18 pm
Relevant changes are:
Code
http://cb.biplab.in/websvn/comp.php?repname=codeblocks&compare[]=/@9437&compare[]=/@9438
(Found when reading through the log messages (http://cb.biplab.in/websvn/log.php?repname=codeblocks&path=%2F&isdir=1&).)
Title: Re: Rev. 9438 question
Post by: ollydbg on November 09, 2013, 03:18:39 pm
By this new method, if we have __UnnamedStruct111 and file #1 this is the 11th unnamed struct, but file #11 has unnamed struct 1.  Are they merged?  Should we instead use unnamedTmp.Printf(_T("%s%s%lu_%lu"), ...) so we have __UnnamedStruct1_11 and __UnnamedStruct11_1 ?
Hi, Alpha, thanks for the review, indeed this is a bug. I fix this bug in rev 9443 by adding an underscore between file index and token index.