Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: golgepapaz on June 14, 2013, 09:25:06 am

Title: rev 9137 causes C::B to use common controls 6.0.0
Post by: golgepapaz on June 14, 2013, 09:25:06 am
Manifest files introduced with the change makes C::B use common controls 6.0.0 (probably)
it looks ugly.To be sure I've checked it with the latest nightly build 9156 http://forums.codeblocks.org/index.php/topic,18034.0.html

How did this go unnoticed or is it just me?

Screenshots
pre 9137

(http://db.tt/sMLBlz7J)

after 9137

(http://db.tt/qdZKhW6i)

Title: Re: rev 9137 causes C::B to use common controls 6.0.0
Post by: MortenMacFly on June 14, 2013, 10:37:54 am
...confirmed. I'll look into it. The actual idea was to be natively compatible with Windows 7/8.
Title: Re: rev 9137 causes C::B to use common controls 6.0.0
Post by: MortenMacFly on June 16, 2013, 10:36:12 am
Quote from: MortenMacFly on June 14, 2013, 10:37:54 am
...confirmed. I'll look into it. The actual idea was to be natively compatible with Windows 7/8.
Just a quick note: Its not as easy as it seems. Usually this really should work - it works just fine in several other applications. So the manifest/resource file is not the issue. I'm afraid one of our hacks (maybe the one to achieve debugging privileges on Windows) screws it. It was wrong all the time, just it becomes visual now.
Title: Re: rev 9137 causes C::B to use common controls 6.0.0
Post by: Biplab on June 16, 2013, 02:47:17 pm
Following lines are commented in resource.rc file (see line no 65 onwards).
Code
/*
  #if defined(WX_CPU_AMD64)
    wxMANIFEST_ID RT_MANIFEST "amd64.manifest"
  #elif defined(WX_CPU_IA64)
    wxMANIFEST_ID RT_MANIFEST "ia64.manifest"
  #elif defined(WX_CPU_X86)
    wxMANIFEST_ID RT_MANIFEST "x86.manifest"
  #else
    #warning No platform defined! Unable to embed manifest file.
  #endif
*/

As a result no manifest file is being embedded in codeblocks.exe file.
Title: Re: rev 9137 causes C::B to use common controls 6.0.0
Post by: MortenMacFly on June 16, 2013, 06:03:27 pm
Quote from: Biplab on June 16, 2013, 02:47:17 pm
As a result no manifest file is being embedded in codeblocks.exe file.
Yes, I've seen this meanwhile (I wasn't looking at the resource file in the first place, just at the manifest files). It was commented because it was wrong. I've fixed it properly in SVN head now.