Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: FuzzyWuzzy on April 13, 2013, 01:38:28 am

Title: Incorrect documentation comment highlighting after preprocessor directives
Post by: FuzzyWuzzy on April 13, 2013, 01:38:28 am
Documentation comments of the form /**comment*/ are colored as regular comments if they appear after a preprocessor directive (such as #define, #include, #ifdef, etc.) on the same line. Example:

#define MAX 99 /**Incorrectly colored as regular comment.*/
#include <iostream> /**Incorrectly colored as regular comment.*/
#define MIN 1 ///Correctly colored as documentation comment.
int x; /**Correctly colored as documentation comment.*/
int y; ///Correctly colored as documentation comment.

The same examples work correctly in SciTE 3.0.2-2.
This happens on Code::Blocks build Apr 7 2013, 02:36:35 - wx2.8.12 (Linux, unicode) - 64 bit, version: svn build rev 8948, SDK version: 1.17.0.

Already filed a bug report: https://developer.berlios.de/bugs/?func=detailbug&bug_id=18968&group_id=5358
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: Alpha on May 08, 2013, 09:49:20 pm
(Very late reply, but) it sounds like our Scintilla component is out of date.
@MortenMacFly: do you have time to update it?
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: MortenMacFly on May 09, 2013, 05:41:14 pm
Quote from: Alpha on May 08, 2013, 09:49:20 pm
@MortenMacFly: do you have time to update it?
Maybe today in the evening (I did an update recently already in my local copy) although I am unable to reproduce this particular issue with the SVN revision.
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: Alpha on May 09, 2013, 10:35:17 pm
Quote from: MortenMacFly on May 09, 2013, 05:41:14 pm
[...] although I am unable to reproduce this particular issue with the SVN revision.
It should not work; in our current SVN, the style wxSCI_C_PREPROCESSORCOMMENT is unconditionally applied to any stream comments on the same line as a preprocessor directive.

Paste this into an editor:
Code
#define foo  /** not doc comment */
int bar = 0; /** is doc comment */
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: MortenMacFly on May 12, 2013, 02:27:31 pm
Quote from: Alpha on May 08, 2013, 09:49:20 pm
(Very late reply, but) it sounds like our Scintilla component is out of date.
@MortenMacFly: do you have time to update it?
Done by now.

BUT this is really a massive change as we moved from 3.2.x to 3.3.x. So hopefully it will work under Linux - I did NOT try.

...but this also brings major benefits as scintilla supports folding now natively and we should actually make use of it instead of doing our own fold magic.
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: Alpha on May 13, 2013, 01:16:04 am
Works (so far) under Linux.

Unfortunately, the original report:
Quote from: FuzzyWuzzy on April 13, 2013, 01:38:28 am
The same examples work correctly in SciTE 3.0.2-2.
This happens on Code::Blocks build Apr 7 2013, 02:36:35 - wx2.8.12 (Linux, unicode) - 64 bit, version: svn build rev 8948, SDK version: 1.17.0.
does not seem to have translated into the resolution of this issue.  I have sent a fix to Scintilla (http://sourceforge.net/p/scintilla/feature-requests/990/), and could apply it pre-emptively to our repository, if we want.
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: MortenMacFly on May 13, 2013, 08:45:37 pm
Quote from: Alpha on May 13, 2013, 01:16:04 am
does not seem to have translated into the resolution of this issue.  I have sent a fix to Scintilla (http://sourceforge.net/p/scintilla/feature-requests/990/), and could apply it pre-emptively to our repository, if we want.
If you encapsulate it into our "C::B patch wrappers", go ahead.
Title: Re: Incorrect documentation comment highlighting after preprocessor directives
Post by: MortenMacFly on May 16, 2013, 09:32:59 am
Quote from: Alpha on May 13, 2013, 01:16:04 am
does not seem to have translated into the resolution of this issue.  I have sent a fix to Scintilla (http://sourceforge.net/p/scintilla/feature-requests/990/), and could apply it pre-emptively to our repository, if we want.
It is now it seems, at lats in HG.

So I'll do another update once scintilla 3.3.2 is released... stay tuned  - no need for you to wrap the stuff.