Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: ollydbg on March 01, 2013, 03:21:35 am

Title: Start Here page looks ugly with blue background in rev8888
Post by: ollydbg on March 01, 2013, 03:21:35 am
See the image below:

(http://i.imgur.com/m3CCh26.png)

I see no options to change the background color in Settings->Environment Settings->Colors.
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: Jenna on March 01, 2013, 06:27:40 am
I already have icons with partly transparent background here (I also stumbled over this issue) and as far as I know, you can change the text-color somewhere in the settings (if I remember correctly, it is a new entry under "Settings -> Environment").
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: ollydbg on March 01, 2013, 06:36:38 am
I already have icons with partly transparent background here (I also stumbled over this issue) and as far as I know, you can change the text-color somewhere in the settings (if I remember correctly, it is a new entry under "Settings -> Environment").
There are options for text colors in start here page, but not background color. :)  In my case, white background color is good. :)
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: Jenna on March 01, 2013, 08:04:45 am
I already have icons with partly transparent background here (I also stumbled over this issue) and as far as I know, you can change the text-color somewhere in the settings (if I remember correctly, it is a new entry under "Settings -> Environment").
There are options for text colors in start here page, but not background color. :)  In my case, white background color is good. :)
Sorry I overread the last sentence in your first post.

I already noticed this and I am not really happy with the changes also.
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: oBFusCATed on March 01, 2013, 11:53:08 am
I already noticed this and I am not really happy with the changes also.
You'll get used to it  ;D

It seems that I've used the wrong system colour for the background.
Can you please test to replace the colour id, here:
Code
wxColour bgColour = wxSystemSettings::GetColour(wxSYS_COLOUR_BACKGROUND);
With wxSYS_COLOUR_APPWORKSPACE or wxSYS_COLOUR_WINDOW ?
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: MortenMacFly on March 01, 2013, 12:07:38 pm
See the image below:
Ah - that's where it comes from. I noticed this one as of today, too - for me its a grey background and looks even more uglier. :-) Luckily its just the start page which is opened for only a few seconds, usually.
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: Jenna on March 01, 2013, 12:49:43 pm
With wxSYS_COLOUR_APPWORKSPACE or wxSYS_COLOUR_WINDOW ?
I prefer wxSYS_COLOUR_WINDOW (only tested on linux).

Another weird thing:
I can change the colour to any non-default vaue and it gets saved on close, but if I try to revert back to default it is not saved.
Changing the caret's colour only has an effect if I close and reopen C::B or the editor, or if I open the editorsettings dialog an close it.
The caret colour setting is still possible via "Settings -> Editor -> Margins and caret", so it can be changed in two different places what can confuse the user.

If resetting the default is done by just not setting it, the old value must explicitely be deleted in the conf-file or it will remain.
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: oBFusCATed on March 01, 2013, 12:54:57 pm
I prefer wxSYS_COLOUR_WINDOW (only tested on linux).
Anyone tried it on windows?

Another weird thing:
I can change the colour to any non-default vaue and it gets saved on close, but if I try to revert back to default it is not saved.
Hm, I'll have to test again, because I think I've tried it and it worked.

Changing the caret's colour only has an effect if I close and reopen C::B or the editor, or if I open the editorsettings dialog an close it.
Known issue, suggestions?

The caret colour setting is still possible via "Settings -> Editor -> Margins and caret", so it can be changed in two different places what can confuse the user.
I've removed only color options added after 12.11. I think this will be easier in the longer run.

If resetting the default is done by just not setting it, the old value must explicitely be deleted in the conf-file or it will remain.
I'll look at it tonight...
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: ollydbg on March 01, 2013, 03:46:46 pm
I prefer wxSYS_COLOUR_WINDOW (only tested on linux).
Anyone tried it on windows?
I have tried it now, using wxSYS_COLOUR_WINDOW ---> In my case, the start here page's background turn back to white.  :)
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: oBFusCATed on March 01, 2013, 05:00:01 pm
Okay then wxSYS_COLOUR_WINDOW shall be...
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: Miguel Gimenez on March 01, 2013, 08:43:51 pm
I've extended tpetrov changes to allow selecting also the background colour. If you are interested, the patch is in the Patch Tracker.
Title: Re: Start Here page looks ugly with blue background in rev8888
Post by: oBFusCATed on March 01, 2013, 10:22:04 pm
I've extended tpetrov changes to allow selecting also the background colour. If you are interested, the patch is in the Patch Tracker.
Unfortunately there is no easy way I can think of providing the reset to default option.
If there is a desire we can add all colours, but at least on linux there is no point.
The idea of the colour manager is to allow the user to make the colours match, be visible, be readable on the default background.
I've not implemented a theme system inside C::B, this is a job of wxwidgets/gui toolkit available in the OS/distro.