virtual bool BuildToolBar(wxToolBar* /* toolBar */) {}
virtual bool BuildToolBar(wxToolBar* /* toolBar */) { return false; }
Not really a problem though... I just thought it would be nice to report and get rid of the warnings... ;-)In fact it is really a problem, because now this function returns random stuff :)
The way I see it, it should be:I had spotted this, too alreaedy - just was too lazy, to commit.Codevirtual bool BuildToolBar(wxToolBar* /* toolBar */) { return false; }
thomas: Please put -Werror=no-return in you advanced warning options, it catches such errors without a miss :)Good point. Why don't we enforce a certain set of warnings to all project files? Whcih would be most wise?
thomas: Please put -Werror=no-return in you advanced warning options, it catches such errors without a miss :)Good point. Why don't we enforce a certain set of warnings to all project files? Whcih would be most wise?
-Werror=no-returnGood point, will do.
Good point. Why don't we enforce a certain set of warnings to all project files? Whcih would be most wise?Because gcc-4.1.2 doesn't support this one (for my home computer I have it enabled for all projects :) )
or we write some scripts for CB (put them in svn and have the cbp file use them, detecting the gcc version, and when high enough enable it. I remember we have done this before fpr something (I thin kI even did it, but can't remember) ...Good point. Why don't we enforce a certain set of warnings to all project files? Whcih would be most wise?Because gcc-4.1.2 doesn't support this one (for my home computer I have it enabled for all projects :) )
And because we won't agree on the list of warnings to enable. :)
I remember we have done this before fpr something (I thin kI even did it, but can't remember) ...It was for the PCH stuff, or some warnings - I recall, too. It should still be in SVN somewhere or it has been merged to the project file as script.
http://svn.berlios.de/wsvn/codeblocks/trunk/src/cbgcc420.script?peg=6000 (http://svn.berlios.de/wsvn/codeblocks/trunk/src/cbgcc420.script?peg=6000)I remember we have done this before fpr something (I thin kI even did it, but can't remember) ...It was for the PCH stuff, or some warnings - I recall, too. It should still be in SVN somewhere or it has been merged to the project file as script.
http://svn.berlios.de/wsvn/codeblocks/trunk/src/cbgcc420.script?peg=6000 (http://svn.berlios.de/wsvn/codeblocks/trunk/src/cbgcc420.script?peg=6000)Exactly! And that's how we can do it properly, too btw. I didn't know it was a warning in the end, too...