Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: tiwag on December 16, 2005, 09:25:07 pm

Title: svn rev 1534 - global variable expansion broken
Post by: tiwag on December 16, 2005, 09:25:07 pm

don't use SVN ver 1534 for a build !!!!!!


@thomas
$(#WX.lib)
expands to
-Iib)
 :shock:

instead of
<WX>\lib
as it should be
 :) :) :)

Title: Re: svn rev 1534 - global variable expansion broken
Post by: thomas on December 16, 2005, 09:32:30 pm

Darn, I have to go out in 10 mins...
Let me compile quickly and look...

Title: Re: svn rev 1534 - global variable expansion broken
Post by: tiwag on December 16, 2005, 09:35:48 pm

Quote from: thomas on December 16, 2005, 09:32:30 pm

Darn, I have to go out in 10 mins...
Let me compile quickly and look...

don't hurry, such **** happens ...
(from time to time, not always of course)  8)

EDIT: Censored by Rick :)

Title: Re: svn rev 1534 - global variable expansion broken
Post by: thomas on December 16, 2005, 09:41:07 pm

Hmm I see what you mean now... -Include) -Iib)\gcc_dll\msw -Iib)\gcc_dllNonUnicode\msw

Will fix that as soon as I'm back, maybe 2-3 hours :?

Title: Re: svn rev 1534 - global variable expansion broken
Post by: rickg22 on December 16, 2005, 10:26:54 pm

Don't forget to make a regression test so the last bug you fixed doesn't come back :)

Title: Re: svn rev 1534 - global variable expansion broken
Post by: thomas on December 17, 2005, 02:52:13 am

Ok, I guess I fixed it. Don't ask what I did though... I only exchanged a few lines, added logging, streamlined the regex a bit, and then it worked. Must have been a trifle...

I ran a test project with a dozen different variables in various formats a couple of times and compiled Code::Blocks 1535 with itself without any warnings, so I guess it works :)

Title: Re: svn rev 1534 - global variable expansion broken
Post by: 280Z28 on December 17, 2005, 03:05:44 am

Quote from: thomas on December 17, 2005, 02:52:13 am

Ok, I guess I fixed it. Don't ask what I did though... I only exchanged a few lines, added logging, streamlined the regex a bit, and then it worked. Must have been a trifle...

I ran a test project with a dozen different variables in various formats a couple of times and compiled Code::Blocks 1535 with itself without any warnings, so I guess it works :)

Working fine here too. I had gone back to 1533 on that one file for a while; this is better. :)

Title: Re: svn rev 1534 - global variable expansion broken
Post by: 280Z28 on December 17, 2005, 03:09:55 am

Is it supposed to apply changes to global variables immediately, or only after a restart?