Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Plugins development => Topic started by: stahta01 on April 14, 2023, 03:07:56 pm

Title: GitBlocks to keep most of it working under Windows 10
Post by: stahta01 on April 14, 2023, 03:07:56 pm

https://github.com/stahta01/GitBlocks (https://github.com/stahta01/GitBlocks)

It builds and show status menu option works. Most of the other options have at least been partly tested.

If no project is open than using this plugin currently crashes the CB IDE.

Tim S.

Title: Re: GitBlocks work to get it working under Windows 10
Post by: stahta01 on April 15, 2023, 08:12:25 pm

Several commands were fixed for crashing if no projects are open
Edit Fixed attach and release in git repo; not yet done a release.
Edit2: Did an release
.
Tim S.

Title: Re: GitBlocks to keep most of it working under Windows 10
Post by: christo on September 15, 2023, 06:04:23 pm

Hi Tim,

I tested the plugin in Linux wx3.0, it works fine. I've created pull request https://github.com/stahta01/GitBlocks/pull/1 with project file. Could you please check?

Thanks,
Christo

Title: Re: GitBlocks to keep most of it working under Windows 10
Post by: stahta01 on September 15, 2023, 09:28:09 pm

Quote from: christo on September 15, 2023, 06:04:23 pm

Hi Tim,

I tested the plugin in Linux wx3.0, it works fine. I've created pull request https://github.com/stahta01/GitBlocks/pull/1 with project file. Could you please check?

Thanks,
Christo

This is the first time for me to process an PR; I think I did it right.

Tim S

Title: Re: GitBlocks to keep most of it working under Windows 10
Post by: sodev on September 15, 2023, 09:49:11 pm

Uhm, well... not really :P.

The history looks like you cherry-picked the commit, that was the worst option (does the GitHub UI even offer that option?). In general you perform a merge, for external contributions i prefer to always enforce a merge, even if like in this case a fast-forward merge would have been possible.

Also, it is kind of bad practice to create a PR from the main branch, in general you make a feature branch and create a PR from that one.

Title: Re: GitBlocks to keep most of it working under Windows 10
Post by: stahta01 on September 15, 2023, 11:18:49 pm

Quote from: sodev on September 15, 2023, 09:49:11 pm

Uhm, well... not really :P.

The history looks like you cherry-picked the commit, that was the worst option (does the GitHub UI even offer that option?). In general you perform a merge, for external contributions i prefer to always enforce a merge, even if like in this case a fast-forward merge would have been possible.

Also, it is kind of bad practice to create a PR from the main branch, in general you make a feature branch and create a PR from that one.

Thanks for the feedback; I will do it manually next time; I dislike git merges.

So, next time I will do a manual commit and see if it works better or it works worse.

Tim S.

Title: Re: GitBlocks to keep most of it working under Windows 10
Post by: Wkerry on December 25, 2023, 04:29:10 am

BOT, where is the repo.