Code::Blocks Forums

User forums => Help => Topic started by: lfm on May 24, 2006, 07:26:43 am

Title: About background colour of symbols window
Post by: lfm on May 24, 2006, 07:26:43 am
The background colour of symbols window is not good-look. can i change ?


[attachment deleted by admin]
Title: Re: About background colour of symbols window
Post by: sethjackson on May 24, 2006, 01:57:35 pm
Quote from: lfm on May 24, 2006, 07:26:43 am
The background colour of symbols window is not good-look. can i change ?


It is not in any C::B setting. However you can modify the code to "fix" it (it looks ugly on windows)....
The reason is eranif in one of his wxFNB release changed the background color on Windows.

Fourth post from the bottom......

http://wxforum.shadonet.com/viewtopic.php?t=5761&postdays=0&postorder=asc&start=90
Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 02:12:40 pm
This has been fixed *long* ago...
Title: Re: About background colour of symbols window
Post by: tiwag on May 24, 2006, 02:49:48 pm
Quote from: mandrav on May 24, 2006, 02:12:40 pm
This has been fixed *long* ago...

sorry, that screeny is from svn rev 2498

(http://img118.imageshack.us/img118/3382/cbsymbolsbg1oy.th.png) (http://img118.imageshack.us/my.php?image=cbsymbolsbg1oy.png)

it really doesn't look fixed  :P

WinXP, wxWidgets 2.6.3 unicode
Title: Re: About background colour of symbols window
Post by: takeshimiya on May 24, 2006, 02:55:10 pm
Quote from: tiwag on May 24, 2006, 02:49:48 pm
it really doesn't look fixed  :P
I can confirm that. :P

A wxPanel there shouldn't solve it?

@tiwag: that cyan background doesn't hurt your eyes? :o
Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 02:55:42 pm
You might want to run update.bat (windows) or "sh update" (linux, build using C::B).
If you 're using linux/autotools, run the following:
Code
make clean-zipfiles
make
make install


[attachment deleted by admin]
Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 02:57:19 pm
Quote from: Takeshi Miya on May 24, 2006, 02:55:10 pm
A wxPanel there shouldn't solve it?

Look in src/plugins/codecompletion/resources/classbrowser.xrc.
Surprise! It uses a wxPanel :)
Title: Re: About background colour of symbols window
Post by: tiwag on May 24, 2006, 03:02:22 pm
Quote from: mandrav on May 24, 2006, 02:55:42 pm
You might want to run update.bat (windows) ...
done, but without success
Title: Re: About background colour of symbols window
Post by: tiwag on May 24, 2006, 03:04:21 pm
Quote from: Takeshi Miya on May 24, 2006, 02:55:10 pm
@tiwag: that cyan background doesn't hurt your eyes? :o
it doesn't as hurt as certain questions in this forum here ...
Title: Re: About background colour of symbols window
Post by: sethjackson on May 24, 2006, 03:05:18 pm
Hey everyone this happens on Windows only. See my post above. :D
Title: Re: About background colour of symbols window
Post by: thomas on May 24, 2006, 03:06:18 pm
Quote from: tiwag on May 24, 2006, 03:04:21 pm
Quote from: Takeshi Miya on May 24, 2006, 02:55:10 pm
@tiwag: that cyan background doesn't hurt your eyes? :o
it doesn't as hurt as certain questions in this forum here ...
I believe the background in SciTE is not cyan... :)

EDIT: And looking closely, the above isn't either :)
Title: Re: About background colour of symbols window
Post by: Defender on May 24, 2006, 03:07:32 pm
Yes, I can confirm this too.
Windows XP SP2
wxWidgets 2.6.3 patch2
Code::Blocks 2490 Full rebuild
But it doesn't hurt me...
Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 03:12:59 pm
Well, did anyone have a look at src/plugins/codecompletion/resources/classbrowser.xrc???
Title: Re: About background colour of symbols window
Post by: sethjackson on May 24, 2006, 03:22:44 pm
Quote from: mandrav on May 24, 2006, 03:12:59 pm
Well, did anyone have a look at src/plugins/codecompletion/resources/classbrowser.xrc???

Yes, but the real problem is wxFNB (http://forums.codeblocks.org/index.php?topic=2252.0). I have rev 2498. I ran update.bat same "problem" described above.....
Title: Re: About background colour of symbols window
Post by: tiwag on May 24, 2006, 03:23:54 pm
Quote from: mandrav on May 24, 2006, 03:12:59 pm
Well, did anyone have a look at src/plugins/codecompletion/resources/classbrowser.xrc???

when i test this with XRCed it looks ok, all bg and fg colours are set to default, also the
CodeBlocks\share\CodeBlocks\code_completion.zip
contains the right classbrowser.xrc file,
i don't know why this happens, but it is not related to an outdated classbrowser.xrc file.
Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 03:28:38 pm
Quote from: sethjackson on May 24, 2006, 03:22:44 pm
Yes, but the real problem is wxFNB (http://forums.codeblocks.org/index.php?topic=2252.0).

Yes, wxFNB was responsible back when we didn't use a panel for those comboboxes above the symbols browser.
But it isn't responsible anymore. It can't be. There's a wxPanel there. I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...
Title: Re: About background colour of symbols window
Post by: sethjackson on May 24, 2006, 03:29:45 pm
This is how to "fix" (I'm not saying this code should go in SVN trunk just proving my point....).

Code: diff
Index: src/sdk/wxFlatNotebook/wxFlatNotebook.cpp
===================================================================
--- src/sdk/wxFlatNotebook/wxFlatNotebook.cpp	(revision 2498)
+++ src/sdk/wxFlatNotebook/wxFlatNotebook.cpp	(working copy)
@@ -488,7 +488,7 @@
 	m_mainSizer = new wxBoxSizer(wxVERTICAL);
 	SetSizer(m_mainSizer);
 
-	SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE));
+	SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_3DLIGHT));
 
 	// Add the tab container to the sizer
 	m_mainSizer->Insert(0, m_pages, 0, wxEXPAND);


(http://img78.imageshack.us/img78/167/untitled8nu.png) (http://imageshack.us)
Title: Re: About background colour of symbols window
Post by: sethjackson on May 24, 2006, 03:30:52 pm
Quote from: mandrav on May 24, 2006, 03:28:38 pm
Quote from: sethjackson on May 24, 2006, 03:22:44 pm
Yes, but the real problem is wxFNB (http://forums.codeblocks.org/index.php?topic=2252.0).

Yes, wxFNB was responsible back when we didn't use a panel for those comboboxes above the symbols browser.
But it isn't responsible anymore. It can't be. There's a wxPanel there. I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...

mandrav see my post above. This only happens on Windows. The reason is wxSYS_COLOUR_APPWORKSPACE is a different color on Windows than on *nix. :D
Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 03:32:05 pm
OK, I think I see why this happens. Give me a few minutes...
Title: Re: About background colour of symbols window
Post by: tiwag on May 24, 2006, 03:32:12 pm
Quote from: mandrav on May 24, 2006, 03:28:38 pm
... I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...
it doesn't have the heart to misbehave at the boss's computer ... :D
Title: Re: About background colour of symbols window
Post by: sethjackson on May 24, 2006, 03:33:13 pm
Quote from: tiwag on May 24, 2006, 03:32:12 pm
Quote from: mandrav on May 24, 2006, 03:28:38 pm
... I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...
it doesn't have the heart to misbehave at the boss's computer ... :D

 :lol:

Title: Re: About background colour of symbols window
Post by: mandrav on May 24, 2006, 03:46:34 pm
First of all, the fix has been committed.

OK, here's what happens.
You 're using the symbols browser docked inside the project manager's notebook, while I 'm using it as a free floating window. When I docked it here too, I saw the problem.
It still doesn't make sense why this happens. There's a panel there. It should paint itself. Period. But it doesn't...
Anyway, as I said, I committed the fix so enough about this :)
Title: Re: About background colour of symbols window
Post by: takeshimiya on May 24, 2006, 04:24:43 pm
Quote from: mandrav on May 24, 2006, 03:46:34 pm
It still doesn't make sense why this happens. There's a panel there. It should paint itself. Period. But it doesn't...

Strange things happens. :P