Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Plugins development => Topic started by: Bug Killer on February 02, 2023, 12:49:47 pm

Title: wxSmith non i18N strings with international characters are not correctly managed
Post by: Bug Killer on February 02, 2023, 12:49:47 pm

In nightly build 13186
In wxSmith/wxscodinglang.cpp
In wxString WxString(wxsCodingLang Lang, const wxString& Source, bool WithTranslation)

strings with international characters are not considered alphabetic. So, string prefix is always _( whichever is the prefix chosen in wxSmith settings for non i18N strings.

To fix comment out :

                if (DoTranslation)
                {
                    // Check if translation is really needed. For now, just check if it contains alphabetic chars
                    if (std::any_of(Source.begin(), Source.end(), [] (wxUniChar c) {return wxIsalpha(c);}))
                    {
                        Prefix = "_(";
                        Postfix = ")";
                    }
                }

Title: Re: wxSmith non i18N strings with international characters are not correctly managed
Post by: Miguel Gimenez on February 02, 2023, 01:38:01 pm

Strings with international characters ARE alphabetic (wxIsalpha() returns true for them).
If you comment out that code no string from wxSmith will be translatable.

If this bothers you then disable global I18n support in wxSmith settings or disable local I18n support in the affected wxSmith window.

Title: Re: wxSmith non i18N strings with international characters are not correctly managed
Post by: Bug Killer on February 02, 2023, 07:17:27 pm

Thanks for the explanation. C::B 20.03 behaviour was different.

Is there a way to disable internationalization for all dialog, panels and frame ?

Why strings with international characters are not displayed when the prefix is _( ?

Title: Re: wxSmith non i18N strings with international characters are not correctly managed
Post by: Miguel Gimenez on February 02, 2023, 07:53:22 pm

Quote

Is there a way to disable internationalization for all dialog, panels and frame ?

As said before, disable global I18n support in wxSmith settings or disable local I18n support in the affected wxSmith window.

Quote

Why strings with international characters are not displayed when the prefix is _( ?

I do not know, probably wxWidgets' GetTranslatedString() does not accept non-ASCII strings.

Title: Re: wxSmith non i18N strings with international characters are not correctly managed
Post by: sodev on February 02, 2023, 09:10:18 pm

GetTranslatedString() works with any narrow string, it does not work with wide strings, but in case of error it simply returns the input value and not empty string.

On windows, two reasons come into my mind, but both apply to narrow strings, so not only the _() macro would be affected. Either the compiler uses a wrong encoding to read the source file and interprets the strings as garbage or the execution charset of the application cannot represent the characters. wxWidgets always assumes narrow strings use the execution charset and converts them to its internal unicode representation, if that fails, it produces an empty string.

Title: Re: wxSmith non i18N strings with international characters are not correctly managed
Post by: Bug Killer on February 02, 2023, 09:39:26 pm

Whichever is the value of the global i18N settings prefix is always _( because of a mistake in wxscodinglang.cpp.

Line : const bool DoTranslation = WithTranslation && (cfg->ReadBool("/useI18N"), true);

Should be : const bool DoTranslation = WithTranslation && cfg->ReadBool("/useI18N", true);

Now everything goes well.

Title: Re: wxSmith non i18N strings with international characters are not correctly managed
Post by: Miguel Gimenez on February 03, 2023, 09:31:06 am

Fixed in trunk, thank you.