Recent Posts

11

CodeCompletion redesign / Re: use PPToken for preprocessor in native CC

« Last post by blauzahn on September 18, 2024, 04:49:27 pm »

btw: Have you tried to use the gcc/clang sanitizer? It should be able to spot the ub.

12

CodeCompletion redesign / Re: use PPToken for preprocessor in native CC

« Last post by blauzahn on September 18, 2024, 04:47:04 pm »

No, I mean this:

Code

if (IsEOF())
        {
            m_Lex = wxEmptyString;
            m_Lex.m_Lexeme = wxEmptyString;
            m_Lex.m_Kind = PPTokenKind::EndOfFile;

I haven't looked into the context but setting several data-member usually is none of the caller's business. In addition to that, the data-member m_Lexeme was unnecessarily set twice, once through the implicit operator, once directly. Although I mostly avoid setter, a primitive one here may be like:

Code

class PToken
{
  // ...
  void setEof()
  {
  	m_Lexeme = wxEmptyString;  	
  	m_Kind = PPTokenKind::EndOfFile;
  }
  // ...
};

if (IsEOF())
{
	m_Lex.setEof();
	return false;
}

It's PToken's responsability to decide what to do with its data-members when tagged as eof. Granted, they are public anyway, so it can not maintain an invariant anyway.
 

13

Using Code::Blocks / Re: Update of documentation CB on Windows

« Last post by ThierryD on September 18, 2024, 03:55:42 pm »

Hi,

I think to have finish to include preconisations suggered by "Ollydbg" into all documents MD and PDF available on my site GitHub
   justify text,
   add new paragraphs,
   add newline or suppress it if necessary to ameliore lisibility,
   add bullet list,
   mark source code with balise "Code" of MD.

But on the found of these contents, nothing remarks ?
 
Thank's.

Thierry D.

14

General (but related to Code::Blocks) / Re: Welcome Newcomers - PLEASE READ!!!

« Last post by imtiaz_munna on September 18, 2024, 11:11:10 am »

 "I am new, I am here"

15

Using Code::Blocks / Re: Project dependent upon another project?

« Last post by Miguel Gimenez on September 18, 2024, 11:08:21 am »

Future spam added to radar.

16

Using Code::Blocks / Re: Project dependent upon another project?

« Last post by Trasatorn on September 18, 2024, 11:03:05 am »

Projects can depend on other projects

17

CodeCompletion redesign / Re: use PPToken for preprocessor in native CC

« Last post by ollydbg on September 18, 2024, 10:28:52 am »

I very briefly glanced across the commit pointed to by the link.

findings:

Thanks for the comment.

class PToken: data-member m_Kind is left uninitialized when PToken is default initialized and when initialized via the ctor with 4 args (while having 5 data-member).
  The call to the latter one is also a little errorprone. It might easily be used incorrectly because it has 3 int args. I'd consider member-initializer for the 4 integral data
  member and delete the default-ctor.

Oh, yes, I should initialize the m_Kind member variable in the default constructor and other constructors.
About the argument: "PPToken(wxString lexeme, int charIndex, int lineIndex, int nestLevel)", I really don't know where does the "charIndex" come from, I will looked into it.

The cctor of PToken is unecessary and breaks the rule-of-0 without need. It might also copy m_Kind from
  an uninitialized data-member. That is undefined behaviour. IMHO the cctor should be removed.

My initial though is that PPToken's copy constructor is used because I think it need to construct the element in the deque, in some cases, the PPToken get copied to the deque. Am I wrong?

Oh, you are correct,

In C++, the "Rule of Zero" is a guideline that suggests avoiding writing custom constructors, destructors, or copy/move assignment operators if the default compiler-generated versions will suffice. The rule states that if a class does not need custom resource management (like dynamic memory allocation), it can rely on the compiler-generated special member functions.

So, the copy constructor is not needed here, because the compiler will generate the same one if I remove it.

The compound statement after  if (IsEOF()) is repeated. It sets 2 data-members of PToken and should be delegated to PToken.

Do you mean that the

Code

    /** Check whether the Tokenizer reaches the end of the buffer (file) */
    bool IsEOF() const
    {
        return m_TokenIndex >= m_BufferLen;
    }

should be removed from the high level parser, but we can return a PPToken which has m_Kind field set as "EOF"?

Thanks.

18

CodeCompletion redesign / Re: use PPToken for preprocessor in native CC

« Last post by blauzahn on September 18, 2024, 09:08:10 am »

I very briefly glanced across the commit pointed to by the link.

findings:

• class PToken: data-member m_Kind is left uninitialized when PToken is default initialized and when initialized via the ctor with 4 args (while having 5 data-member).
    The call to the latter one is also a little errorprone. It might easily be used incorrectly because it has 3 int args. I'd consider member-initializer for the 4 integral data
    member and delete the default-ctor.
• The cctor of PToken is unecessary and breaks the rule-of-0 without need. It might also copy m_Kind from
    an uninitialized data-member. That is undefined behaviour. IMHO the cctor should be removed.
• The compound statement after  if (IsEOF()) is repeated. It sets 2 data-members of PToken and should be delegated to PToken.

Cheers

19

CodeCompletion redesign / Re: use PPToken for preprocessor in native CC

« Last post by ollydbg on September 18, 2024, 12:10:55 am »

I have been looking at this commit (the exact location of the changes was not specified).

PPToken looks to me just a way to pack token information, so I assume the real benefit is using the deque afterwards.

Thanks for the comment.

The "deque" here is used to move the token cursor forward or backward, because we have some interface to "peek token" (look ahead) or "undo token"(move the cursor backward), so I think a "deque" is a good structure to use.

I just suggest changing

Code

if (m_PPTokenStream.size() > 0)

to this

Code

if (!m_PPTokenStream.empty())

Thanks, but what's the difference? Maybe the "empty()" function runs much faster?

and removing this part

Code

    else
        ;// peekToken.Clear();

I will read this part of the code later.

Thanks.

20

CodeCompletion redesign / Re: use PPToken for preprocessor in native CC

« Last post by Miguel Gimenez on September 17, 2024, 05:58:45 pm »

I have been looking at this commit (the exact location of the changes was not specified).

PPToken looks to me just a way to pack token information, so I assume the real benefit is using the deque afterwards.

I just suggest changing

Code

if (m_PPTokenStream.size() > 0)

to this

Code

if (!m_PPTokenStream.empty())

and removing this part

Code

    else
        ;// peekToken.Clear();