- http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3503&group_id=5358 (http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3503&group_id=5358)
The changes to scintilla code will likely need submitted upstream to them for the changes to be put into CB.
IIRC, Morton updates the scintilla code from time to time from the upstream.
Edit3: I noticed these in the scintilla code section; so if doing non upstream changes it might help you get the patch applied.
/* C::B begin */
/* C::B end */
I also suggest looking at the Category options when submitting patches.
If you think some are really bugs; please submit a bug report on them linking to the patch.
NOTE: I am NOT a CB dev; so, all I am saying are suggestions; not required. I gave up doing patches and stuff due to the work it took to keep them updated for CB trunk. But, yours are shorter; maybe my problem was patching to much in a single patch.
Tim S.
The changes to scintilla code will likely need submitted upstream to them for the changes to be put into CB.
I submitted a report to https://sourceforge.net/p/scintilla/bugs/1531/ (https://sourceforge.net/p/scintilla/bugs/1531/), but it was declined, saying that sources which use the CallTip.h should include <string>. (Honestly this seems a bit weird, in particular if the code that needs to include that header doesn't do anything with strings at all, it just needs the header to prevent a compile error.)
And wxScintilla seems pretty abandoned to me. At least I have no clue where to submit any bug reports. I saw that wxWidgets patches the code (see https://github.com/wxWidgets/wxWidgets/blob/master/src/stc/ScintillaWX.cpp (https://github.com/wxWidgets/wxWidgets/blob/master/src/stc/ScintillaWX.cpp)) by adding the following to ScintillaWX.cpp:
#if !wxUSE_STD_CONTAINERS && !wxUSE_STD_IOSTREAM && !wxUSE_STD_STRING
#include "wx/beforestd.h"
#include <string>
#include "wx/afterstd.h"
#endif
Patch for alert when checking "Settings" -> "Environment"
Cause was SetSettingsIconsStyle in CB globals.cpp. (Code causing alert was Windows ONLY code.)
I have NOT tested patch under wxWidgets 2.8; only tested using wxWidgets truck (wx 3.0.0).
Edit: I have now tested the patch with wxWidgets 2.8 branch and it worked under Windows 7 32bit.
I also needed to patch CB file environmentsettingsdlg.cpp because loading the icons makes it default to displaying icons using wxWidgets truck (wx 3.0.0)
Tim S.
Index: src/sdk/globals.cpp
===================================================================
--- src/sdk/globals.cpp (revision 9381)
+++ src/sdk/globals.cpp (working copy)
@@ -1020,8 +1020,8 @@
long flags = lc->GetWindowStyleFlag();
switch (style)
{
- case sisNoIcons: flags = (flags & ~wxLC_ICON) | wxLC_SMALL_ICON; break;
- default: flags = (flags & ~wxLC_SMALL_ICON) | wxLC_ICON; break;
+ case sisNoIcons: flags = (flags & ~wxLC_MASK_TYPE) | wxLC_LIST; break;
+ default: flags = (flags & ~wxLC_MASK_TYPE) | wxLC_ICON; break;
}
lc->SetWindowStyleFlag(flags);
#endif
@@ -1032,7 +1032,7 @@
// this doesn't work under wxGTK...
#ifdef __WXMSW__
long flags = lc->GetWindowStyleFlag();
- if (flags & wxLC_SMALL_ICON)
+ if (flags & wxLC_LIST)
return sisNoIcons;
#endif
return sisLargeIcons;
Index: src/src/environmentsettingsdlg.cpp
===================================================================
--- src/src/environmentsettingsdlg.cpp (revision 9381)
+++ src/src/environmentsettingsdlg.cpp (working copy)
@@ -107,8 +109,8 @@
wxXmlResource::Get()->LoadObject(this, parent, _T("dlgEnvironmentSettings"),_T("wxScrollingDialog"));
int sel = cfg->ReadInt(_T("/environment/settings_size"), 0);
wxListbook* lb = XRCCTRL(*this, "nbMain", wxListbook);
+ LoadListbookImages();
SetSettingsIconsStyle(lb->GetListView(), (SettingsIconsStyle)sel);
- LoadListbookImages();
Connect(XRCID("nbMain"),wxEVT_COMMAND_LISTBOOK_PAGE_CHANGING,wxListbookEventHandler(EnvironmentSettingsDlg::OnPageChanging));
Connect(XRCID("nbMain"),wxEVT_COMMAND_LISTBOOK_PAGE_CHANGED, wxListbookEventHandler(EnvironmentSettingsDlg::OnPageChanged ));
Argh.... Running codeblocks-wx29 from within codeblocks makes debugging a simple console application with the second C::B impossible.
The debugger doesn't stop on breakpoints and prints this annoying message:
During startup program exited with code 1
Anyone experiencing such issues?
Running codeblocks-wx28 works as expected...