Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: earlgrey on December 08, 2010, 07:01:47 am

Title: Request : C::B View::notebook enhancements
Post by: earlgrey on December 08, 2010, 07:01:47 am
Hello to all,

Can you, (dear) C::B developpers, implement the possibility :

1) To put editor notebook tabs on the left ? ( wxNB_LEFT ? )
With nowadays wide screens, it is cool to have a vertical list of open files, so you dont have to click on little "<" and ">" arrows.

2) To put only the name of the file ( without any path info ) in notebook tabs ? Im getting huge tabs, and even on 16:9 screen, I only can display a few.

Thank you for reading
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 08, 2010, 07:28:43 am
1) I will look into it,
2) "Settings -> Editor... -> General settings -> [Other settings ->] Editor title is the file's -> name only (no path information)"

Whether you have the part in the brackets or not depends on your version of C::B.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 08, 2010, 07:38:16 am
1) I will look into it,

I'm not sure if it is possible, because we use wxAuiNotebook and at least in 2.8.10 (the version we use), it has only wxAUI_NB_BOTTOM na wxAUI_NB_TOP style flags (that's what the documentation says, I will look into it if I am on my working system).
Title: Re: Request : C::B View::notebook enhancements
Post by: earlgrey on December 08, 2010, 08:11:52 am
"Settings -> Editor... -> General settings -> [Other settings ->] Editor title is the file's -> name only (no path information)"

Oh, apologize for this newbee question...and Thanx

================================================================
There is  no wxAUI_NB_LEFT in 2.9.1

http://docs.wxwidgets.org/2.9.1/classwx_aui_notebook.html :

(...)

Styles

This class supports the following styles:

    wxAUI_NB_DEFAULT_STYLE:
    Defined as wxAUI_NB_TOP | wxAUI_NB_TAB_SPLIT | wxAUI_NB_TAB_MOVE | wxAUI_NB_SCROLL_BUTTONS | wxAUI_NB_CLOSE_ON_ACTIVE_TAB.
    wxAUI_NB_TAB_SPLIT:
    Allows the tab control to be split by dragging a tab.
    wxAUI_NB_TAB_MOVE:
    Allows a tab to be moved horizontally by dragging.
    wxAUI_NB_TAB_EXTERNAL_MOVE:
    Allows a tab to be moved to another tab control.
    wxAUI_NB_TAB_FIXED_WIDTH:
    With this style, all tabs have the same width.
    wxAUI_NB_SCROLL_BUTTONS:
    With this style, left and right scroll buttons are displayed.
    wxAUI_NB_WINDOWLIST_BUTTON:
    With this style, a drop-down list of windows is available.
    wxAUI_NB_CLOSE_BUTTON:
    With this style, a close button is available on the tab bar.
    wxAUI_NB_CLOSE_ON_ACTIVE_TAB:
    With this style, the close button is visible on the active tab.
    wxAUI_NB_CLOSE_ON_ALL_TABS:
    With this style, the close button is visible on all tabs.
    wxAUI_NB_TOP:
    With this style, tabs are drawn along the top of the notebook.
    wxAUI_NB_BOTTOM:
    With this style, tabs are drawn along the bottom of the notebook.

(...)

Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 08, 2010, 11:07:09 am
I just looked into the sources (of wxWidgets):
the flags exist in the header-file, but the implemetation is missing in the sources.

So this will not come soon.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 08, 2010, 12:43:21 pm
I've another request:

I want to know the (full) path the edited file, in visual studio there is a tooltip with this info when the mouse is over the tab.
Unfortunately wxAUIToolbar doesn't support tooltips over the tabs, so the only solution is something similar to what Scite does:
http://c0485891.cdn.cloudfiles.rackspacecloud.com/62fe6bcd-7042-4205-a847-a095f83d8a64_3_full.png

How hard would it be to implement such feature?
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 08, 2010, 12:46:52 pm
Seems to be the wrong image.
Okay after your description (in the next post) I see what you mean.
I think it can be done (not absolutely sure about), but in my opinion it's quit ugly.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 08, 2010, 01:05:18 pm
Here is another similar image: http://mondaybynoon.com/images/screenshots/scite-default.jpg
found here: http://mondaybynoon.com/2007/03/12/using-scite-with-textmate-style-snippets/

The thing they do is to add a label/text control between the notebook and the editor
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on December 08, 2010, 02:06:24 pm
I want to know the (full) path the edited file, in visual studio there is a tooltip with this info when the mouse is over the tab.
You can always see this in the properties of the edited file (using right mouse button on the tab)...?!
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 08, 2010, 02:11:25 pm
Morten: I know, but this is a task I do often and I want to save couple of clicks
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 08, 2010, 02:24:08 pm
Since the feature-request season is open... ;-)

On thing I miss is the ability to scroll through the tabs (notebooks) by using the mouse wheel.

I have a little bit looked around, but I'm not a notebook specialist... Any idea if this is possible/difficult??
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on December 08, 2010, 02:41:15 pm
Any idea if this is possible/difficult??
I've a pending patch that implements this applied in my working copy for a couple of month. However, it's untested on Linux.
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 08, 2010, 02:43:50 pm
I've a pending patch that implements this applied in my working copy for a couple of month. However, it's untested on Linux.

I'm working on Windows Vista 32bit and would be glad if you could send me the patch... :-)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 08, 2010, 03:13:33 pm
Post the patch Morten, I'll give it a try on linux  :lol:
Title: Re: Request : C::B View::notebook enhancements [ Tabs scrolling ]
Post by: earlgrey on December 10, 2010, 06:33:26 am
@daniloz :

====================================================
On thing I miss is the ability to scroll through the tabs (notebooks) by using the mouse wheel.
====================================================

I just tried this :

- Left click on a tab, dont release the button
- In the same time, use Left / Right arrow keyboard keys

Better than clicking the little black arrows !
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 10, 2010, 07:29:19 am
@daniloz :

====================================================
On thing I miss is the ability to scroll through the tabs (notebooks) by using the mouse wheel.
====================================================

I just tried this :

- Left click on a tab, dont release the button
- In the same time, use Left / Right arrow keyboard keys

Better than clicking the little black arrows !


I suggest using Ctrl+Tab and Ctrl+Shift+Tab instead, because it also jumps from the last to the first tab if you move righ through the tabs and vice versa.
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 10, 2010, 08:45:40 am
@jens & @earlgrey:

Thank you for the tips. Actually, I already knew Ctrl+Tab and Ctrl+Shift+Tab, but this is slightly different from what I want. By using this shortcuts we actually jump from one tab to the other.

What I wanted is something that I've seen in other editors (maybe notepad++, but I'm not sure here), which is just positioning the mouse into the tab area and using the wheel to make the tabs scroll, with out changing the focus from the actual tab, i.e. without jumping. Then, if wished, I could just click on the tab I want to go to...

[edit]
It also doesn't work on notepad++... so it must have been some other not-opensource software, most probabily Understand (http://www.scitools.com/)
[/edit]

@morten:

Please, please, please, post the patch... :-)
Title: Re: Request : C::B View::notebook enhancements
Post by: earlgrey on December 10, 2010, 09:19:07 am
Sounds like it would cool to have something like this, instead of notebook tabs :
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 10, 2010, 09:41:33 am
earlgrey: Why do you think so? To me it looks like it will waste to much vertical space.

By the way there is the open files plugin, which uses a list control to switch files. It could be useful for someone...
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 10, 2010, 09:50:12 am
earlgrey: Why do you think so? To me it looks like it will waste to much vertical space.

By the way there is the open files plugin, which uses a list control to switch files. It could be useful for someone...

@oBFusCATed:

- I agree, waste of vertical space...
- I already use the Open Files Plugin, just thought the scrolling would be a neat feature, but it doesn't block my workflow... :-)
Title: Re: Request : C::B View::notebook enhancements
Post by: earlgrey on December 10, 2010, 11:58:46 am
@oBFusCATed:
I agree, it was just suggestion for daniloz

@All :
Dragging the file list plugins at the right of the management winfow perfectly emulates the vertical tabs positionning, so for me it is OK
( I only use C::B since a few weeks, so I didnt know the open file plugin. )


Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on December 10, 2010, 09:06:18 pm
Please, please, please, post the patch... :-)
Hey, I just realised it IS already in trunk! See the codesnippet here:

Code
void wxMultiColumnListCtrl::OnMouseEvent(wxMouseEvent& event)
{
    if (event.GetEventType() == wxEVT_MOUSEWHEEL)
    {
...coming from switcherdlg.cpp.

It's not exactly what you are asking for, but IMHO it's even better as you see all tabs in addition. Did you try this already?!
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 11, 2010, 08:46:03 am
Just for the record, since yesterday evening, I have a working patch for having a tooltip when hovering over the tabs of cbAuiNotebook (our class used for the notebooks, derived from wxAuiNotebook).
It's not (yet) tested on windows.
After some code-cleaning (mostly removing debug-statements), I will attach it here, so it can be tested by more users.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 11, 2010, 10:47:23 am
Jens: great news, me wonna test  :lol:
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 11, 2010, 07:08:24 pm
Jens: great news, me wonna test  :lol:

Here comes the patch, tested on debian 64-bit and on win7.

EDIT:
Patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg93167.html#msg93167 (http://forums.codeblocks.org/index.php/topic,13826.msg93167.html#msg93167)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 11, 2010, 11:53:57 pm
Found first bug: the tooltips show even if I'm on another virtual desktop. Happens with Enlightenment dr 17. I don't know it can happen with gnome/kde.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 12, 2010, 12:26:05 am
Found first bug: the tooltips show even if I'm on another virtual desktop. Happens with Enlightenment dr 17. I don't know it can happen with gnome/kde.
Should be fixed with this (updated) patch.

Edit:

Patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg93178.html#msg93178 (http://forums.codeblocks.org/index.php/topic,13826.msg93178.html#msg93178)
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on December 12, 2010, 09:14:42 am
Should be fixed with this (updated) patch.
...looks good to me! :-)

Just one minor note: The destructor should be virtual to avoid warnings... unless you have an implicit reason not to do so.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 12, 2010, 10:50:10 am
Should be fixed with this (updated) patch.
...looks good to me! :-)

Just one minor note: The destructor should be virtual to avoid warnings... unless you have an implicit reason not to do so.
Done, also removed a warning about unused parameters.
What's still missing (not only for the new code, but the wole class) are (doxyblocks) comments.

Updated patch attached (no change of functionality).

EDIT:

Patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg93186.html#msg93186 (http://forums.codeblocks.org/index.php/topic,13826.msg93186.html#msg93186)
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on December 12, 2010, 12:04:33 pm
Updated patch attached (no change of functionality).
Well, I notice another thing (which I thought was due to a background app on my PC when I tried the first time):
1.) The tooltip flickers quite ugly on Windows XP. It seems it's set a "million" times when I keep hovering over the tab. Notice that I don't move the mouse. Probably a little caching (like checking if the old tooltip is the same as the new one) might help...?!
2.) While the tooltip is showing I have no access any longer to the menu using the right mosue button. :-(

Edit: [additional info to 2.)] -> Again this is only, if I don't move the mouse. f I move the mouse a little bit on the tab and press the right mouse button I see the menu. Hence I guess it's because he tooltip is no longer shown in that case.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 12, 2010, 12:35:00 pm
The second issue is known, it seems the tipwindow "steals" the mouse-button events.
I also saw the first, but only with the first patch if the tipwindow was shown, even if the app was not the foreground application, I will look into it.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 12, 2010, 01:02:49 pm
Another two issues:

1. Changing the desktop using the keyboard (alt+fn in E17) doesn't hide the tooltip
2. Tooltip doesn't show for .wxs files

p.s. if you can fix the TipWindow to not steel the key/mouse input will be great because this is really annoying problem for the debugger :(
p.p.s. is it possible to resend the events to the root window?
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 12, 2010, 03:14:42 pm
Updated patch attached (no change of functionality).
Well, I notice another thing (which I thought was due to a background app on my PC when I tried the first time):
1.) The tooltip flickers quite ugly on Windows XP. It seems it's set a "million" times when I keep hovering over the tab. Notice that I don't move the mouse. Probably a little caching (like checking if the old tooltip is the same as the new one) might help...?!
2.) While the tooltip is showing I have no access any longer to the menu using the right mosue button. :-(

Edit: [additional info to 2.)] -> Again this is only, if I don't move the mouse. f I move the mouse a little bit on the tab and press the right mouse button I see the menu. Hence I guess it's because he tooltip is no longer shown in that case.

The second issue is hopefully fixed with this update.
About the first: I cannot reproduce (don't want to boot into XP at the moment), but might also be fixed.

Another two issues:

1. Changing the desktop using the keyboard (alt+fn in E17) doesn't hide the tooltip
2. Tooltip doesn't show for .wxs files

p.s. if you can fix the TipWindow to not steel the key/mouse input will be great because this is really annoying problem for the debugger :(
p.p.s. is it possible to resend the events to the root window?

1. should be fixed (can not reproduce on gnome)
2. I guess it has to be fixed in wxSmith ( comes later, if the other things work correctly)

EDIT:

Patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg93202.html#msg93202 (http://forums.codeblocks.org/index.php/topic,13826.msg93202.html#msg93202)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 12, 2010, 06:41:51 pm
No1 is fixed, thanks

There is another problem: when I move the mouse the tooltip is not hidden.
Steps to reproduce:
1. Hover on a tab and way the tooltip to show
2. Move the mouse in the direction of the editor.
    The movement should be fast, so no MouseMoved messages are received by the notebook.
    If the mouse is moved horizontally the tooltip disappears as expected.

Probably you have to listen for MouseEnter, MouseLeave events....
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 12, 2010, 07:23:40 pm
No1 is fixed, thanks

There is another problem: when I move the mouse the tooltip is not hidden.
Steps to reproduce:
1. Hover on a tab and way the tooltip to show
2. Move the mouse in the direction of the editor.
    The movement should be fast, so no MouseMoved messages are received by the notebook.
    If the mouse is moved horizontally the tooltip disappears as expected.

Probably you have to listen for MouseEnter, MouseLeave events....

Should be fixed with this patch.

EDIT:

Patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg93222.html#msg93222 (http://forums.codeblocks.org/index.php/topic,13826.msg93222.html#msg93222)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 12, 2010, 08:49:56 pm
Fix confirmed :)
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on December 13, 2010, 12:31:50 pm
Should be fixed with this patch.
Excellent work! Both is fine now. I'd vote for an application to trunk.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 13, 2010, 02:01:52 pm
Should be fixed with this patch.
Excellent work! Both is fine now. I'd vote for an application to trunk.

If there are no objections from other devs, I will do it this evening.

Anyway here is an updated patch, that also shows project for wxSmith-, hexeditor-, xpmeditor-, etc.-files, and updates the projectname in tooltip, if the project gets renamed via properties-dialog.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 14, 2010, 11:34:06 am
Committed as svn r6896
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 14, 2010, 12:15:04 pm
Wonderful !!! I really like it, nice job...

The only thing I found is that after the tool-tip is shown, no keyboard shortcuts are working anymore... I mean, you just wait for the tool-tip to shown and then try F2, F9 or F11 and nothing happens....
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 14, 2010, 12:24:30 pm
It is know and discussed problem (see in the previous posts).
And unfortunately it is not easily fixable.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 14, 2010, 03:38:42 pm
Jens (as our auiNotebook specialist): I have another feature request:

The problem is:
1. open tabs, so that all tabs can't be visible at the same time
2. scroll to the last tab
3. close the last tab
4. the tabs on the left of the last tab don't move.

Is it possible to make tabs on the left move to the right
(the notebook will behave like the one in firefox for example)?
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 16, 2010, 03:42:10 pm
Jens (as our auiNotebook spe[spammer]t): I have another feature request:

The problem is:
1. open tabs, so that all tabs can't be visible at the same time
2. scroll to the last tab
3. close the last tab
4. the tabs on the left of the last tab don't move.

Is it possible to make tabs on the left move to the right
(the notebook will behave like the one in firefox for example)?

I will attach a patch later this day (or tomorrow), that moves the active tab to the rightmost position, after another tab has been closed.
That's not exactly, what you asked for, but it's a starting point.
It will be  mixed with this patch: http://forums.codeblocks.org/index.php/topic,13862.msg93310.html#msg93310 (http://forums.codeblocks.org/index.php/topic,13862.msg93310.html#msg93310)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 16, 2010, 05:10:14 pm
Jens (as our auiNotebook spe[spammer]t): I have another feature request:
I'm not sure how this happened. I meant spe-ci-a-list, not spammer and I hope I've not offended you Jen :)

I'm waiting for the patch and I'll test is as soon as available :)

p.s. there is something wrong in the forum :(
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 16, 2010, 05:25:00 pm
Jens (as our auiNotebook spe[spammer]t): I have another feature request:
I'm not sure how this happened. I meant spe-ci-a-list, not spammer and I hope I've not offended you Jen :)

I'm waiting for the patch and I'll test is as soon as available :)

p.s. there is something wrong in the forum :(
It's our (new) antispam module, it reconizes c i a l i s as spam (something like v i a g r a), it should not do it inside a word.
By the way: my nickname is like my real name Jens (http://en.wikipedia.org/wiki/Jens).
The patch comes after some more cleanup.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 16, 2010, 06:11:38 pm
The patch comes after some more cleanup.

Her it is, as written it contains the maximize-editor-on-tab-dclk-patch as described here: http://forums.codeblocks.org/index.php/topic,13862.msg93310.html#msg93310 (http://forums.codeblocks.org/index.php/topic,13862.msg93310.html#msg93310) .
It's not tested on windows, and might not work correctly in some cases with tabs, that are moved with drag and drop.

EDIT:

Updated patch: http://forums.codeblocks.org/index.php/topic,13826.msg93555.html#msg93555 (http://forums.codeblocks.org/index.php/topic,13826.msg93555.html#msg93555)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 16, 2010, 07:28:06 pm
Unfortunately the patch doesn't apply in the debuggers branch, so I can't test it :(
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 16, 2010, 07:58:27 pm
Unfortunately the patch doesn't apply in the debuggers branch, so I can't test it :(
So try this, just the minimize space patch, without the other changes.
Not (yet) tested (currently compiling), but it's against actual revision of debugger-branch.

Does not compile (most likely a missing include).
Update comes later this evening, no time at the moment.

EDIT:

Updated patch: http://forums.codeblocks.org/index.php/topic,13826.msg93389.html#msg93389 (http://forums.codeblocks.org/index.php/topic,13826.msg93389.html#msg93389)
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 16, 2010, 10:04:02 pm
This one should compile and work, I missed an essential part in the first one.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 20, 2010, 01:22:32 pm
Since the feature-request season is open... ;-)

On thing I miss is the ability to scroll through the tabs (notebooks) by using the mouse wheel.

Here is an updated patch that includes the maximize-editor-on-tab-dclk-patch described here: http://forums.codeblocks.org/index.php/topic,13862.msg93310.html#msg93310 ,
the minimize-free-space-patch as described above and a patch that allows scrolling through the tabs.
The mousewheel-feature is easy to implement on wxGTK, but needs a hack using mouseenter- and mouseleave-event on windows.
That's the cause, why it took so long to create it.

EDIT:

Updated patch: http://forums.codeblocks.org/index.php/topic,13826.msg93583.html#msg93583 (http://forums.codeblocks.org/index.php/topic,13826.msg93583.html#msg93583)
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 20, 2010, 01:37:34 pm
The mousewheel-feature is easy to implement on wxGTK, but needs a hack using mouseenter- and mouseleave-event on windows.
That's the cause, why it took so long to create it.
Thanks jens... I was actually thinking that your super DwellTimer could also be used to implement the mousewheel and I got the same problems as you... but, anyway, you were quicker... Very nice !!! I've downloaded the patch and will test right now !

Thank you again!
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 20, 2010, 01:53:20 pm
Maximize on double-click and mousewheel working like a charm... Great!!!

However, I the tooltip is not working anymore... is this normal? (I missed it already)
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 20, 2010, 02:05:46 pm
@jens:

It crashed here, just after I finished writing the last post and clicked back on C::B... :-)

Here is the RPT:
Code
Error occured on Monday, December 20, 2010 at 13:50:56.

C:\Work\codeblocks_trunk\src\output\codeblocks.exe caused an Access Violation at location 010e5a77 in module C:\Work\codeblocks_trunk\src\output\codeblocks.dll Reading from location 00000000.

Registers:
eax=00000000 ebx=00000000 ecx=0022f4e0 edx=0000000e esi=ffffffff edi=0022f4e0
eip=010e5a77 esp=0022f398 ebp=0022f3c0 iopl=0         nv up ei pl zr na po nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00010246

Call stack:
010E5A77  C:\Work\codeblocks_trunk\src\output\codeblocks.dll:010E5A77  _ZN13cbAuiNotebook14OnLeaveTabCtrlER12wxMouseEvent
62783C28  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:62783C28  _ZN12wxEvtHandler21ProcessEventIfMatchesERK21wxEventTableEntryBasePS_R7wxEvent
6278404E  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:6278404E  _ZN12wxEvtHandler23SearchDynamicEventTableER7wxEvent
62784103  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:62784103  _ZN12wxEvtHandler12ProcessEventER7wxEvent
627CF28E  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:627CF28E  _ZN8wxWindow18GenerateMouseLeaveEv
627D22CC  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:627D22CC  _ZN8wxWindow13MSWWindowProcEjjl
627CB6FE  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:627CB6FE  _Z9wxWndProcP6HWND__jjl@16
77ECFD72  C:\Windows\system32\USER32.dll:77ECFD72  GetWindowLongW
77ECFE4A  C:\Windows\system32\USER32.dll:77ECFE4A  GetWindowLongW
77ED018D  C:\Windows\system32\USER32.dll:77ED018D  GetMessageW
77ED022B  C:\Windows\system32\USER32.dll:77ED022B  DispatchMessageW
627B0966  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:627B0966  _ZN11wxEventLoop14ProcessMessageEP6tagMSG
627B0B43  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:627B0B43  _ZN11wxEventLoop8DispatchEv
62844A6C  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:62844A6C  _ZN17wxEventLoopManual3RunEv
62824279  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:62824279  _ZN9wxAppBase8MainLoopEv
004058C4  C:\Work\codeblocks_trunk\src\output\codeblocks.exe:004058C4
6273114E  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:6273114E  _Z14wxEntryCleanupv
627895D6  C:\Work\codeblocks_trunk\src\output\wxmsw28u_gcc_custom.dll:627895D6  _Z7wxEntryP11HINSTANCE__S0_Pci
00401D71  C:\Work\codeblocks_trunk\src\output\codeblocks.exe:00401D71  WinMain@16  C:/Work/codeblocks_trunk/src/src/app.cpp:260
00460446  C:\Work\codeblocks_trunk\src\output\codeblocks.exe:00460446
004010DB  C:\Work\codeblocks_trunk\src\output\codeblocks.exe:004010DB
00401158  C:\Work\codeblocks_trunk\src\output\codeblocks.exe:00401158
768ED0E9  C:\Windows\system32\kernel32.dll:768ED0E9  BaseThreadInitThunk
77D319BB  C:\Windows\system32\ntdll.dll:77D319BB  RtlInitializeExceptionChain
77D3198E  C:\Windows\system32\ntdll.dll:77D3198E  RtlInitializeExceptionChain

Sorry, but I cannot give you more information, see below...
Code
addr2line -e C:\Work\codeblocks_trunk\src\devel\codeblocks.dll 010E5A77

C:\Work\codeblocks_trunk\src\output\codeblocks.dll[010E5A77]:
??:0
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 20, 2010, 06:29:11 pm
@jens:

It crashed here, just after I finished writing the last post and clicked back on C::B... :-)


No such crash here.
Did you try to remove the devel and output subdirectory and the pch-files (include/*.gch) manually, to be sure everything is linked correctly.

The windows-hack for the mousewheel seems to break the tooltips. I will see if I find a solution.
For the moment, you can just comment out the part of the hack in cbauinotebook.cpp in cbAuiNotebook::UpdateTabControlsArray() (the lines that disconnect and connect the wxEVT_LEAVE_WINDOW and wxEVT_ENTER_WINDOW events).
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 21, 2010, 07:43:36 am
@jens:

It crashed here, just after I finished writing the last post and clicked back on C::B... :-)


No such crash here.
Did you try to remove the devel and output subdirectory and the pch-files (include/*.gch) manually, to be sure everything is linked correctly.

The windows-hack for the mousewheel seems to break the tooltips. I will see if I find a solution.
For the moment, you can just comment out the part of the hack in cbauinotebook.cpp in cbAuiNotebook::UpdateTabControlsArray() (the lines that disconnect and connect the wxEVT_LEAVE_WINDOW and wxEVT_ENTER_WINDOW events).
I found the cause for the crash (shame on me): the dynamically connected event-handler have the control, that sends the event as this-pointer, not the instance of the class, they are member of. But the compiler does not know this (dynamically) and therefore it does not lead to an error, if we call a member-function directly or use a member-variable as pointer.
It's corrected now, also the issuethat the tooltips are closed immediately aftr they are created.
ToolTip-creation gives the focus to the tooltip, this leads to a mouseleave-evemt of the tabctrl, this leads to a restore of the old focus (or set it to the new selected tab) and this closes the tooltip, because it loses the focus.

Should be fixed in the attached patch.

EDIT:

updated patch: http://forums.codeblocks.org/index.php/topic,13826.msg93728.html#msg93728 (http://forums.codeblocks.org/index.php/topic,13826.msg93728.html#msg93728)
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 21, 2010, 08:29:23 am
OK, thanks... Compiling right now, I'll report back after testing... :-)
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 22, 2010, 11:47:11 am
Should be fixed in the attached patch.
Yeap, I confirm, no more crashes here....

@jens:
I've changed the Mousewheel behavior. What I wanted originally was just scrolling the tabs and not changing the current editor tab, so here is what I did in "cbAuiNotebook::OnTabCtrlMouseWheel" (file cbauibook.cpp:265) :
Code
void cbAuiNotebook::OnTabCtrlMouseWheel(wxMouseEvent& event)
{
    wxAuiTabCtrl* tabCtrl = (wxAuiTabCtrl*)event.GetEventObject();
    cbAuiNotebook* nb = (cbAuiNotebook*)tabCtrl->GetParent();
    wxWindow* win = (wxWindow*) nb->GetParent();
    nb->CancelToolTip();
    nb->m_LastTime = nb->m_StopWatch.Time();
    nb->SetSelection(nb->GetPageIndex(tabCtrl->GetWindowFromIdx(tabCtrl->GetActivePage())));

size_t tabOffset = tabCtrl->GetTabOffset();
size_t lastTabIdx = tabCtrl->GetPageCount()-1;
wxClientDC dc(win);
//Manager::Get()->GetLogManager()->DebugLog(F(_T("MouseWheel: tabOffset before=%d (last %d) [last visible=%1d]\n"),tabOffset,lastTabIdx,tabCtrl->IsTabVisible(lastTabIdx,tabOffset,&dc,win)));
if (event.GetWheelRotation() > 0)
{
if (!tabCtrl->IsTabVisible(lastTabIdx,tabOffset,&dc,win))
tabOffset++;
}
else
{
if (tabOffset > 0)
tabOffset--;
}
tabCtrl->SetTabOffset(tabOffset);
nb->Refresh();
}

Sorry, it was easier just to give you my code than to create a patch against your patch... :-)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on December 22, 2010, 12:27:33 pm
But you could generate new patch, so I can test it :)
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 22, 2010, 01:16:38 pm
Here it goes, patch against trunk rev6904...
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 22, 2010, 02:18:21 pm
Should be fixed in the attached patch.
Yeap, I confirm, no more crashes here....

@jens:
I've changed the Mousewheel behavior. What I wanted originally was just scrolling the tabs and not changing the current editor tab, so here is what I did in "cbAuiNotebook::OnTabCtrlMouseWheel" (file cbauibook.cpp:265) :
[...]
Sorry, it was easier just to give you my code than to create a patch against your patch... :-)

I  understood that, but I think it's not really intuitive.
In other applications scrolling with the mousewheel als changes the focus.

What do you think about making it configurable:
as default scrolling with mousewheel changes the focus, but with key pressed (I suggest ctrl) we only scroll through the tabs without changing the activated tab.
The default behaviour, without additional key (scrolling and activating or just scrolling) can be made configurable and the additional key also.
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on December 22, 2010, 02:29:32 pm
I  understood that, but I think it's not really intuitive.
In other applications scrolling with the mousewheel als changes the focus.
It's interesting, because I find it so much more intuitive than changing the focus...And I'm sure I've seeing it in some other application,  but I can't remember where... Anyway, just found interesting how what we find intuitive or not is related to our life experience...  8)

What do you think about making it configurable:
as default scrolling with mousewheel changes the focus, but with key pressed (I suggest ctrl) we only scroll through the tabs without changing the activated tab.
The default behaviour, without additional key (scrolling and activating or just scrolling) can be made configurable and the additional key also.
I like the idea of making it configurable and having a modifying key to change behavior... I'd go for it...
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on December 26, 2010, 12:22:01 am
I  understood that, but I think it's not really intuitive.
In other applications scrolling with the mousewheel als changes the focus.
It's interesting, because I find it so much more intuitive than changing the focus...And I'm sure I've seeing it in some other application,  but I can't remember where... Anyway, just found interesting how what we find intuitive or not is related to our life experience...  8)

What do you think about making it configurable:
as default scrolling with mousewheel changes the focus, but with key pressed (I suggest ctrl) we only scroll through the tabs without changing the activated tab.
The default behaviour, without additional key (scrolling and activating or just scrolling) can be made configurable and the additional key also.
I like the idea of making it configurable and having a modifying key to change behavior... I'd go for it...

Here comes an updated patch, that includes your changes, but make it configurable in "Settings -> Environment -> Notebooks appearance" (not the best title for it, but it's not totally wrong there). The text of the radiobuttons might not be optimal, but it's not easy to describe it in a short term (any better ideas are welcome).

The minimize space part works better now (selected tab will not be moved to the rightmost place, if mnot necessary), but works still not good with reordered tabs (drag and drop). An updated patch will come.

EDIT:
patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg94108.html#msg94108 (http://forums.codeblocks.org/index.php/topic,13826.msg94108.html#msg94108)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on January 06, 2011, 02:27:23 am
Jens: your patch seems to work well, I think I've not encountered any problems using it...

But I've another feature request:
1. open many tabs
2. enlarge the project manager (on the left side of the editor)
3. select the last opened file
4. shrink the project manager

The result is that there unused space on the notebooks (same as the file closing problem).
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on January 06, 2011, 06:52:13 am
Jens: your patch seems to work well, I think I've not encountered any problems using it...
I got another one: C::B started to crash since application of this patch in very rare cases that seems to happen when C::B was running in the background and the mouse is hovering over the tab so that it gets "Re-Activated" I don't remember the exact reason though (I accidentally deleted the report file) but it happened more than once. I can (however) not reproduce... :-(
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 06, 2011, 08:01:34 am
Jens: your patch seems to work well, I think I've not encountered any problems using it...

But I've another feature request:
1. open many tabs
2. enlarge the project manager (on the left side of the editor)
3. select the last opened file
4. shrink the project manager

The result is that there unused space on the notebooks (same as the file closing problem).
I will see what can be done.

Jens: your patch seems to work well, I think I've not encountered any problems using it...
I got another one: C::B started to crash since application of this patch in very rare cases that seems to happen when C::B was running in the background and the mouse is hovering over the tab so that it gets "Re-Activated" I don't remember the exact reason though (I accidentally deleted the report file) but it happened more than once. I can (however) not reproduce... :-(

I try to reproduce it on win7, but if the app is not active, the dwell-timer should return (after destroying tooltips if they still exist).
MouseEnter and MouseLeave events should not be triggered if the app is not active and therefore does not have the focus, but that might happen anyways, I will try to debug it.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 06, 2011, 02:22:11 pm
Jens: your patch seems to work well, I think I've not encountered any problems using it...

But I've another feature request:
1. open many tabs
2. enlarge the project manager (on the left side of the editor)
3. select the last opened file
4. shrink the project manager

The result is that there unused space on the notebooks (same as the file closing problem).
Should be fixed with the attached patch.

Jens: your patch seems to work well, I think I've not encountered any problems using it...
I got another one: C::B started to crash since application of this patch in very rare cases that seems to happen when C::B was running in the background and the mouse is hovering over the tab so that it gets "Re-Activated" I don't remember the exact reason though (I accidentally deleted the report file) but it happened more than once. I can (however) not reproduce... :-(

Might be fixed also with the patch.
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on January 06, 2011, 03:04:36 pm
@jens:
I've changed the direction of scrolling without activating tabs to be the same when activating, I think it's nicer this way... and more natural as well... There's only one change in cbaiubook.cpp; see the patch attached, which includes your latest patch....
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 06, 2011, 03:21:10 pm
@jens:
I've changed the direction of scrolling without activating tabs to be the same when activating, I think it's nicer this way... and more natural as well... There's only one change in cbaiubook.cpp; see the patch attached, which includes your latest patch....

With my patch, the selection moves from left to right with activating, if I scroll down without activating, the selected tab moves from left to right.

For me it feels more natural this way, but this might be a matter of taste (or what one is used to).

Let's see what other users say.
Title: Re: Request : C::B View::notebook enhancements
Post by: Pecan on January 20, 2011, 08:03:40 pm
How does a user turn off the new tooltip when hovering over the editor tab?

It's interfering with both the middle mouse key and the "x" close button.

I have to click twice to close an editor. On the first click, a tooltip appears. Only then can I click again and close the tab.

svn build  rev 6929 (2011-01-19 11:39:43)   gcc 4.3.1 Windows/unicode - 32 bit

Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on January 20, 2011, 08:31:40 pm
It's interfering with both the middle mouse key and the "x" close button.
Huh? I can't reproduce. How long are you hovering before you click the "X"? And what does actually happen with the middle mouse button?
Title: Re: Request : C::B View::notebook enhancements
Post by: Pecan on January 21, 2011, 04:45:33 pm
For awhile there, I didn't have to hover at all.

Then I deleted my local repository, downloaded and rebuilt. It's working much better now.

However, I would like to turn this feature off. If we're going to add features that popup, we should also give the user a chance to turn them off.
 
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 21, 2011, 10:29:34 pm
I'm currently working on a patch, that alows turning off tooltips completely and to change the dwelltime.
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on January 21, 2011, 10:38:07 pm
I've experienced an issue with this patch on Windows Vista meanwhile. It's (however) VERY weired, I am tryinig to explain anyways:
1.) steps to reproduce (crashes always for me)
- startup a fresh C::B
- open a workspace with a saved last opened editor window, so thatt his editor window is re-opened when opening the workspace
- close the editor via the "X"
- open another file from the project tree
-> You'll see the new editor quickly and then -> CRASH.

In the debugger you#ll see the image as attached. It's this line that fails:
m_pLastFocused->SetFocus();
...in void cbAuiNotebook::RestoreFocus().

However, I don't get why it fails. Comparing the addresses shows that the address of m_pLastFocused is indeed not the one of nullptr. However, it seems also not to be a valid address to a wxWindow -> or probably it hasn't been reset. Now I wonder how that can be. m_pLastFocused is initialised with nullptr or set in void cbAuiNotebook::StoreFocus(). So for me either its a valid pointer or not. The only thing I can imagine is that the window that had the focus (most likely the previous editor) is not released properly on destruction and thus the pointer is not being cleared.

Any ideas? Notice that this happens ONLY on windows Vista for me. All other Windows's I drive are working properly with a binary identical C::B and wxWidgets version.


EDIT: Notice that this does NOT happen if I disable to open the last used editors from settings -> environment -> On project load... I might have disabled this option on the other Windows's, but I can't have a look atm...
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 22, 2011, 07:51:07 am
I've experienced an issue with this patch on Windows Vista meanwhile. It's (however) VERY weired, I am tryinig to explain anyways:
1.) steps to reproduce (crashes always for me)
- startup a fresh C::B
- open a workspace with a saved last opened editor window, so thatt his editor window is re-opened when opening the workspace
- close the editor via the "X"
- open another file from the project tree
-> You'll see the new editor quickly and then -> CRASH.

In the debugger you#ll see the image as attached. It's this line that fails:
m_pLastFocused->SetFocus();
...in void cbAuiNotebook::RestoreFocus().

However, I don't get why it fails. Comparing the addresses shows that the address of m_pLastFocused is indeed not the one of nullptr. However, it seems also not to be a valid address to a wxWindow -> or probably it hasn't been reset. Now I wonder how that can be. m_pLastFocused is initialised with nullptr or set in void cbAuiNotebook::StoreFocus(). So for me either its a valid pointer or not. The only thing I can imagine is that the window that had the focus (most likely the previous editor) is not released properly on destruction and thus the pointer is not being cleared.

Any ideas? Notice that this happens ONLY on windows Vista for me. All other Windows's I drive are working properly with a binary identical C::B and wxWidgets version.


EDIT: Notice that this does NOT happen if I disable to open the last used editors from settings -> environment -> On project load... I might have disabled this option on the other Windows's, but I can't have a look atm...

That's a show stopper for me.

I will try to investigate, nut not this  weekend (no time).
I have an idea what to do, so I try to reproduce and fix it next week.

I will not commit, before the cause is found.
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on January 22, 2011, 02:37:35 pm
That's a show stopper for me.
[...]
I will not commit, before the cause is found.
Agreed.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 24, 2011, 02:22:22 pm
That's a show stopper for me.
[...]
I will not commit, before the cause is found.
Agreed.
Here comes a patch that (hopefully) fixes the issue (it does it at least on win7).
It contains some more changes (tab tooltips can now be disabled generally in "Sedttings -> View -> Notebook appearance", the dwell time can also be configured).

EDIT:
The patch will not apply to trunk later than r6931, some of the included changes are now committed.
More will follow.
I will update the patch tomorrow (it's a lot of work to split the patches  :( ).
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on January 24, 2011, 02:46:26 pm
Here comes a patch that (hopefully) fixes the issue (it does it at least on win7).
So you were able to reproduce? I am very curious what has caused this effect! (I've no access to C::B atm...).
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 24, 2011, 03:17:26 pm
The cause was, that I always tried to restore the previous focus (windows hack), but if the previous focus was on an editor (or more precisely on a cbStyledtextCtrl), this fails after deleting the editor (of course).
Now when deleting (or removing) a page, I check whether the stored pointer (or one of its parents) is the page to be deleted (or removed). In this case I reset the stored pointer to nullptr.

The crash only happened, if the closed page was not the last page, because in this case the selection also has changed and a changed selection (via mousewheel for example) overrides has precedence over restoring the focus.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 25, 2011, 01:32:08 pm
For awhile there, I didn't have to hover at all.

Then I deleted my local repository, downloaded and rebuilt. It's working much better now.

However, I would like to turn this feature off. If we're going to add features that popup, we should also give the user a chance to turn them off.
 
I'm currently working on a patch, that alows turning off tooltips completely and to change the dwelltime.
Applied to trunk svn r6936 !
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 25, 2011, 01:57:18 pm
Jens (as our auiNotebook spe[spammer]t): I have another feature request:

The problem is:
1. open tabs, so that all tabs can't be visible at the same time
2. scroll to the last tab
3. close the last tab
4. the tabs on the left of the last tab don't move.

Is it possible to make tabs on the left move to the right
(the notebook will behave like the one in firefox for example)?

I will attach a patch later this day (or tomorrow)


Applied to trunk svn r6937 !
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on January 25, 2011, 02:02:53 pm
...well done. I can tell the bug I mentioned seems indeed fixed. Thanks for this contribution!
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 25, 2011, 02:41:15 pm
...well done. I can tell the bug I mentioned seems indeed fixed. Thanks for this contribution!
Fixed with the patch against 6931 or does it not appear in trunk ?
The problematic code is not (yet) committed.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 25, 2011, 03:30:19 pm
...well done. I can tell the bug I mentioned seems indeed fixed. Thanks for this contribution!
Fixed with the patch against 6931 or does it not appear in trunk ?
The problematic code is not (yet) committed.

Now it is (svn r6939).
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on January 26, 2011, 02:44:43 pm
I'm experiencing a crash here, after I updated to the last version svn r6939, which could be related to the scroll with mouse-wheel (or not)...

Anyway, before updating it, I was using jens patch and had no crashes...

Steps to reproduce it:
1- open a workspace with many files opened
2- scroll (no activating the tabs) a lot, so that the active editor is no longer visible
3- click on a tab

Here, everything freezes and I have to kill codeblocks and start fresh again.

In case it may help, here is the status of the threads when it freezes:

"bt"
Code
In ntdll!DbgUiConvertStateChangeStructure () (C:\Windows\system32\ntdll.dll)
#0  0x77ab8b2f in ntdll!DbgUiConvertStateChangeStructure () from C:\Windows\system32\ntdll.dll
#1  0x77afc9a0 in ntdll!EtwEventEnabled () from C:\Windows\system32\ntdll.dll
#2  0x38d2a2ac in ?? ()
#3  0x00000000 in ?? ()

"thread apply all bt"
Code
Thread 14 (Thread 6664.0x204c):
#0  0x77ab8b2f in ntdll!DbgUiConvertStateChangeStructure () from C:\Windows\system32\ntdll.dll
#1  0x77afc9a0 in ntdll!EtwEventEnabled () from C:\Windows\system32\ntdll.dll
#2  0x38d2a2ac in ?? ()
#3  0x00000000 in ?? ()
Thread 13 (Thread 6664.0x2618):
#0  wxStringData::Unlock (this=0x62b43f6c) at C:/Work/wxWidgets-2.8.10/include/wx/string.h:243
#1  0x65f08601 in ~wxStringBase (this=0xfa9f9b4, __in_chrg=<value optimized out>) at C:/Work/wxWidgets-2.8.10/include/wx/string.h:396
#2  0x65f0f0e5 in ~wxString (this=0xfa9f9b4, __in_chrg=<value optimized out>) at C:/Work/wxWidgets-2.8.10/include/wx/string.h:660
#3  0x65ef2e80 in Tokenizer::DoGetToken (this=0x10eb1f78) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\tokenizer.cpp:1018
#4  0x65ef37fe in Tokenizer::CalcConditionExpression (this=0x10eb1f78) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\tokenizer.cpp:1228
#5  0x65ef4451 in Tokenizer::HandleConditionPreprocessor (this=0x10eb1f78, type=ptIf) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\tokenizer.cpp:1448
#6  0x65ef238c in Tokenizer::SkipUnwanted (this=0x10eb1f78) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\tokenizer.cpp:902
#7  0x65ef25c8 in Tokenizer::GetToken (this=0x10eb1f78) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\tokenizer.cpp:963
#8  0x65edb8c6 in ParserThread::DoParse (this=0x10eb1f70) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\parserthread.cpp:503
#9  0x65edb671 in ParserThread::Parse (this=0x10eb1f70) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\parserthread.cpp:467
#10 0x65f077a5 in ParserThread::Execute (this=0x10eb1f70) at C:/Work/codeblocks_trunk/src/plugins/codecompletion/parser/parserthread.h:137
#11 0x010a2f62 in cbThreadPool::cbWorkerThread::Entry (this=0xe91cab8) at C:\Work\codeblocks_trunk\src\sdk\cbthreadpool.cpp:228
#12 0x6277d8c4 in wxThreadInternal::DoThreadStart(wxThread*) () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#13 0x6277d9f8 in wxThreadInternal::WinThreadStart () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#14 0x76df2599 in wcstombs () from C:\Windows\system32\msvcrt.dll
#15 0x76df26b3 in msvcrt!_beginthreadex () from C:\Windows\system32\msvcrt.dll
#16 0x7721d0e9 in KERNEL32!AcquireSRWLockExclusive () from C:\Windows\system32\kernel32.dll
#17 0x77ab19bb in ntdll!RtlInitializeNtUserPfn () from C:\Windows\system32\ntdll.dll
#18 0x77ab198e in ntdll!RtlInitializeNtUserPfn () from C:\Windows\system32\ntdll.dll
#19 0x00000000 in ?? ()
Thread 10 (Thread 6664.0x1bb4):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77219884 in WaitForSingleObjectEx () from C:\Windows\system32\kernel32.dll
#3  0x00000230 in ?? () at C:/Work/codeblocks_trunk/src/src/scriptingsettingsdlg.h:30
#4  0x00000000 in ?? ()
Thread 9 (Thread 6664.0x171c):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77219884 in WaitForSingleObjectEx () from C:\Windows\system32\kernel32.dll
#3  0x000001f0 in ?? () at C:/Work/codeblocks_trunk/src/src/scriptingsettingsdlg.h:29
#4  0x00000000 in ?? ()
Thread 8 (Thread 6664.0x1914):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77219884 in WaitForSingleObjectEx () from C:\Windows\system32\kernel32.dll
#3  0x00000170 in ?? () at C:/Work/codeblocks_trunk/src/src/scriptingsettingsdlg.h:27
#4  0x00000000 in ?? ()
Thread 7 (Thread 6664.0x1a10):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77219884 in WaitForSingleObjectEx () from C:\Windows\system32\kernel32.dll
#3  0x00000168 in ?? () at C:/Work/codeblocks_trunk/src/src/scriptingsettingsdlg.h:27
#4  0x00000000 in ?? ()
Thread 6 (Thread 6664.0x1cfc):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77219884 in WaitForSingleObjectEx () from C:\Windows\system32\kernel32.dll
#3  0x0000015c in ?? () at C:/Work/codeblocks_trunk/src/src/scriptingsettingsdlg.h:27
#4  0x00000000 in ?? ()
Thread 5 (Thread 6664.0xd88):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77219884 in WaitForSingleObjectEx () from C:\Windows\system32\kernel32.dll
#3  0x00000158 in ?? () at C:/Work/codeblocks_trunk/src/src/scriptingsettingsdlg.h:27
#4  0x00000000 in ?? ()
Thread 3 (Thread 6664.0x16ac):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad50b0 in ntdll!ZwRemoveIoCompletion () from C:\Windows\system32\ntdll.dll
#2  0x7721d11e in KERNEL32!GetQueuedCompletionStatusEx () from C:\Windows\system32\kernel32.dll
#3  0x76c803c8 in RPCRT4!NdrTypeFree () from C:\Windows\system32\rpcrt4.dll
#4  0x00000108 in ?? ()
#5  0x05dffed8 in ?? ()
#6  0x76c804fd in RPCRT4!NdrTypeFree () from C:\Windows\system32\rpcrt4.dll
#7  0xffffffff in ?? ()
#8  0x05dfff44 in ?? ()
#9  0x76c8011c in RPCRT4!NdrTypeFree () from C:\Windows\system32\rpcrt4.dll
#10 0x05dfff7c in ?? ()
#11 0x76c800e3 in RPCRT4!NdrTypeFree () from C:\Windows\system32\rpcrt4.dll
#12 0x00c09480 in ?? ()
#13 0x76c80166 in RPCRT4!NdrTypeFree () from C:\Windows\system32\rpcrt4.dll
#14 0x00c08d38 in ?? ()
#15 0x7721d0e9 in KERNEL32!AcquireSRWLockExclusive () from C:\Windows\system32\kernel32.dll
#16 0x77ab19bb in ntdll!RtlInitializeNtUserPfn () from C:\Windows\system32\ntdll.dll
#17 0x77ab198e in ntdll!RtlInitializeNtUserPfn () from C:\Windows\system32\ntdll.dll
#18 0x00000000 in ?? ()
Thread 1 (Thread 6664.0xb04):
#0  0x77ad5e74 in ntdll!LdrAccessResource () from C:\Windows\system32\ntdll.dll
#1  0x77ad5620 in ntdll!ZwWaitForSingleObject () from C:\Windows\system32\ntdll.dll
#2  0x77aae16a in ntdll!RtlAddAccessDeniedObjectAce () from C:\Windows\system32\ntdll.dll
#3  0x77aae04d in ntdll!RtlAddAccessDeniedObjectAce () from C:\Windows\system32\ntdll.dll
#4  0x6277b829 in wxCriticalSection::Enter() () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#5  0x65f0d1fd in wxCriticalSectionLocker (this=0x22f4f8, cs=...) at C:/Work/wxWidgets-2.8.10/include/wx/thread.h:286
#6  0x65eda619 in ParserThread::ParseBufferForNamespaces (this=0x22f5a0, buffer=..., result=...) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\parserthread.cpp:261
warning: (Internal error: pc 0x22f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x22f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x22f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x22f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x1ef in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x1ef in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x1ef in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x1ef in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x1ef in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x16f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x16f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x16f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x16f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x16f in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x167 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x167 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x167 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x167 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x167 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x15b in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x15b in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x15b in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x15b in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x15b in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x157 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x157 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x157 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x157 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x157 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x107 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x107 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x107 in read in psymtab, but not in symtab.)
warning: (Internal error: pc 0x107 in read in psymtab, but not in symtab.)
#7  0x65ed63c9 in Parser::ParseBufferForNamespaces (this=0xe91d7f8, buffer=..., result=...) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\parser\parser.cpp:595
#8  0x65eac80c in CodeCompletion::ParseFunctionsAndFillToolbar (this=0x84d6458, force=false) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\codecompletion.cpp:2143
#9  0x65eadcbd in CodeCompletion::OnStartParsingFunctions (this=0x84d6458, event=...) at C:\Work\codeblocks_trunk\src\plugins\codecompletion\codecompletion.cpp:2416
#10 0x62783c28 in wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#11 0x62783d61 in wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#12 0x6278412c in wxEvtHandler::ProcessEvent(wxEvent&) () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#13 0x6288cbdd in wxTimerBase::Notify() () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#14 0x627c28f4 in wxTimerProc () from C:\Work\codeblocks_trunk\src\devel\wxmsw28u_gcc_custom.dll
#15 0x77c4fd72 in USER32!GetWindowMinimizeRect () from C:\Windows\system32\user32.dll
#16 0x00000000 in ?? ()
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on January 26, 2011, 03:01:18 pm
This looks like a CC problem.
Can you try to disable the CC and try to reproduce it.
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on January 26, 2011, 03:07:04 pm
This looks like a CC problem.
Can you try to disable the CC and try to reproduce it.
Sorry, now I cannot reproduce it anymore, with or without CC enabled... it seems it's related with a very particular set-up, i.e. which tab was active and to which I go after...

But I'll keep in mind the suggestion and next time I try to disable CC....

Edit:
I was able to reproduce it again and it really seems that when CC is disable I have no bugs anymore... Since using C::B without CC is not an option, what would be the next step? Start another Post?
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on January 26, 2011, 03:53:09 pm
It really seems that when CC is disable I have no bugs anymore... Since using C::B without CC is not an option, what would be the next step? Start another Post?
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on January 26, 2011, 04:05:30 pm
If you can provide a minimal sample + steps to reproduce, it will be best.
The other option is to build C::B with debug info and to start debugging in order to find the cause for the crash:)
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on January 27, 2011, 08:54:24 am
What happens if you change the editor from the open files list ?
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on January 27, 2011, 09:22:40 am
@jens:
I cannot reproduce the problem anymore now... It's really annoying because sometimes it's easily reproducible and sometimes it's not just happening for a long time... But I soon as I can reproduce it again, I'll try the open files list...

@oBFusCATed:
Right now, I cannot reduce the problem to a minimal sample...

@all:
One thing I noticed, though, is that when I have the freeze, it occurs before the line under caret gets highlighted in the editor. Maybe that gives you a clue... :-)

From my side, I'd be more than happy to help by doing some debugging, but I'm still not sure what I have to look for (and, of course, first I need to be able to reproduce the freeze again).

One more info: I've turned on the  debug output on parserthread.cpp
Code
#define CC_PARSERTHREAD_DEBUG_OUTPUT 1
and I see lots of messages in the DebugLog panel (as expected). If I change from one tab to another before waiting for *all* messages to show up, i.e. while the logging is in progress, it freezes here, no matter what!
I'm just not sure if this is because the parser hasn't finished and that causes the freeze or it's just a display problem, that the DebugLog is flooded with messages and moving to another editor tab just cannot be treated by the painting thread... Anyway, just FYI.
Title: Re: Request : C::B View::notebook enhancements
Post by: ollydbg on January 27, 2011, 09:28:27 am
One more info: I've turned on the  debug output on parserthread.cpp
Code
#define CC_PARSERTHREAD_DEBUG_OUTPUT 1
and I see lots of messages in the DebugLog panel (as expected). If I change from one tab to another before waiting for *all* messages to show up, i.e. while the logging is in progress, it freezes here, no matter what!
I'm just not sure if this is because the parser hasn't finished and that causes the freeze or it's just a display problem, that the DebugLog is flooded with messages and moving to another editor tab just cannot be treated by the painting thread... Anyway, just FYI.
This is because there are too many log message, so you will get freeze, You can disable all the "header path search" in the CC dialog, so that CC can only parse your project files.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on February 17, 2011, 10:25:25 pm
There is another bug with the enhancement:

1. Goto the main menu
2. Open a menu that is rendered on top of the notebook
3. Hover on an item on top of the notebook

The result is that the menu closes and the tooltip shows
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on February 17, 2011, 10:34:20 pm
There is another bug with the enhancement:

1. Goto the main menu
2. Open a menu that is rendered on top of the notebook
3. Hover on an item on top of the notebook

The result is that the menu closes and the tooltip shows
Here, on Windows Vista 32-bit, trunk svn 7010, the menu doesn't close when the tooltip shows and I can come back to it...
However, if I do one more step:
4- after the tooltip is shown, click outside C::B

C::B crashes! :-o
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on February 17, 2011, 10:46:32 pm
I look into it, thanks for reporting.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on February 18, 2011, 10:08:29 am
Could you please test svn r7011 (if needed, I can merge trunk to debugger-branch).
I was not able to reproduce the crash on windows (tested on vista 64-bit), but the tooltip should not appear any more if the tab is behind an open menu.
So the crash might also be fixed.
Title: Re: Request : C::B View::notebook enhancements
Post by: daniloz on February 18, 2011, 10:29:08 am
Could you please test svn r7011 (if needed, I can merge trunk to debugger-branch).
I was not able to reproduce the crash on windows (tested on vista 64-bit), but the tooltip should not appear any more if the tab is behind an open menu.
So the crash might also be fixed.
Great work!  8)
I can confirm, no more tooltip if the menu is open and, most important, no more crashes !!!
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on February 18, 2011, 05:29:24 pm
(if needed, I can merge trunk to debugger-branch).
I can test only after a merge, but don't worry, too much.

Another thing:
If I click on a tab that is not the first one, but it is not the last one either, the tab I've clicked on is made the first one.
There more tabs, than there is space on the notebook, so probably your code for scrolling is kicking in.
This behaviour is a bit annoying...
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on February 18, 2011, 05:39:34 pm
Another thing:
If I click on a tab that is not the first one, but it is not the last one either, the tab I've clicked on is made the first one.
There more tabs, than there is space on the notebook, so probably your code for scrolling is kicking in.
This behaviour is a bit annoying...

Confirmed.
Next issue to fix.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on February 19, 2011, 04:03:30 pm
Another thing:
If I click on a tab that is not the first one, but it is not the last one either, the tab I've clicked on is made the first one.
There more tabs, than there is space on the notebook, so probably your code for scrolling is kicking in.
This behaviour is a bit annoying...

Confirmed.
Next issue to fix.
Should be fixed in svn r7015 on trunk and svn r7016 in debugger-branch.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on February 19, 2011, 04:24:04 pm
Testing it ... seems the two problems are fixed...

Can you implement an invert scrolling options?
I want to have the same scrolling as in Firefox, but at the moment it is in the opposite direction.
It is a little bit confusing, because I'm scrolling first to the wrong direction, then I realize it is the opposite,
so I always do two operations instead of just one.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on February 19, 2011, 05:06:05 pm
Testing it ... seems the two problems are fixed...

Can you implement an invert scrolling options?
I want to have the same scrolling as in Firefox, but at the moment it is in the opposite direction.
It is a little bit confusing, because I'm scrolling first to the wrong direction, then I realize it is the opposite,
so I always do two operations instead of just one.
Inverse scrolling for both kinds of scrolling ?
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on February 19, 2011, 05:09:59 pm
Yes, also the scrolling of the active editor could have an option to enable/disable wrapping
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on June 06, 2011, 11:55:28 pm
Hm, I think, I've solved the tooltip steeling focus bug.
The problem seems to be in the wxWidgets, more specifically in the constructor of wxTipWindow.
Replace the line 120 in tipwnd.cpp from:
Code
           : wxPopupTransientWindow(parent)
To:
Code
           : wxPopupTransientWindow(parent, wxBORDER_NONE|wxWANTS_CHARS)

I've not talked with the wx guys, nor have I tested it thoroughly...
Title: Re: Request : C::B View::notebook enhancements
Post by: nanyu on June 07, 2011, 10:17:32 am
I have a "half finished" work about "tab on left/right".
Is the code useful?
sorry for my english, let's see a image:
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on June 07, 2011, 05:40:41 pm
Hm, I think, I've solved the tooltip steeling focus bug.
The problem seems to be in the wxWidgets, more specifically in the constructor of wxTipWindow.
Replace the line 120 in tipwnd.cpp from:
Code
           : wxPopupTransientWindow(parent)
To:
Code
           : wxPopupTransientWindow(parent, wxBORDER_NONE|wxWANTS_CHARS)

I've not talked with the wx guys, nor have I tested it thoroughly...
I'm not at home this week (and the next two weeks also), but I will test it theis evening in the hotel or at one of the weekends.
It would be really great  if that can fix it.
Title: Re: Request : C::B View::notebook enhancements
Post by: MortenMacFly on June 08, 2011, 08:02:43 am
I have a "half finished" work about "tab on left/right".
Is the code useful?
What component is modified? You can post a patch anyways to try...
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on August 30, 2011, 09:34:02 am
The notebook enhancements are pretty good, but there is one thing that is really annoying.
The problem is that when I click on a tab, the tab/notebook control gets the focus.
This means that all subsequent key presses (left/right arrow, home, end) are handled by the notebook, not the editor.

This is very annoying because, when I click on a tab, my intention is to work with the file in that tab,
not to use the keys to switch tabs or go to the first tab.

Jens, do you think this can be fixed?

Steps:
1. Open many files
2. Click on a tab
3. Press home
4. The result is that the first tab is selected and the notebook is switched to it. What should have happened is to go to to the beginning of the file.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on August 30, 2011, 02:08:45 pm
The notebook enhancements are pretty good, but there is one thing that is really annoying.
The problem is that when I click on a tab, the tab/notebook control gets the focus.
This means that all subsequent key presses (left/right arrow, home, end) are handled by the notebook, not the editor.

This is very annoying because, when I click on a tab, my intention is to work with the file in that tab,
not to use the keys to switch tabs or go to the first tab.

Jens, do you think this can be fixed?

Steps:
1. Open many files
2. Click on a tab
3. Press home
4. The result is that the first tab is selected and the notebook is switched to it. What should have happened is to go to to the beginning of the file.
This should be possible, but would lead to problems on windows, where I force the focus to the tabcontrol, if mousewheelscrolling for tabs is allowed and the mouse-pointer is over the tabs (of course), because otherwise the mousewheel-event is not catched.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on August 30, 2011, 02:54:11 pm
Linux-only solution is OK  8)
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on October 19, 2011, 04:15:23 pm
Another enhancement request:

Steps to reproduce:
1. Open many tabs
2. Make the last tab visible and active
3. Double click on the last tab
4. When switched to the minimal perspective the last tab is not at the right of the notebook, but there is empty space. Probably this could be optimized.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on October 19, 2011, 04:59:48 pm
Another enhancement request:

Steps to reproduce:
1. Open many tabs
2. Make the last tab visible and active
3. Double click on the last tab
4. When switched to the minimal perspective the last tab is not at the right of the notebook, but there is empty space. Probably this could be optimized.
This should not happen (and it used to work correctly, since I added the MinimizeFreeSpace-function in cbAuiNotebook), but I saw this issue also.
I will try to find the cause and fix it.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on October 20, 2011, 12:28:05 am
Another enhancement request:

Steps to reproduce:
1. Open many tabs
2. Make the last tab visible and active
3. Double click on the last tab
4. When switched to the minimal perspective the last tab is not at the right of the notebook, but there is empty space. Probably this could be optimized.
This should not happen (and it used to work correctly, since I added the MinimizeFreeSpace-function in cbAuiNotebook), but I saw this issue also.
I will try to find the cause and fix it.

Should be fixed in trunk (svn r 7503).
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on October 21, 2011, 12:43:13 pm
Hm, Jens, is moving a tab with the mousewheel still working?
It doesn't for me. CentOS 5.6, debugger branch 7509.
Title: Re: Request : C::B View::notebook enhancements
Post by: Jenna on October 21, 2011, 05:00:36 pm
Hm, Jens, is moving a tab with the mousewheel still working?
It doesn't for me. CentOS 5.6, debugger branch 7509.
No, does not work here either.

I did not change anything related to it.
I will look into it.


It still works, sorry.
I tried it in my "Logs & others", but the amount of tabs I have open fits into it exactly, so nothing happens and I just thought, that it is broken.
Title: Re: Request : C::B View::notebook enhancements
Post by: oBFusCATed on October 24, 2011, 10:01:06 pm
Hm, It works on my gentoo, but doesn't on the centos, I'll check tomorrow again.

On the centos another problem I see is that when I have tabs side by side and I open a new file,
the tab is added to the first notebook, not the active one. And again it works on my gentoo :(
I hate 'stable' distros :(