Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => CodeCompletion redesign => Topic started by: ollydbg on August 31, 2012, 03:49:45 am

Title: variable/type name question
Post by: ollydbg on August 31, 2012, 03:49:45 am
Code
    // pair of current-file-filter
    TokenFilesSet    m_CurrentFileSet;
    TokenIdxSet      m_CurrentTokenSet;
    TokenIdxSet      m_CurrentGlobalTokensSet;

and:
Code
for (TokenFilesSet::const_iterator itf = m_CurrentFileSet.begin(); itf != m_CurrentFileSet.end(); ++itf)

See, we have XXXXsSet or XXXXSet?
I think we should choose one kind of name theme for all the source files.

EDIT:
Just query on Google, like:

"fileVector" filetype:cpp   -> 1440 results
"filesVector" filetype:cpp -> 75 results

"threadpool" filetype:cpp -> 23600 results
"threadspool" filetype:cpp  -> 10 results

Compare the other similar result, we should use XXXXSet, right?
 

Title: Re: variable/type name question
Post by: MortenMacFly on August 31, 2012, 06:20:27 am
Compare the other similar result, we should use XXXXSet, right?
Yes.
Title: Re: variable/type name question
Post by: ollydbg on August 31, 2012, 06:44:51 am
Compare the other similar result, we should use XXXXSet, right?
Yes.
OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".
Title: Re: variable/type name question
Post by: MortenMacFly on August 31, 2012, 11:07:24 am
OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".
Oh dear... some more effort... but yes.
Title: Re: variable/type name question
Post by: ollydbg on September 06, 2012, 03:49:44 pm
OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".
Oh dear... some more effort... but yes.
I did a lot of names change in rev 8364, please help to change the file names. That may change the makefiles also which I don't familiar. Thanks.
Title: Re: variable/type name question
Post by: MortenMacFly on September 06, 2012, 04:27:26 pm
I did a lot of names change in rev 8364, please help to change the file names.
...should be done in SVN trunk.
Title: Re: variable/type name question
Post by: ollydbg on September 07, 2012, 02:57:12 am
I did a lot of names change in rev 8364, please help to change the file names.
...should be done in SVN trunk.
Thanks.