So the best is probably to turn it off for now, and perhaps try again later with wx 2.7.x ?Yes, I actually turn it off now; for wx 2.7 CoreGraphics is enabled by default, and there's a chance that QuickDraw will be deprecated, so better we wait.
#if 0 // defined(__WXMAC__)
#define CBSPLASH_SHAPED 1
#define CBSPLASH_STYLE wxFRAME_SHAPED
#define CBSPLASH_ALPHA 0
#else
#define CBSPLASH_SHAPED 0
#define CBSPLASH_STYLE 0
#define CBSPLASH_ALPHA 1
#endif
Here were the end results, when using SHAPED=1 (wxFRAME_SHAPED)Hey, that doesn't even look entirely bad! Different, yes... but not really bad. If one added a bit more border on the left and top-left to the image, it would look like it's actually intended to be that way (though I doubt it's worth the effort). What do you think, should I have a try?
ALPHA=0 (i.e. using a white color)
Here were the end results, when using SHAPED=1 (wxFRAME_SHAPED)Hey, that doesn't even look entirely bad! Different, yes... but not really bad. If one added a bit more border on the left and top-left to the image, it would look like it's actually intended to be that way (though I doubt it's worth the effort). What do you think, should I have a try?
ALPHA=0 (i.e. using a white color)
Why don't you just commit it that way and leave it until they update wxMAC :)
Although I like the new design of the splash screen, is it really supposed to look like that? :DWhat the hell, I replied to your post 10 minutes ago, where did it go???
Testet on Linux with wxGTK 2.6.2, gcc 4.1.1 and revision, well, you probably can see that. :PLol, was about to ask "what version" :)
It looks sorta like that in the about dialog on Windows....... :PYes, but that's unrelated.
Could you give it a try please? If nothing helps, one could GetHandle() on the window and use GTK's native function to apply the region. However, it might be that SetBackgroundStyle() in line 121, which used to be the "GTK enabling hack" is the actual cause of this. Or, one might skip OnEraseBackground() entirely, maybe that grey is really some background drawing (which, for some reason draws outside the region?).I will have a look at it. Let's hope I find something usefull ;)
Index: src/src/splashscreen.cpp
===================================================================
--- src/src/splashscreen.cpp (revision 3230)
+++ src/src/splashscreen.cpp (working copy)
@@ -22,7 +22,7 @@
static const wxString release(wxT(RELEASE));
static const wxString revision(wxT(SVN_REVISION));
- dc.SetClippingRegion(r);
+ dc.DestroyClippingRegion();
dc.DrawBitmap(m_label, 0, 0, false);
wxFont largeFont(16, wxSWISS, wxFONTSTYLE_NORMAL, wxFONTWEIGHT_BOLD);
Got it! :DThomas: Is this also something we had forgotten to test for the about dialog??? Should I start over again and loose another 3 hours? ;-)
Got it! :DGreat, thank you :)
Here is the patch that works for me:
Another strange thing is that SetRegion always returns FALSE here, even with a simple rectangular region. Seems as wxGTK does not implement this function. (As the documentation says, it only works if the platform supports it.)Isn't that what Window::shape_combine_region does?
Thomas: Is this also something we had forgotten to test for the about dialog??? Should I start over again and loose another 3 hours? ;-)No, that's a different issue, I think. Why don't you just commit the version you had which worked (without all the double-buffering and stuff). We can always add the overlay stacking another control onto it later (less work).
With regards, Morten.
Why don't you just commit the version you had which worked (without all the double-buffering and stuff).Well... erm... because did that already some days ago?! ;-) Anyway: The version that "worked" was nothing else than changing the XRC and pointing to the other image in the code. Everything else I tried didn't work. As soon as I used wxMemoryDC and consorts I ran into trouble.
Hmm... instead of destroying the clip region right after creating one, shouldn't it work to never create one, too? I'll try that approach (so, only use clip for Windows). Please complain if it doesn't work nicely. :)Just tested with revision 3234 and it seems to work as it should. :)
t's drawn with a black background, so it looks a little "grey". Maybe clear to white first ?Yes, please do :)
It's centered against the parent window in the Finder, and not against the entire screen...Does it matter so much? I figure center on screen is similarly nasty to do as on other platforms... but if you can fix it, sure :)
Does it matter so much?