Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Contributions to C::B => Topic started by: gd_on on March 06, 2020, 10:53:20 am

Title: Patch for wxsglcanvas
Post by: gd_on on March 06, 2020, 10:53:20 am
I propose a patch in ticket 925 to add the possibility to activate multisample mode in wxSmith/wxsglcanvas. It is conditionnaly added/compiled if wxwidgets version is >= 3.0.0 because these possibilties (keywords) were not here before.
gd_on
Title: Re: Patch for wxsglcanvas
Post by: stahta01 on March 06, 2020, 10:58:50 am
Please disable the tidy comment plugin and recreate patch without the comment changes it does.

Edit: Example changes not wanted
Code
-//------------------------------------------------------------------------------
+//----  --------------------------------------------------------------------------------------------------------

Tim S.
Title: Re: Patch for wxsglcanvas
Post by: gd_on on March 06, 2020, 11:25:30 am
OK. Patch modified. I hope that's what you wanted.
Title: Re: Patch for wxsglcanvas
Post by: BlueHazzard on March 06, 2020, 12:20:24 pm

Side note:
i am tired of all this #if version checking...
My proposal is to introduce a wxSmith setting, that stores the (minimal) wxWidgets version this project supports and then we check (for new code commits) in the code generation how the code has to be generated, according to this setting. Maybe we can even store this setting in the code itself?
Title: Re: Patch for wxsglcanvas
Post by: oBFusCATed on March 07, 2020, 12:36:55 am
Patches welcome. Soon we will drop 2.8 support anyway...