Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: 280Z28 on December 16, 2005, 06:31:47 am

Title: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 06:31:47 am
Bugs from sourceforge I've fixed tonight:

Find dialog box previous search ordering (http://sourceforge.net/tracker/index.php?func=detail&aid=1382097&group_id=126998&atid=707416)
Project tree shows unmodified file as modified (http://sourceforge.net/tracker/index.php?func=detail&aid=1381831&group_id=126998&atid=707416)
prints only first page of a multipage file (http://sourceforge.net/tracker/index.php?func=detail&aid=1380328&group_id=126998&atid=707416)
Printout prints only first page (http://sourceforge.net/tracker/index.php?func=detail&aid=1334845&group_id=126998&atid=707416) (duplicate)
Can only print on the default printer (http://sourceforge.net/tracker/index.php?func=detail&aid=1281191&group_id=126998&atid=707416)
Check for file modifications crashes C::B (http://sourceforge.net/tracker/index.php?func=detail&aid=1382155&group_id=126998&atid=707416)

Bugs not on sourceforge I've fixed tonight:
* Print dialog always defaulted to print active selection, even when there was no selection. Now defaults to current editor if there is no selection
* Multi-monitor dialog positioning bug (http://forums.codeblocks.org/index.php?topic=1640.0) (this isn't perfect because there are bugs related to this in the wxWidgets dll itself)
Title: Re: haha I'm on a roll tonight
Post by: takeshi miya on December 16, 2005, 06:38:44 am
Amazing 8)
Title: Re: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 06:39:51 am
Now if only the admins were around to commit the changes  :lol:
Title: Re: haha I'm on a roll tonight
Post by: killerbot on December 16, 2005, 07:33:50 am
Any CB dev, please do check Sam's fixes and use them if they are ok. I think he's doing some marvellous work.
Totally excited about the printing bugs fixed. This is very important, using an IDE where you need to switch to another program to print might make it for some users hard to switch to CB.

Lieven
Title: Re: haha I'm on a roll tonight
Post by: yop on December 16, 2005, 09:08:14 am
Now if only the admins were around to commit the changes  :lol:
Don't worry, it generally takes some time for the patches to be applied (especially now with the sdk changes) but the devs always appreciate the community's work.
BTW great job  :shock: (you were on a roll (last?)night :))
Title: Re: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 10:15:03 am
Just finished this one and now I'm going to bed. Good night y'all, I'll talk with the admins tomorrow when we're all awake regarding getting these patches in.

crc not getting updated properly (http://sourceforge.net/tracker/index.php?func=detail&aid=1382103&group_id=126998&atid=707416)
Title: Re: haha I'm on a roll tonight
Post by: Michael on December 16, 2005, 11:02:56 am
Bugs from sourceforge I've fixed tonight:

Find dialog box previous search ordering (http://sourceforge.net/tracker/index.php?func=detail&aid=1382097&group_id=126998&atid=707416)
Project tree shows unmodified file as modified (http://sourceforge.net/tracker/index.php?func=detail&aid=1381831&group_id=126998&atid=707416)
prints only first page of a multipage file (http://sourceforge.net/tracker/index.php?func=detail&aid=1380328&group_id=126998&atid=707416)
Printout prints only first page (http://sourceforge.net/tracker/index.php?func=detail&aid=1334845&group_id=126998&atid=707416) (duplicate)
Can only print on the default printer (http://sourceforge.net/tracker/index.php?func=detail&aid=1281191&group_id=126998&atid=707416)
Check for file modifications crashes C::B (http://sourceforge.net/tracker/index.php?func=detail&aid=1382155&group_id=126998&atid=707416)

Bugs not on sourceforge I've fixed tonight:
* Print dialog always defaulted to print active selection, even when there was no selection. Now defaults to current editor if there is no selection
* Multi-monitor dialog positioning bug (http://forums.codeblocks.org/index.php?topic=1640.0) (this isn't perfect because there are bugs related to this in the wxWidgets dll itself)

Very good job :). Did you sleep in the night :D?

Michael
Title: Re: haha I'm on a roll tonight
Post by: MortenMacFly on December 16, 2005, 02:25:38 pm
Bugs from sourceforge I've fixed tonight:
...could you provide the patch to public within this thread as an attachment? This way other users could already apply the patch to verify it works and (if so) have more C::B fun... :lol:

To announce that you've done good work is nice, but including the patch is nicer... :P

Morten.
Title: Re: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 03:35:41 pm
Bugs from sourceforge I've fixed tonight:
...could you provide the patch to public within this thread as an attachment? This way other users could already apply the patch to verify it works and (if so) have more C::B fun... :lol:

To announce that you've done good work is nice, but including the patch is nicer... :P

Morten.


I like to go one step at a time. Here's why: I made changes in a lot of files. Before I submitted the first file, I looked at side by side diffs of every single one to check my work and by glad with the way it was done. Once it's committed and I do an svn update, I will merge my changes for exactly one more bug back into the source code (well maybe I'll get all the print issues at once, but I'll stay related). At each step, before I make a patch, I really need to look at what I did.

In particular, the Unicode fix might have some errors, so I'm probably going to take an evening (Sunday) to check it. And I'll probably fix TinyXML at the same time to bring back full Unicode support. If I give out the full patch now as a single file, it's likely to come back with a "hey, what happened here?!" Stuff happens... it was late, etc... gotta check my work.

Oh yeah I slept I just woke up :D
Title: Re: haha I'm on a roll tonight
Post by: tiwag on December 16, 2005, 03:51:48 pm
is there any patch available for test now ? where are they ? please provide some links.

thanks
Title: Re: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 03:57:50 pm
is there any patch available for test now ? where are they ? please provide some links.

thanks

Only one, the dialog positioning bug, my last post in that thread has it attached.

That patch changed just a single line, but in soooo many files that when I look at TortoiseSVN's list of files that were modified, it's impossible to isolate my small work on other bugs to check it. Once that one is committed and I check out a new copy, I can merge my other changes and the patch will be much smaller.

Some of the fixes literally changed just a couple lines... finding those in a diff of 50 files is a waste of time knowing that today (maybe by the time I get to work?) I'll be able to svn update and it'll show very quickly which single file got the update.
Title: Re: haha I'm on a roll tonight
Post by: rickg22 on December 16, 2005, 05:12:50 pm
280Z28: Please submit the patches at sourceforge. I mean, it's fine if you update SVN before submitting, but it's better to submit a patch even if it's 1 or 2 days old, than not submitting anything.
Title: Re: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 05:21:59 pm
280Z28: Please submit the patches at sourceforge. I mean, it's fine if you update SVN before submitting, but it's better to submit a patch even if it's 1 or 2 days old, than not submitting anything.

I can't easily separate the smaller patches until the one for the dialogs goes in. After that one is committed I can post the rest. :)
Title: Re: haha I'm on a roll tonight
Post by: rickg22 on December 16, 2005, 05:23:13 pm
Submit a single patch then. Say: "It requires my other (link) patch"
Title: Re: haha I'm on a roll tonight
Post by: 280Z28 on December 16, 2005, 05:53:36 pm
Submit a single patch then. Say: "It requires my other (link) patch"

Meh, I prefer to wait until I can isolate and review things and not feel like I might have submitted garbage. It would be very not fun to have my one of my first "contributions" to the project being something that breaks things. :)
Title: Re: haha I'm on a roll tonight
Post by: rickg22 on December 16, 2005, 08:26:40 pm
280: Generally patches are not applied automatically. Someone reviews them, sees what they do, and changes the corresponding lines MANUALLY. This is why we need your patch, to see what it does. Later you can upload a later version.