Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!
Recent Posts
#include "sdk.h" // Code::Blocks SDK
#include "configurationpanel.h"
#include "cbstyledtextctrl.h"
#include "logmanager.h"
#include "projectmanager.h"
#include "editormanager.h"
#include "cbeditor.h"
trunk/src/plugins/contrib/BrowseTracker/JumpTracker.cpp:1313:9: error: 'LogSlot' was not declared in this scope
1313 | LogSlot& logslot = pLogMgr->Slot(logIndex);
| ^~~~~~~
Should my include statement use quotes instead of <> brackets?Yes, you are right. Its a project header, not a system header. Is is not done consistently in cb and the plugins though.
Those variables were actually initialized, but the code got smushed without white space so that cppcheck didn't recognize it.Maybe in this case. I did not look it up before posting. Nevertheless there are numerous bad examples still in cb-code. As for BrowseSelector: The two ctors leave parts uninitialized and do not delegate. The default ctor is marked private, implemented but the comment says it is unused. I prefer code that does not pose additional puzzles. If a tool has already spotted an issue and it is not a false positive. Then why should I fire up the debugger and search for spurious errors due to UB.
I re-formated it to cppcheck taste.
--inline-suppr --suppress=missingIncludeSystemHi Pecan,I don't understand this, logmanager.h is an sdk header, not a BrowseTracker header. It's included in trunk\src\include\Makefile.am Should my include statement use quotes instead of <> brackets?
thank you for the effort.
With the last patch (svn13671 BrowseTracker Move ... ) I get a compile error when building on Linux with make. An include is missing:Code#include <logmanager.h>
Hi Pecan,I don't understand this, logmanager.h is an sdk header, not a BrowseTracker header. It's included in trunk\src\include\Makefile.am Should my include statement use quotes instead of <> brackets?
thank you for the effort.
With the last patch (svn13671 BrowseTracker Move ... ) I get a compile error when building on Linux with make. An include is missing:Code#include <logmanager.h>
When scrolling very briefly through the diff I noticed a function with a suspiciously empty if statement. It looks like unintentional semantics:I had removed some old code. I added a comment to make it clearer. But cppcheck won't like it anyway.Codevoid JumpTracker::OnLeftUp(wxMouseEvent& event) {
if (m_leftDown && (not m_isDragging)) {
// Pure click (no drag) occurred
}
m_leftDown = m_isDragging = false;
event.Skip();
}
When I run CppCheck over the BrowseTracker cb-project, I get several warnings. E.g.:QuoteBrowseTrackerLayout.cpp:173:41: warning: Either the condition 'cursor' is redundant or there is possible null pointer dereference: cursor. [nullPointerRedundantCheck]
TiXmlElement* browsemarks = cursor->NextSiblingElement("BrowseMarks");
^
BrowseTrackerLayout.cpp:155:17: note: Assuming that condition 'cursor' is not redundant
if (cursor)
^
BrowseTrackerLayout.cpp:173:41: note: Null pointer dereference
TiXmlElement* browsemarks = cursor->NextSiblingElement("BrowseMarks");
^
orQuoteBrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_pBrowseTracker' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_menuID' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_KeyDownCode' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_KeyDownMods' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
Besides other warnings.
Since the topic-starter observed a crash, these should be fixed.
Have a nice day.
#include <logmanager.h>void JumpTracker::OnLeftUp(wxMouseEvent& event) {
if (m_leftDown && (not m_isDragging)) {
// Pure click (no drag) occurred
}
m_leftDown = m_isDragging = false;
event.Skip();
}
BrowseTrackerLayout.cpp:173:41: warning: Either the condition 'cursor' is redundant or there is possible null pointer dereference: cursor. [nullPointerRedundantCheck]
TiXmlElement* browsemarks = cursor->NextSiblingElement("BrowseMarks");
^
BrowseTrackerLayout.cpp:155:17: note: Assuming that condition 'cursor' is not redundant
if (cursor)
^
BrowseTrackerLayout.cpp:173:41: note: Null pointer dereference
TiXmlElement* browsemarks = cursor->NextSiblingElement("BrowseMarks");
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_pBrowseTracker' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_menuID' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_KeyDownCode' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^
BrowseSelector.cpp:93:17: warning: Member variable 'BrowseSelector::m_KeyDownMods' is not initialized in the constructor. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior. [uninitMemberVarPrivate]
BrowseSelector::BrowseSelector()
^