Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

ThreadSearch layout modification

<< < (3/5) > >>

ollydbg:
It was applied in the trunk 5489.

By the way.
I have built the SVN 5489 in Windows. It seems the threadSearch can't open main.cpp file (it is encoded in UTF-8 without BOM)

I have to convert to ANSI, then threadSearch can search again.

gd_on:
Small problem with this update 5489. It does not include the patches proposed by Xaviou here to be able to translate in other languages the different items of this plugin. Some wxT have to be replaced by _.

gd_on

yesno:
Hello,

first, the layout modification is fine now, but there are missing two modifications, both in ThreadSearch.cpp and each one line.

The first is
--- Code: ---in line 79 (rev. 5808):
replace
EVT_BUTTON (idBtnOptions, ThreadSearch::OnBtnOptionsClick)
by
EVT_TOOL (idBtnOptions, ThreadSearch::OnBtnOptionsClick)
--- End code ---
because the options button from the toolbar is no more a button but a tool and without this modification nothing would happen.

The second one is
--- Code: ---in line 632 :
replace
m_pThreadSearchView->ProcessEvent(event);
by
m_pThreadSearchView->OnBtnOptionsClick(event);
--- End code ---
This is necessary to prevent the event handler from being recursive (leading to a stack overflow leading to a crash)

With kind regards

ironhead:
Thank you yesno for the patch.

I've discovered another issue in that when executing a search, the options icon reverses it's colour and anything to the right of the ThreadSearch toolbar gets corrupted (i.e. it disappears).  If I move the ThreadSearch toolbar I'm able to see toolbars to the right of it once more.

I'm running Windows XP Pro with C::B compiled with MinGW GCC 4.4.0.

yesno:
Hello,

As for the colour reversion of the options button - regardles the toolbar or the logwindow search button is pushed - : don't know the reason. Maybe an issue of wxMSW, Wind0ws or the button image.

The second issue can half be solved easily:
Insert after the line 740 in ThreadSearchView.cpp (rev. 5813):

--- Code: ---m_pToolBar->Update();
--- End code ---

The contents of the other toolbars reappear, the dots on the left side don't.

With kind regards

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version