Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Improvement of custom makefiles - patch to test

<< < (3/4) > >>

Jenna:
Another day, another patch.

This one takes care of compile logging settings (Full commandline etc.) as good as possible.

Therefore I added another command on the build options "Make" commands tab.

I also hide the distclean command, because it is not used as far as I see.

[attachment deleted by admin]

grischka:
Nice.  Two notes:
- Clean doesn't print the make command.
- The code below is maybe not what you want:

--- Code: --- case bsProjectPreBuild: return bsTargetPreBuild;
{
if (clean && !build)
{
return bsTargetClean;
}
return bsTargetPreBuild;
}

--- End code ---

Jenna:

--- Quote from: grischka on January 23, 2009, 10:21:34 pm ---Nice.  Two notes:
- Clean doesn't print the make command.
- The code below is maybe not what you want:

--- Code: --- case bsProjectPreBuild: return bsTargetPreBuild;
{
if (clean && !build)
{
return bsTargetClean;
}
return bsTargetPreBuild;
}

--- End code ---


--- End quote ---

You are right, the code inside the curly braces is never reached, and is not needed at all.

Thanks for pointing it out.

If there are no objections from the other devs, I will apply the patch the next days, most likely tomorrow.

MortenMacFly:

--- Quote from: jens on January 27, 2009, 12:11:33 am ---If there are no objections from the other devs, I will apply the patch the next days, most likely tomorrow.

--- End quote ---
As I said: No issues here - looks fine. I'd close the patch in the patch tracker afterwards...

Jenna:
Committed !

SVN revision 5421

Navigation

[0] Message Index

[#] Next page

[*] Previous page