Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

GCC 4.3 Warnings

<< < (3/3)

thomas:

--- Quote from: rhf on January 19, 2009, 06:52:05 pm ---The precedence rules are clear enough, but the indentations make me wonder if the programmer intended something else.
--- End quote ---
We will never know, but seeing that this is part of tinyxml which works just fine, it at least appears that it is probably what was intended.
I didn't mean to criticise your patch or imply that you don't know the precedence rules. :) What I'm saying is that I perceive those "suggest parenthese" warnings as quite silly, as I'm getting one or two of them in my own code every day, and unlike most other warnings (which are useful) it has never pointed to an actual ambiguity or typo, it has only ever added noise. Such as in having to turn while(foo = *bar) into while((foo = *bar)) only to make the compiler happy.

thomas:
Forgot to say: You should forward this patch (the last version) to the tinyxml team so it can be reviewed and possibly applied upstream.

Tampering with third party code can have undesirable effects, as history has proven. It's never a mistake to communicate with the guy who wrote the package initially. Not only does that make the possibility of a regression due to misinterpretation less likely, but also it will let the entire user base profit from the patch if it is accepted.

killerbot:
don't worry, I will communicate to Lee, I send him some suggestions/changes from time to time.

Navigation

[0] Message Index

[*] Previous page