Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Change bar feature in scintilla
Jenna:
--- Quote from: MortenMacFly on November 18, 2008, 01:52:30 pm ---
--- Quote from: jens on November 18, 2008, 12:30:42 pm ---It's a good idea, but should be changed for linenumber-, and error/bookmark/debugmark-margin too.
--- End quote ---
I have done that already (for all!)... including the adjustment you missed. So hopefully it does not get lost.
My proposal of what to do next:
1.) Merge scintilla into trunk (it should be safe now, but we need to talk to Yiannis before)
2.) Apply marker changes to scintilla branch (so we re-use that one... ;-)) -> I can do it, I should have all we need.
3.) Do dome more testing and probably apply it after some more feedback of the other devs.
I personally like the feature quite much. But I am also aware that we break scintilla compatibility a little. Hence it gives more than it takes IMHO... what about the others?!
--- End quote ---
I also think, that we can merge (or better you can, I have to work outside the today and tomorrow, to tune some parameters of a control, and have no access to my linux at the moment, because I have to use windows for programming :cry: ).
About the changebars: as written before it would be nice if the user can switch them off and to clear the history. It should not be to difficult I hope. Maybe I find some time this evening at the hotel.
mariocup:
Hi Martin,
I will try the patch in the end of the week under windows and linux and will give you some feedback. I think these is a really nice feature and if it is stable enough there should be the interest of the scintilla team to integrate it. Are you in contact with some scintilla devs and are they aware of this patch?
Bye,
Mario
MortenMacFly:
--- Quote from: mariocup on November 18, 2008, 02:23:32 pm ---Are you in contact with some scintilla devs and are they aware of this patch?
--- End quote ---
I don't know. But read further in the thread. I think gryphon (the author) said something they won't apply it... better you ask him.
Jenna:
I just updated my patch and improved it a little bit:
* the user can select from the editor configuration dialog, whether to use changebar or not
* the history of the active editor can be deleted via main- or context-menu
If the changebar will be switched off globally, the undo-history will not be touched, but if it will be switched on, the undo-history of all editors will be deleted, because we otherwise get inconsistencies between both collections.
Because of the problem with the inconsistent collections, I decided to delete the whole history at once (undo- and changebar).
The patch can be downloaded from http://apt.jenslody.de/patches/scintilla_changebar_20081120-2.patch .
It's created against the scintilla-branch r5318.
I did not (yet) test it under windows.
mariocup:
Hi Jens,
I did not try the changebar feature, therefore I have some questions:
1. Where is the changebar history stored in CB? Will this history be cleared when I close the file?
2. Is every changebar saved in a local history?
3. What would be cool to have same navigation feature like in a diff program (e.g. kdiff3) to jump to the next and previous difference/changebar.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version