Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Change bar feature in scintilla

<< < (3/7) > >>

Jenna:

--- Quote from: gryphon on November 15, 2008, 11:21:25 pm ---Yeah, I think that's true. I've only begun digging deeper into the scintilla code today so haven't really got a feel yet of how to do that. I guess I should start by diff'ing against 1.7.7 to get a feel for how invasive the changebar patch actually is.

--- End quote ---

You can either do that or download the patch from my server, it's a patch against 1.7.7 (used for C::B's new-scintilla-branch).
Your patch is against trunk and the scintilla used there is an 1.6.x-version as far as I know, so there are many, many differences, for example to the lexers, that should not be needed for the change bar.

You can download C::B with scintilla 1.7.7, which is not (yet) in trunk with svn from 
--- Code: ---svn://svn.berlios.de/codeblocks/branches/scintilla
--- End code ---
it should work on linux and windows and will soon (?) be merged with trunk. The scintilla-branch is uptodate, and contains some smal improvements, due to newer (better) indicatiors (used for "Highlight occurrences" and "Incremental Search").

One cause I worked with the newer scintilla is because it will most likely be committed to trunk the next time (no exact timeline, but no problems so far).

MortenMacFly:

--- Quote from: jens on November 15, 2008, 08:42:49 pm ---I'm not sure if I should commit it to the scintilla-branch, because I did (could) not test it much.

--- End quote ---
Please don't atm. We can do it in another branch later. :-)

mariocup:

--- Quote ---But I guess the own margin is better. And it's a good idea to place it at last, because I sometimes have the same problem then you (folding instead of marking text).

--- End quote ---

I know that problem folding instead of marking text. Therefore I use the following workaround: If you enable the display of line numbers you can select lines by clicking with the mouse button in the left margin next to the displayed line numbers and then it won't happen that you select a folding point.

MortenMacFly:

--- Quote from: jens on November 15, 2008, 08:42:49 pm ---I uploaded it to my server ( http://apt.jenslody.de/patches/scintilla_changebar.patch ).

--- End quote ---
This does not work for me at all. Either "patch" crashes "unexpectedly" or it fails patching ~80% of the hunks.
Can you try to create the patch again, please?!

Jenna:

--- Quote from: MortenMacFly on November 17, 2008, 03:48:14 pm ---
--- Quote from: jens on November 15, 2008, 08:42:49 pm ---I uploaded it to my server ( http://apt.jenslody.de/patches/scintilla_changebar.patch ).

--- End quote ---
This does not work for me at all. Either "patch" crashes "unexpectedly" or it fails patching ~80% of the hunks.
Can you try to create the patch again, please?!

--- End quote ---

Hi Martin,

try http://apt.jenslody.de/patches/scintilla_changebar_new.patch, that should work.
The other patch only applies if you ignore changes to whitespace. I don't know why. It's created with "svn diff", and the newer one with the diff-tool from commandline.

The new patch is slightly modified compared to the first one (using an own margin for the changebar).

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version