Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Patch #1
AlekseyT:
Is any of this patches is applied?
MortenMacFly:
--- Quote from: AlekseyT on March 13, 2008, 03:16:11 pm ---Is any of this patches is applied?
--- End quote ---
No. This is what makes me refusing it currently:
--- Code: ---SelectTargetDlg::SelectTargetDlg(wxWindow* parent, cbProject* project, int selected)
: m_Selected(-1), m_pProject(project)
--- End code ---
You ignore the usage of the explicitly provided "selected" variable in the constructor. Thus this interface is broken. We cannot leave it like that.
AlekseyT:
Ok. I change "select choice" in src/src/app.cpp[672-683] and after put new patch. And what about other two patch?
MortenMacFly:
--- Quote from: AlekseyT on March 06, 2008, 06:56:32 am ---In most case (~95%) when user add new file or class to project he want add it to all targets.
--- End quote ---
This is simply not true. Take the C::B project itself as an example. You definitely do *not* want new files to all targets. What you say is usually true for users coming from the MS VS world. But definitely not for the majority. So my personal feeling is: Post this at BerliOS so that everybody who feels like needing this feature can add it, but I wouldn't add it to C::B generally. The big boss would definitely kill me if I do so.
...the other patch I haven't tried yet...
thomas:
--- Quote from: AlekseyT on March 06, 2008, 06:56:32 am ---In most case (~95%) when user add new file or class to project he want add it to all targets.
--- End quote ---
Funny, I never wanted that... must be that I'm still in the 5% that are left over.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version