Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

lgplv3-comment breaks autorevision when used with ./configure ...

<< < (2/3) > >>

Jenna:
As I wrote above the comment with the lgplv3 notice exists in autorevision.h.in.
It came in in svn4910 by Morten.

The .in is needed to generate the autorevision.h when running ./configure.
in the .in there are two "variables" that get replaced with the actual svn-revision and date.

The Makefile in the autorevision-subdir first creates the auto_revision-executable and then runs it.

auto_revision checks the version-number in the block-comment in the first line in autorevision.h.
And if it is not satisfied it creates a new one.

The only thing I wrote, is that the version-number should be in the first line. I have a patch that gets automatically applied when building my deb-binaries, so it's no problem for me, after I figured it out.

Nevertheless the placement of the comment breaks the function of autorevision if it is used in a none-svn subdir.

I didn't place the lgplv3-comment in the in-file, but afaik: all header and cpp files are switched to gplv3 ore lgplv3.

If it is not possible to change it without a bug-report, I will file one.

To repair the bug is quite easy, either the comment is totally removed, or placed after the variable to b substituted.
I don't know where the problem is to understand this.

I have an ill child at home, and therefore did not sleep much last night. I feel really bad today, cause I get ill myself.

I spent much to much time in writing redundant posts about the same issue.

I don't want to talk about this problem any more.

Sorry, if my words are too hard.

thomas:

--- Quote from: jens on March 02, 2008, 03:46:25 pm ---To repair the bug is quite easy, either the comment is totally removed, or placed after the variable to b substituted.
I don't know where the problem is to understand this.
--- End quote ---
This is exactly what I said, but I object to patching autorevision.cpp as you suggested.

afb:
I think the header snuck in by accident in the GPL upgrade just before release,
so the fix is just reverting autorevision.h.in to match the expected header style...

afb:
Fixed in r4926, removed GPL boilerplate and added comment to match the other autorevision.h.

afb:

--- Quote from: jens on March 02, 2008, 03:46:25 pm ---I have a patch that gets automatically applied when building my deb-binaries, so it's no problem for me, after I figured it out.
--- End quote ---

Fedora packaging also has such a patch, so it seems the plan to fix autorevision when svn is not available (such as when building from a tarball) by using autoconf has somewhat failed - those paches shouldn't be needed.

Navigation

[0] Message Index

[#] Next page

[*] Previous page