Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

ThreadSearch-plugin uses cbMessageBox from inside thread

(1/2) > >>

Jenna:
I found another issue in ThreadSearch-plugin when I searched into C::B projectfile on Linux.
The project includes some .ico-files which could not be opened by wxTextFile.
If that happens a cbMessageBox with en error-message is shown.
This works sometimes, but sometimes hangs or crashes C::B.
This happens because the MessageBoxes are shown from inside the Thread what is not allowed.
I patched the plugin not to directly show the error-message, but send an error-event that can be handled outside the thread.

The patch has a size of about 13 kb, so I attached it as 7.z-file.

@dje
It is a Linux diff-file.
If you need a patch-file for Tortoise-svn I can try to create one.

Edit:
I removed the attached patch, because it has two missing "break"s and does not work properly on Windows.
A newer version (this time for Tortoise-SVN) is attached to a later post.

dje:
Thanks again Jens !
I missed that point...  :oops:


--- Quote from: jens on February 03, 2008, 02:06:26 pm ---It is a Linux diff-file.
If you need a patch-file for Tortoise-svn I can try to create one.

--- End quote ---
I'll try without ! It seems that TortoiseSVN accept both extensions.

Dje

dje:
Hi Jens !

I can't apply the patch. The error message I get from TortoiseSVN is :

--- Code: ---The line "Index: " was not found!
Either it is not a diff file or the diff is empty.
--- End code ---


--- Quote ---If you need a patch-file for Tortoise-svn I can try to create one.
--- End quote ---
Could you pease generate this file ?

Dje

Jenna:

--- Quote from: dje on February 04, 2008, 08:57:49 pm ---Hi Jens !

I can't apply the patch. The error message I get from TortoiseSVN is :

--- Code: ---The line "Index: " was not found!
Either it is not a diff file or the diff is empty.
--- End code ---


--- Quote ---If you need a patch-file for Tortoise-svn I can try to create one.
--- End quote ---
Could you pease generate this file ?

Dje

--- End quote ---

Hi dje,

sorry it took a little more time, then I expected, but after copying the patched files to my virtual W2K and creating the Tortoise-SVN patch file, I tested the code on Windows and ... it doesn't work as expected.
Many windows with the same error message popped up.
So I patched my patch, and now it works on Windows and Linux (tested on debian unstable 64-bit and W2K on virtual 32-bit with kvm).

The new patch (for Tortoise-SVN) is attached to this post.

[attachment deleted by admin]

dje:
Thanks !

I'll build apply tonight (in France) !

Dje

Navigation

[0] Message Index

[#] Next page