Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Batch builds currently broken in SVN

<< < (3/3)

thomas:

--- Quote ---my biggest question is, where can we start to fix this ?
Regarding from things good or bad; they have worked, and now it crashes. Why can I crash now, and how to fix this ?
--- End quote ---
That's exactly the problem, I don't know where to start. There is actually no reason why it could/should crash.
You cannot delete Loggers in an unsafe way, the API only lets you delete a Logger by replacing it with a NullLogger. So, there is never an invalid pointer, only a pointer to an object that does nothing.
Thus, the only thing that can be the "reason" for a crash is the wxTextCtrl, but this one is owned by the window (which deletes it when the window closes, at which time that's a legal thing to do). This actually cannot crash either, except if something/someone logs to the compiler log after the batch window has been closed (or worse: writes to the wxTextCtrl directly... ouch). Although there is no reason why this should happen, it could be prevented for good by deleting the Logger when the build has finished, since that will severe the link to the wxTextCtrl.


--- Quote ---- the compiler output is not visible, where this use to work in the past (why is that windows plain grey now)
--- End quote ---
One easy and obvious reason could be "window is not getting update events". That is because it works just fine once you resize the window. The control is definitively there, and it sure logs everything as it should. Only for some reason the window never paints it.
Maybe the window needs to get an update event or a show event or something... though this should normally work just by calling Show() and doing nothing else? Maybe you have to wxYield() once to give the message pump a chance to run... no idea.


--- Quote ---- the whole thing crashes
--- End quote ---
Does not happen here. Did not have it happen a single time trying 20 times.
Although Martin seems to have fixed it with this if(control), the real reason may be a different one. Since you have the crash and I don't, and the major difference between our systems is that I do not use anything but core, there is a chance that a third-party plugin causes it (not sure which ones are loaded for batch builds at all). Can you test if it still occurs after you disable them all?

killerbot:
in rev 4750 our big boss fixed it  :D :D :D

Navigation

[0] Message Index

[*] Previous page