Author Topic: sdk/editorcolour.cpp patch (rev.4632). Crash on startup.  (Read 5065 times)

Offline kisoft

  • Almost regular
  • **
  • Posts: 194
sdk/editorcolour.cpp patch (rev.4632). Crash on startup.
« on: November 15, 2007, 10:24:50 am »
I submit patch to BerliOS. SVN rev.4032 crash on startup without this patch.
http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=2243&group_id=5358
Piece of code from this patch for explains:
Code
-        Manager::Get()->GetLogManager()->Log(_("Found %d lexers"), count);
+        Manager::Get()->GetLogManager()->Log(F(_("Found %d lexers"), count));
MinGW 3.4.5
wxWidgets 2.8.6
Now C::B worked succesfully.
« Last Edit: November 15, 2007, 02:45:42 pm by kisoft »
OS: WinXPSP3
wxWidgets: 2.8.12
CodeBlocks: Master github cbMakefileGen plugin:
https://github.com/kisoft/cbmakefilegen

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7256
Re: sdk/editorcolour.cpp patch (rev.4032). Crash on startup.
« Reply #1 on: November 15, 2007, 12:52:00 pm »
svn4632 works fine for me on Linux and W2k in kvm virtual-machine.
The only difference on W2k) is that I compiled codeblocks (and wxWidgets) with MingW gcc4.2.

Offline kisoft

  • Almost regular
  • **
  • Posts: 194
Re: sdk/editorcolour.cpp patch (rev.4632). Crash on startup.
« Reply #2 on: November 15, 2007, 02:55:57 pm »
svn 4632. I does edit topic subject.
Last revision when I used before 4632 - 4603. All versions after 4603 have crash on startup.
Code
OS      : Microsoft Windows XP Professional
Version: 5.1.2600 Service Pack 2 Build 2600
MinGW 3.4.5, wxWindows 2.8.6

Original line when I patched is:
Code
        Manager::Get()->GetLogManager()->Log(_("Found %d lexers"), count);
My new line is:
Code
        Manager::Get()->GetLogManager()->Log(F(_("Found %d lexers"), count));

Anybody can see method
Code
void EditorColourSet::LoadAvailableSets()
in sdk/editorcolourset.cpp
and will found then line 131 has difference with line 147. I have no comments more.
OS: WinXPSP3
wxWidgets: 2.8.12
CodeBlocks: Master github cbMakefileGen plugin:
https://github.com/kisoft/cbmakefilegen

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7256
Re: sdk/editorcolour.cpp patch (rev.4632). Crash on startup.
« Reply #3 on: November 15, 2007, 03:17:37 pm »
I think it did not crash for me, because it happens when scanning for user-specific lexers, but I don't have any.

Offline kisoft

  • Almost regular
  • **
  • Posts: 194
Re: sdk/editorcolour.cpp patch (rev.4632). Crash on startup.
« Reply #4 on: November 15, 2007, 03:37:06 pm »
I think it did not crash for me, because it happens when scanning for user-specific lexers, but I don't have any.
My default.conf resides in same directory with codeblocks.exe. I move configs to this path not long ago. Your assumption is cogent argument.
OS: WinXPSP3
wxWidgets: 2.8.12
CodeBlocks: Master github cbMakefileGen plugin:
https://github.com/kisoft/cbmakefilegen