User forums > General (but related to Code::Blocks)
wxWidgets 2.8.7 is RELEASED at 27 nov 2007
killerbot:
have noticed that even wit our script : 160 warnings are coming from wxSmith::Contrib items.
Things like this :
--- Code: ---WXDLLIMPEXP_CHART class wxPoints
{
...
};
--- End code ---
==> warning : attribute ignored in declaration of 'class wxPoints'
==> warning : attribute for 'class wxPoints' must follow the 'class' keyword
:-( : it seems not all those attributes stuff is already fixed in wx287, and not that our script (which adds: -Wno-attributes) doesn't seem to help either for these warnings.
stahta01:
--- Quote from: killerbot on November 19, 2007, 02:59:31 pm ---have noticed that even wit our script : 160 warnings are coming from wxSmith::Contrib items.
Things like this :
--- Code: ---WXDLLIMPEXP_CHART class wxPoints
{
...
};
--- End code ---
==> warning : attribute ignored in declaration of 'class wxPoints'
==> warning : attribute for 'class wxPoints' must follow the 'class' keyword
:-( : it seems not all those attributes stuff is already fixed in wx287, and not that our script (which adds: -Wno-attributes) doesn't seem to help either for these warnings.
--- End quote ---
I fixed the ones in wxWidgets, but the above is from wxChart which is not part of wxWidgets. And, does the WXDLLIMPEXP_CHART in the wrong place for GCC.
http://wxcode.sourceforge.net/components/wxchart/
Tim S
stahta01:
Patch to wxChart/wxSmith ContribItems needs tested no idea if it runs.
Did two things changed "WXDLLIMPEXP_CHART class wxChartWindow" to "class WXDLLIMPEXP_CHART wxChartWindow" for sevaral classes. And, defined, WXMAKINGDLL_CHART.
By defining WXMAKINGDLL_CHART, WXDLLIMPEXP_CHART is defined as WXEXPORT. But, I think it was most likely being ignored before this patch, in which case defining WXDLLIMPEXP_CHART as an empty string might be correct. This would require editing chartdef.h.
Tim S
Updated patch, forgot to save wxSmith ContribItems before creating.
--- Code: ---Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartwindow.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartwindow.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartwindow.h (working copy)
@@ -33,7 +33,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxChartWindow : public wxWindow
+class WXDLLIMPEXP_CHART wxChartWindow : public wxWindow
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/piechartpoints.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/piechartpoints.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/piechartpoints.h (working copy)
@@ -26,7 +26,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxPieChartPoints : public wxChartPoints
+class WXDLLIMPEXP_CHART wxPieChartPoints : public wxChartPoints
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/xaxis.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/xaxis.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/xaxis.h (working copy)
@@ -24,7 +24,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxXAxis : public wxAxis
+class WXDLLIMPEXP_CHART wxXAxis : public wxAxis
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/yaxis.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/yaxis.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/yaxis.h (working copy)
@@ -24,7 +24,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxYAxis : public wxAxis
+class WXDLLIMPEXP_CHART wxYAxis : public wxAxis
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/legend.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/legend.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/legend.h (working copy)
@@ -72,7 +72,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxLegend
+class WXDLLIMPEXP_CHART wxLegend
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartpoints.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartpoints.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartpoints.h (working copy)
@@ -39,7 +39,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxChartPoints
+class WXDLLIMPEXP_CHART wxChartPoints
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chart.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chart.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chart.h (working copy)
@@ -40,7 +40,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxChart
+class WXDLLIMPEXP_CHART wxChart
{
public:
wxChart();
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/axis.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/axis.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/axis.h (working copy)
@@ -23,7 +23,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxAxis
+class WXDLLIMPEXP_CHART wxAxis
{
public:
wxAxis(ChartValue max = 0, ChartValue min = 0);
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/bar3dchartpoints.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/bar3dchartpoints.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/bar3dchartpoints.h (working copy)
@@ -26,7 +26,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxBar3DChartPoints : public wxChartPoints
+class WXDLLIMPEXP_CHART wxBar3DChartPoints : public wxChartPoints
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/points.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/points.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/points.h (working copy)
@@ -57,7 +57,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxPoints
+class WXDLLIMPEXP_CHART wxPoints
{
public:
wxPoints();
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/label.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/label.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/label.h (working copy)
@@ -35,7 +35,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxLabel
+class WXDLLIMPEXP_CHART wxLabel
{
public:
void Draw(CHART_HPAINT hp, int x, int y, ChartColor c,
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/pie3dchartpoints.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/pie3dchartpoints.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/pie3dchartpoints.h (working copy)
@@ -26,7 +26,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxPie3DChartPoints : public wxChartPoints
+class WXDLLIMPEXP_CHART wxPie3DChartPoints : public wxChartPoints
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartpointstypes.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartpointstypes.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartpointstypes.h (working copy)
@@ -27,7 +27,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxChartPointsTypes
+class WXDLLIMPEXP_CHART wxChartPointsTypes
{
private:
enum CHART_POINTS_TYPES
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartcolors.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartcolors.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartcolors.h (working copy)
@@ -54,7 +54,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxChartColors
+class WXDLLIMPEXP_CHART wxChartColors
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/barchartpoints.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/barchartpoints.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/barchartpoints.h (working copy)
@@ -26,7 +26,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxBarChartPoints : public wxChartPoints
+class WXDLLIMPEXP_CHART wxBarChartPoints : public wxChartPoints
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/xaxiswindow.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/xaxiswindow.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/xaxiswindow.h (working copy)
@@ -32,7 +32,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxXAxisWindow : public wxWindow
+class WXDLLIMPEXP_CHART wxXAxisWindow : public wxWindow
{
public:
wxXAxisWindow() {}; // for IMPLEMENT_DYNAMIC_CLASS
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/yaxiswindow.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/yaxiswindow.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/yaxiswindow.h (working copy)
@@ -42,7 +42,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxYAxisWindow : public wxWindow
+class WXDLLIMPEXP_CHART wxYAxisWindow : public wxWindow
{
public:
wxYAxisWindow() {}; // for IMPLEMENT_DYNAMIC_CLASS
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/legendwindow.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/legendwindow.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/legendwindow.h (working copy)
@@ -32,7 +32,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxLegendWindow : public wxWindow
+class WXDLLIMPEXP_CHART wxLegendWindow : public wxWindow
{
public:
wxLegendWindow() {}; // for IMPLEMENT_DYNAMIC_CLASS
Index: src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartctrl.h
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartctrl.h (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxchart/wxchart-1.0/include/wx/chartctrl.h (working copy)
@@ -48,7 +48,7 @@
// INTERFACE:
//
//----------------------------------------------------------------------E-+++
-WXDLLIMPEXP_CHART class wxChartCtrl : public wxScrolledWindow
+class WXDLLIMPEXP_CHART wxChartCtrl : public wxScrolledWindow
{
public:
Index: src/plugins/contrib/wxSmithContribItems/wxSmithContribItems.cbp
===================================================================
--- src/plugins/contrib/wxSmithContribItems/wxSmithContribItems.cbp (revision 4640)
+++ src/plugins/contrib/wxSmithContribItems/wxSmithContribItems.cbp (working copy)
@@ -41,6 +41,7 @@
<Add option="-DwxUSE_UNICODE" />
<Add option="-DWXMAKINGLIB_PROPGRID" />
<Add option="-DWXMAKINGDLL_THINGS" />
+ <Add option="-DWXMAKINGDLL_CHART" />
<Add directory="$(#cb)\include" />
<Add directory="$(#cb)\include\wxscintilla\include" />
<Add directory="$(#cb)\include\wxFlatNotebook\include" />
--- End code ---
killerbot:
GOOD news : after fixing some more warnings CB can now be build on windows with MinGW GCC 4.2.1 and wx 2.8.7 without our special script. Nothing special to that BUT the amount of warnings is reduced to 1 !!!
That one warning left is in the exporter plug-in : wxPdfDocument:pdffont.cpp
--- Code: --- wxChar c = s[i];
if (c >= 0 && c < 128)
--- End code ---
the if test is always true due to limited range of data type.
That warnings has been there for years, I wonder if the analysis is correct. Back in the days I was told that for ansi build this warning is correct but not for unicode build. However I get this warning in unicode build (or is the plug-in overriding and are we building that part of it in ansi after all ?).
Well apart from that, things look good. Once wx287 is out officially, nightly builds will switch to it (I am already using it now for 2 weeks and seen no problems) and all cbp files will be adjusted to no longer use the special build script and the special build script will be removed.
The only other thing which is left are the 'info' after some linking steps. I haven't investigated in those, but ideas are always welcome ;-)
stahta01:
--- Quote from: killerbot on November 24, 2007, 04:19:10 pm ---Well apart from that, things look good. Once wx287 is out officially, nightly builds will switch to it (I am already using it now for 2 weeks and seen no problems) and all cbp files will be adjusted to no longer use the special build script and the special build script will be removed.
--- End quote ---
They updated the wx287 being tested on 21-Nov-2007; you might wish to test the new changes.
Many Mac changes were done.
Tim S
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version