Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
SVNInside : development of another SVN plugin for CodeBlocks
mandrav:
Here's a patch against trunk that makes this plugin work with the latest changes in our repository.
As a side bonus, there's also a unix project file and post build steps script.
[attachment deleted by admin]
mandrav:
I have some constructive criticism to make, if I 'm allowed to do so.
Please do NOT save the user's password in the project file, not at least without asking first. If the user later sends this project file to someone else, all of the sudden the rest of the world knows his secret password. This can be very bad...
I see two solutions to this problem:
[*] If you must save the password, at least save it in encrypted form and, in all cases, ask the user for his consent FIRST.
[*] Do not save the password. Save the other options if you want but not the password. Ask the user for the password on first connection and keep it in memory until the project is closed. I believe this would be the better course of action.
Other than that, nice job :).
Although I got a couple of crashes because of double-freeing variables but these things happen and I guess you 'll eventually fix them.
orel:
--- Quote from: mandrav on November 12, 2007, 02:20:44 pm ---Here's a patch against trunk that makes this plugin work with the latest changes in our repository.
As a side bonus, there's also a unix project file and post build steps script.
--- End quote ---
I was 2 days out of there, and then, you post a patch to fix this strange problem i couldn't reproduce. As a bonus, i get all my project need to get it compile and work on unix : Thank you very much Mandrav.
--- Quote from: mandrav on November 12, 2007, 02:40:03 pm ---I have some constructive criticism to make, if I 'm allowed to do so.
--- End quote ---
For sure, that's what i'm expecting from people !
--- Quote from: mandrav on November 12, 2007, 02:40:03 pm ---Please do NOT save the user's password in the project file, not at least without asking first. If the user later sends this project file to someone else, all of the sudden the rest of the world knows his secret password. This can be very bad...
I see two solutions to this problem:
[*] If you must save the password, at least save it in encrypted form and, in all cases, ask the user for his consent FIRST.
--- End quote ---
I was thinking of that, but i found this to be not so secure because people can always crack it...
--- Quote from: mandrav on November 12, 2007, 02:40:03 pm ---[*] Do not save the password. Save the other options if you want but not the password. Ask the user for the password on first connection and keep it in memory until the project is closed. I believe this would be the better course of action.
--- End quote ---
That's the solution i found to be the best. When you open a project needing a passowrd, you set it in the project options.As long as it is opened, you won't need to retype it. That will be implemented this way.
--- Quote from: mandrav on November 12, 2007, 02:40:03 pm ---Other than that, nice job :).
Although I got a couple of crashes because of double-freeing variables but these things happen and I guess you 'll eventually fix them.
--- End quote ---
Thanxs. Obviously, when i get one, i fix it. But in order to help me, maybe you can tell me when you see one.
So have you try it on linux-unix ? Did you find something wrong, did it work ?
mandrav:
--- Quote ---So have you try it on linux-unix ? Did you find something wrong, did it work ?
--- End quote ---
Obviously I did try it but didn't do much with it because it crashed twice on me.
The reproducible crash is:
1. open a project which is under svn control (but you haven't configured svninside for it yet - I chose the codeblocks.cbp for that).
2. in the svn tree, right-click on the project root and select properties.
3. don't change anything in the dialog
4. press connect
5. press ok
6. pooof :)
The other crash occurred when I clicked refresh on the project root (another project). I had also clicked refresh on one of the files in it before, don't know if that matters.
MortenMacFly:
Hehe... I guess Yiannis has broken this plugin "successfully" again. ;-)
But it's easy: Just add those two lines on the beginning of SVNInsideLogger.cpp:
--- Code: ---template<> SVNInsideLogger* Mgr<SVNInsideLogger>::instance = 0;
template<> bool Mgr<SVNInsideLogger>::isShutdown = false;
--- End code ---
(Just like in the other managers, too - see modifications in r4629.)
With regards, Morten.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version