Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Unicode conversion (attention all devs)

<< < (10/23) > >>

byo:

--- Quote from: Ceniza on August 05, 2005, 11:32:51 pm ---

--- Code: ---#ifdef wxUSE_UNICODE
        formattedText << wxString(formatter.nextLine().c_str(), wxConvLocal);
#else
        formattedText << formatter.nextLine().c_str();
#endif
--- End code ---


--- End quote ---

Hmm, wont the first form work both in unicode and non-unicode version ? In files I've changed it works. It's in headers wxstring.h:

when in Unicode:

--- Code: ---#if wxUSE_UNICODE
    // from multibyte string
  wxString(const char *psz, wxMBConv& conv, size_t nLength = npos);

--- End code ---

when not:


--- Code: ---  wxString(const wxChar *psz, wxMBConv& WXUNUSED(conv), size_t nLength = npos)
      : wxStringBase(psz, nLength == npos ? wxStrlen(psz) : nLength) { }

--- End code ---
(here wxChar is equal to char)

so when in non-unicode version the secondargument wil be ignored.

Ceniza:
So keeping it the evil way would work for both...

Well, I'll leave it that way (with the #ifdef) so the ASCII build won't need to create a wxString object unnecessarily.

I would also like to inform you the help plugin is ready for UNICODE too, but only in HEAD.

I just tried to commit the changes to the AStyle plugin and CVS rejected, so I'll e-mail them.

I'm gonna commit the help plugin changes to HEAD though.

rickg22:
~ code is tested Logically.

:? What is that supposed to mean? Anyway, I'm thinking it would be better if all the SDK changes were mailed to me personally.

Anyway guys, send me personal message (NOT mail!) for the changes in status. I'll modify the above table since i'm a webadmin, too ;-)

byo:
My current progress :

Edited by rick - changes posted above

Will handle the rest tomorrow :)

tiwag:

--- Quote from: rickg22 on August 06, 2005, 12:22:51 am ---~ code is tested Logically.
:? What is that supposed to mean?
...
--- End quote ---

it means - after your edited source code module is compiling without errors or warnings,
look what is this just edited module doing and test this functionality explicitly
in the newly built codeblocks.

ie
it is the last step before sending the modified files to YOU RICK !!

we could rename this symbol to "sent to rick"  :D

Navigation

[0] Message Index

[#] Next page

[*] Previous page