Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

autorevision.h

<< < (2/2)

thomas:

--- Quote ---Thomas, although you don't seem to agree, you put the basis for the same thing. Only the requested cpp file by me, already exists : configmanager-revision.cpp.
--- End quote ---
It's not that I don't agree, I just think the gains are worth the pain and the possible troubles. But like I said, you're free to do it. As long as it doesn't break anything, I'm fine :)


--- Quote ---Now get rid of the f*** defines :
--- End quote ---
There was a reason for the presence of those #defines, and the wrapper functions did not use them inadvertently either, but well... never mind. They're gone now, and it seems to work by accident, so leave it :)

killerbot:
I checked the uses of the defines, and you can see we can do very well without them. Although when I read your words, you seem to think they were needed, could you explain where they should have been used then. You can get everything out of the namespace const's, so why 2 of them also as define ??

thomas:
There are conditions in which global const wxString objects don't work reliably between two shared modules. I don't recall what exactly the conditions were, but using the define to create a "local" copy per shared module always works reliably.

Navigation

[0] Message Index

[*] Previous page