Developer forums (C::B DEVELOPMENT STRICTLY!) > Contributions to C::B
BOUNTY: Notebook class with "close" button at the right
mandrav:
@Eran:
I finished converting C::B to use wxFlatNotebook for the editors.
Here's the patch with the absolutely needed changes. Review it and use it :)
Also, as a sidenote, you might want to make at least the public wxFlatNotebook functions virtual. One might want to override some of its behaviour...
(darn, all the trouble was coming from the opened files tree...)
EDIT: forgot the attachment, lol.
[attachment deleted by admin]
eranif:
mandrav: Can you please send me the source files? instead of what you sent? (i guess it is an output of the SVN you are using, I am not familiar with it).
I am using araxis to merge the files - so just send out your files, and i will do the rest.
tiwag : I will look at the bugs you reported - tomorrow (I did noticed the first one when only one tab is visible there is no way to scroll right)
Eran
thomas:
Eran, you really want to learn to use svn. Seriously, you do yourself a favour, greater than you can possibly imagine.
I have been programming without revision control for many years, and sure enough, you can do that. Occasionally you will spend an afternoon trying to undo the changes of yesterday because they don't work, and occasionally you will be searching for your backup disks in cold sweat, and sometimes you will be asking yourself when you changed a particular file, and why. But yes, it mostly works.
A revision control system such as svn makes your life a lot happier and easier by taking all these problems out of your hands (it also makes merging easier). As an allegory, think of crossing the Atlantic Ocean. You can do that in a canoo, or you can fly in a jet. Both methods work, most of the time :)
If you use TortoiseSVN (tortoisesvn.tigris.org) then doing revision control is as easy as a right-click on a folder.
A good introduction about revision control (in particular svn) works can be found here: http://svnbook.red-bean.com/en/1.1/svn-book.html
mandrav:
--- Quote from: eranif on January 04, 2006, 01:04:44 am ---
mandrav: Can you please send me the source files? instead of what you sent? (i guess it is an output of the SVN you are using, I am not familiar with it).
I am using araxis to merge the files - so just send out your files, and i will do the rest.
--- End quote ---
Sure, here are the files.
But the file I posted before is a unified diff. I 'm sure araxis merge can "apply" it to your sources.
[attachment deleted by admin]
rickg22:
Just in case: You can analyse the patch "by eye" and do the changes manually.
Example:
--- Code: ---+++ wxFlatNotebook\include\wx\wxFlatNotebook\wxFlatNotebook.h Tue Jan 03 23:45:17 2006
@@ -104,7 +104,7 @@
/**
\param page - index of page to be deleted
*/
- void DeletePage(size_t page);
+ void DeletePage(size_t page, bool notify = true);
/// Deletes all notebook pages and destroys all windows associated with pages
bool DeleteAllPages();
--- End code ---
Thie line "+++ wxFlatNotebook...etc" says which file is to be modified.
The lines before the - and + are the context - they tell you (or the patcher) where the modification is to be found. So if you search for "param page - index of page to be deleted", you'll find the lines.
The "- void DeletePage(size_t page);" means this line is to be replaced. The "+ void DeletePage(size_t page, bool notify = true);" is the replacement.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version