Author Topic: BOUNTY: Notebook class with "close" button at the right  (Read 137361 times)

Offline eranif

  • Regular
  • ***
  • Posts: 256
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #135 on: January 05, 2006, 10:28:40 pm »
Thanks, I will.

- However, I already fixed the SetSelection() function, unless you find some other new bug in it.
 

Quote
When I commit the changes, you can take a look at the patch. I believe three fixes there will interest you

I dont have access to your SVN, so how will I be able to see the changes?

I assumed that when adding a window to the book, the parent of the new added window is the book itself

Btw, Did you get any progress with the Linux building and displaying?

Eran

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #136 on: January 05, 2006, 10:37:42 pm »
- However, I already fixed the SetSelection() function, unless you find some other new bug in it.

Yes, new :)

I dont have access to your SVN, so how will I be able to see the changes?

When I commit (in a while), you will find it here.

I assumed that when adding a window to the book, the parent of the new added window is the book itself

Well, someone has to take ownership. If you want to see the effect, create one page with the frame as its parent and then add it in the notebook...

Btw, Did you get any progress with the Linux building and displaying?

What's wrong with it? It looks and works fine.
Be patient!
This bug will be fixed soon...

Offline eranif

  • Regular
  • ***
  • Posts: 256
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #137 on: January 05, 2006, 10:42:10 pm »
I thought that earlier here, Ceniza I think said that he wasnt able to see anything on Linux using wxFlatNotebook.

So, If it is OK, no problem here

Eran

Offline rickg22

  • Lives here!
  • ****
  • Posts: 2283
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #138 on: January 05, 2006, 10:43:39 pm »
eranif: How about giving Yiannis developer access to your class? :)

Offline eranif

  • Regular
  • ***
  • Posts: 256
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #139 on: January 05, 2006, 10:45:38 pm »
Hmmm,

Who is Yiannis?

Lol

Eran

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #140 on: January 05, 2006, 10:47:20 pm »
Be patient!
This bug will be fixed soon...

Offline eranif

  • Regular
  • ***
  • Posts: 256
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #141 on: January 05, 2006, 10:50:15 pm »
No, Problem - Will be easier for the patching things ...

I just need to figure out how do I do that - will check it now

Eran

Offline eranif

  • Regular
  • ***
  • Posts: 256
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #142 on: January 05, 2006, 10:52:06 pm »
Mandrav, Ok, I need to have your sourceforge user name
Eran

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #143 on: January 05, 2006, 10:54:40 pm »
Mandrav, Ok, I need to have your sourceforge user name

mandrav :)
Be patient!
This bug will be fixed soon...

Offline eranif

  • Regular
  • ***
  • Posts: 256
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #144 on: January 05, 2006, 10:54:48 pm »
Nevermind that ... already got it - mandrav is the user name in SF
You are now member in the wxflatnotebook project

Eran

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1441
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #145 on: January 05, 2006, 10:56:04 pm »
I just built Code::Blocks under Linux and the wxFlatNotebook is showing right.

I couldn't see anything with the test program (it was that or the crash), but haven't tested with a more recent version. Maybe it has something to do with one of those changes made by mandrav (maybe the Reparent one?).

I can see the changes to MessageManager have been just committed :)

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1441
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #146 on: January 05, 2006, 10:59:20 pm »
Forgot to ask something in the last post :(

mandrav: have you enabled the option to choose if the notebook will be shown at the top or the bottom?

[edit]
I just tried it and see it's hardcoded to be bottom for Messages, but you answered already.

I also noticed the space used by the X button when it doesn't exist is still there. Somebody in wxforum fixed it, but I didn't try it http://wxforum.shadonet.com/viewtopic.php?p=26829#26829.
[/edit]
« Last Edit: January 05, 2006, 11:17:07 pm by Ceniza »

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #147 on: January 05, 2006, 11:12:20 pm »
Forgot to ask something in the last post :(

mandrav: have you enabled the option to choose if the notebook will be shown at the top or the bottom?

Not yet. I just set bottom for the Messages but I will add configuration settings for this.
Be patient!
This bug will be fixed soon...

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #148 on: January 05, 2006, 11:45:06 pm »
Nevermind that ... already got it - mandrav is the user name in SF
You are now member in the wxflatnotebook project

Thanks Eran :)
Be patient!
This bug will be fixed soon...

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1441
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #149 on: January 06, 2006, 05:03:54 pm »
Finally, now Code::Blocks is using wxFlatNotebook "everywhere" (three places really), but the Messages notebook is hardcoded to be top and the editor one to always be fancy :(