Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

[wxSmith]: 2 minor issues

(1/1)

MortenMacFly:
Dear Byo,
2 minor issues I've  just discovered:
1.) wxscoder.cpp: Line 171 should read:

--- Code: ---for ( size_t i=0; i<Content.Length(); i++ )
--- End code ---
to avoid compiler warnings.
2.) wxscustombutton.cpp: Line 99:

--- Code: ---Style.RemoveLast();
--- End code ---
is not compatible with wx 2.6.x as there is no such method "RemoveLast()". Maybe you will guard this?
With regards, Morten.

byo:

--- Quote from: MortenMacFly on May 30, 2007, 08:26:43 am ---Dear Byo,
2 minor issues I've  just discovered:
1.) wxscoder.cpp: Line 171 should read:

--- Code: ---for ( size_t i=0; i<Content.Length(); i++ )
--- End code ---
to avoid compiler warnings.

--- End quote ---

Right, that's correct.


--- Quote ---2.) wxscustombutton.cpp: Line 99:

--- Code: ---Style.RemoveLast();
--- End code ---
is not compatible with wx 2.6.x as there is no such method "RemoveLast()". Maybe you will guard this?
With regards, Morten.

--- End quote ---

And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

Regards
  BYO

MortenMacFly:

--- Quote from: byo on May 30, 2007, 10:40:26 am ---And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

--- End quote ---
Sorry Byo, my mistake. I meant: EndsWith() in line 97. The error is:

--- Code: ---C:\Devel\CodeBlocks\src\plugins\contrib\wxSmithContribItems\wxthings\wxscustombutton.cpp:97: error: 'class wxString' has no member named 'EndsWith'

--- End code ---
Sorry... ;-)
With regard, Morten.

byo:

--- Quote from: MortenMacFly on May 30, 2007, 11:13:53 am ---
--- Quote from: byo on May 30, 2007, 10:40:26 am ---And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

--- End quote ---
Sorry Byo, my mistake. I meant: EndsWith() in line 97. The error is:

--- Code: ---C:\Devel\CodeBlocks\src\plugins\contrib\wxSmithContribItems\wxthings\wxscustombutton.cpp:97: error: 'class wxString' has no member named 'EndsWith'

--- End code ---
Sorry... ;-)
With regard, Morten.

--- End quote ---

Hmm, now you're right. But finally I had to remove EndsWith because this code was buggy (fixed version doesn't require EndsWith call).

Thanks for reporting :)

BYO

Navigation

[0] Message Index